)]}'
{"id":"openocd~master~Id66a808475f061307fc6a0b3e0d2a9840b543e7f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2026-02-15 18:19:34.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id66a808475f061307fc6a0b3e0d2a9840b543e7f","subject":"tcl/target/lpc8nxx: drop swj on swd only target","status":"MERGED","created":"2026-02-03 21:14:08.000000000","updated":"2026-02-15 18:19:34.000000000","submitted":"2026-02-15 18:19:34.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9437","meta_rev_id":"d423be2f487300c1f9e1d02588e7564a58fad798","_number":9437,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-02-15 18:19:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-02-15 18:19:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-03 21:21:23.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-02-03 22:07:51.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-02-04 15:25:25.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"8419d9a0d456f19eed23ee96dbf4695a848b2827","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2026-02-03 21:14:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9160d9eebb19b450d0d7ed5f5b6e10977661292a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-02-03 22:07:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21737/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22625/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"24632589f0e9b01a98c02db8b1a4e8eb25c0a891","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-04 15:25:25.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e77715a8cc85a6505b7f7012b0e7c84e94dd6219","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-15 18:19:29.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d423be2f487300c1f9e1d02588e7564a58fad798","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-15 18:19:34.000000000","message":"Change has been successfully cherry-picked as 86bdd882821d0f53ea14c6f1637bdb340dfc4117","accounts_in_message":[],"_revision_number":2}],"current_revision":"86bdd882821d0f53ea14c6f1637bdb340dfc4117","revisions":{"86bdd882821d0f53ea14c6f1637bdb340dfc4117":{"kind":"REWORK","_number":2,"created":"2026-02-15 18:19:34.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/37/9437/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/9437/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/9437/2 \u0026\u0026 git checkout -b change-9437 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/9437/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/9437/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/9437/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/9437/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/9437/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0163d9ddba9455da5adf91ff6906250a878b27fb","subject":"tcl/target/psoc4: drop swj on swd only targets"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-02-03 20:57:00.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-02-15 18:19:34.000000000","tz":0},"subject":"tcl/target/lpc8nxx: drop swj on swd only target","message":"tcl/target/lpc8nxx: drop swj on swd only target\n\nHistorically swj_newdap was necessary to handle HLA properly\nSince commit 60f104f45013 (\"hla_transport: split command\nregistration per transport\") there is no point in using\nswj_newdap on SWD only devices.\n\nThere are no relevant board files.\n\nChange-Id: Id66a808475f061307fc6a0b3e0d2a9840b543e7f\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9437\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"c7543e7e8e7dabdbe15ba07b8843f78ffbfe27cf":{"kind":"REWORK","_number":1,"created":"2026-02-03 21:14:08.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/37/9437/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/9437/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/9437/1 \u0026\u0026 git checkout -b change-9437 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/9437/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/9437/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/9437/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/9437/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/9437/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6276cff05b95fc77e74e50aa4cae13430da85adf","subject":"tcl/target/psoc4: drop swj on swd only targets"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-02-03 20:57:00.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-02-03 20:57:00.000000000","tz":60},"subject":"tcl/target/lpc8nxx: drop swj on swd only target","message":"tcl/target/lpc8nxx: drop swj on swd only target\n\nHistorically swj_newdap was necessary to handle HLA properly\nSince commit 60f104f45013 (\"hla_transport: split command\nregistration per transport\") there is no point in using\nswj_newdap on SWD only devices.\n\nThere are no relevant board files.\n\nChange-Id: Id66a808475f061307fc6a0b3e0d2a9840b543e7f\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}