)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"288cebd51066413114c375c76180b7768c5f3e1f","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"\u003e On if statements where the condition is split among multiple lines,"},{"line_number":12,"context_line":"\u003e increase the indentation of the condition to prevent it to match to the"},{"line_number":13,"context_line":"\u003e indentation of the then block due to length of \u0027if (\u0027"},{"line_number":14,"context_line":"[...]"},{"line_number":15,"context_line":"\u003e Variables declarations should occur at the point of first use"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"69764985_ae417d5a","line":13,"updated":"2026-02-08 16:43:09.000000000","message":"The comment here is intended to suggest to add more TABs. See my comment in the code","commit_id":"9fc7c884e9d5d6ab3f23ac3edb7ca97850a7e66e"},{"author":{"_account_id":1002493,"name":"Jérôme Pouiller","email":"jerome.pouiller@silabs.com","username":"jerome-pouiller"},"change_message_id":"1f1fde9fa2c3ba629dac03935206745e8611c891","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"\u003e On if statements where the condition is split among multiple lines,"},{"line_number":12,"context_line":"\u003e increase the indentation of the condition to prevent it to match to the"},{"line_number":13,"context_line":"\u003e indentation of the then block due to length of \u0027if (\u0027"},{"line_number":14,"context_line":"[...]"},{"line_number":15,"context_line":"\u003e Variables declarations should occur at the point of first use"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b5aadabd_adfa79b8","line":13,"in_reply_to":"69764985_ae417d5a","updated":"2026-02-10 17:25:13.000000000","message":"Ack","commit_id":"9fc7c884e9d5d6ab3f23ac3edb7ca97850a7e66e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"df903312e2dd2899c8c16cf0b39f0e3a02406c0c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e89979b1_53557abe","updated":"2026-02-04 16:55:24.000000000","message":"Sorry, but you should take a look to\nhttps://openocd.org/doc/doxygen/html/stylec.html\nmainly `C99 Rules`","commit_id":"6c7f33cb40ec04ffc0bdfbac08f5ce88bdd74150"},{"author":{"_account_id":1002493,"name":"Jérôme Pouiller","email":"jerome.pouiller@silabs.com","username":"jerome-pouiller"},"change_message_id":"b89be8d147b4e9cdc4471b07c4a7562a3c103f33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"616f2102_bce0ce29","in_reply_to":"e89979b1_53557abe","updated":"2026-02-05 08:29:08.000000000","message":"\u003e new block scopes for selection and iteration statements\n\nYeah, make sense.\n\n\u003e variables declarations should occur at the point of first use\n\nIf one day we have the opportunity to share a beer, I would be curious to have the rationale for this rule :)","commit_id":"6c7f33cb40ec04ffc0bdfbac08f5ce88bdd74150"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"85e61b4c5aa88f36c82bf346960f10e683211ee0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f41e6155_99791ee0","updated":"2026-02-10 20:01:07.000000000","message":"Indent/tab problems introduced here are fixed in 9453: flash/nor/efm32: Fix tab size | https://review.openocd.org/c/openocd/+/9453, so looks good to me.","commit_id":"259b5f094e6747bc07d66a9fdde6607428a892ba"}],"src/flash/nor/efm32.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"eefbd6b3ecb694df9928e89e99cc7c8483b291a2","unresolved":true,"context_lines":[{"line_number":626,"context_line":""},{"line_number":627,"context_line":"\tuint32_t extra_bytes \u003d efm32_info-\u003einfo.page_size - LOCKWORDS_SZ;"},{"line_number":628,"context_line":"\tuint8_t *extra_data \u003d NULL;"},{"line_number":629,"context_line":"\tint ret \u003d 0;"},{"line_number":630,"context_line":"\tif (extra_bytes) {"},{"line_number":631,"context_line":"\t\textra_data \u003d malloc(extra_bytes);"},{"line_number":632,"context_line":"\t\tret \u003d target_read_buffer(bank-\u003etarget,"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"154c3244_2bb59552","line":629,"range":{"start_line":629,"start_character":8,"end_line":629,"end_character":12},"updated":"2026-02-06 19:20:57.000000000","message":"ERROR_OK or no init at all","commit_id":"16bceb425bbf38d3907fb19d097520167b97397d"},{"author":{"_account_id":1002493,"name":"Jérôme Pouiller","email":"jerome.pouiller@silabs.com","username":"jerome-pouiller"},"change_message_id":"51ba378359478d30006cf2e13b3355a5e5eb8610","unresolved":false,"context_lines":[{"line_number":626,"context_line":""},{"line_number":627,"context_line":"\tuint32_t extra_bytes \u003d efm32_info-\u003einfo.page_size - LOCKWORDS_SZ;"},{"line_number":628,"context_line":"\tuint8_t *extra_data \u003d NULL;"},{"line_number":629,"context_line":"\tint ret \u003d 0;"},{"line_number":630,"context_line":"\tif (extra_bytes) {"},{"line_number":631,"context_line":"\t\textra_data \u003d malloc(extra_bytes);"},{"line_number":632,"context_line":"\t\tret \u003d target_read_buffer(bank-\u003etarget,"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"97eca25a_5c5b711a","line":629,"range":{"start_line":629,"start_character":8,"end_line":629,"end_character":12},"in_reply_to":"154c3244_2bb59552","updated":"2026-02-10 17:28:47.000000000","message":"Done","commit_id":"16bceb425bbf38d3907fb19d097520167b97397d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"288cebd51066413114c375c76180b7768c5f3e1f","unresolved":true,"context_lines":[{"line_number":345,"context_line":"\t/* look for an existing flash structure matching target */"},{"line_number":346,"context_line":"\tstruct efm32_flash_chip *efm32_info \u003d NULL;"},{"line_number":347,"context_line":"\tfor (struct flash_bank *bank_iter \u003d flash_bank_list();"},{"line_number":348,"context_line":"\t     bank_iter;"},{"line_number":349,"context_line":"\t     bank_iter \u003d bank_iter-\u003enext) {"},{"line_number":350,"context_line":"\t\tif (bank_iter-\u003edriver \u003d\u003d \u0026efm32_flash \u0026\u0026"},{"line_number":351,"context_line":"\t\t    bank_iter-\u003etarget \u003d\u003d bank-\u003etarget \u0026\u0026"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"e8a23cd1_6391eeca","line":348,"updated":"2026-02-08 16:43:09.000000000","message":"Don\u0027t indent in this way here and in the `if` below, as it makes the conditions at the same level of the body.\nThis is an unfortunate issue caused by using 4 spaces TAB.\nAdd an extra level of indentation. In the example below I use `\\t  ` to highlight a 4 spaces TAB\n```\n\\t  for (struct flash_bank *bank_iter \u003d flash_bank_list();\n\\t  \\t  \\t  bank_iter;\n\\t  \\t  \\t  bank_iter \u003d bank_iter-\u003enext) {\n\\t  \\t  if (bank_iter-\u003edriver \u003d\u003d \u0026efm32_flash \u0026\u0026\n\\t  \\t  \\t  \\t  bank_iter-\u003etarget \u003d\u003d bank-\u003etarget \u0026\u0026\n\\t  \\t  \\t  \\t  bank-\u003edriver_priv) {\n\\t  \\t  \\t  efm32_info \u003d bank-\u003edriver_priv;\n\\t  \\t  \\t  break;\n\\t  \\t  }\n\\t  }\n```","commit_id":"9fc7c884e9d5d6ab3f23ac3edb7ca97850a7e66e"},{"author":{"_account_id":1002493,"name":"Jérôme Pouiller","email":"jerome.pouiller@silabs.com","username":"jerome-pouiller"},"change_message_id":"1f1fde9fa2c3ba629dac03935206745e8611c891","unresolved":false,"context_lines":[{"line_number":345,"context_line":"\t/* look for an existing flash structure matching target */"},{"line_number":346,"context_line":"\tstruct efm32_flash_chip *efm32_info \u003d NULL;"},{"line_number":347,"context_line":"\tfor (struct flash_bank *bank_iter \u003d flash_bank_list();"},{"line_number":348,"context_line":"\t     bank_iter;"},{"line_number":349,"context_line":"\t     bank_iter \u003d bank_iter-\u003enext) {"},{"line_number":350,"context_line":"\t\tif (bank_iter-\u003edriver \u003d\u003d \u0026efm32_flash \u0026\u0026"},{"line_number":351,"context_line":"\t\t    bank_iter-\u003etarget \u003d\u003d bank-\u003etarget \u0026\u0026"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"acf80a88_640593dd","line":348,"in_reply_to":"e8a23cd1_6391eeca","updated":"2026-02-10 17:25:13.000000000","message":"I changed the indentation in commit \"flash/nor/efm32: Fix tab size\".","commit_id":"9fc7c884e9d5d6ab3f23ac3edb7ca97850a7e66e"}]}