)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"a8bc8bb01d27d0cd4eb3a38f53fc1b4af02eb003","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Interfaces used: jlink, olimex-arm-usb-tiny-h, cmsis-dap"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"On openocd master the only command that works (on any adapter) is"},{"line_number":12,"context_line":"reset run."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"With this commit the following works on all adapters:"},{"line_number":15,"context_line":"\tReading flash"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7683a057_8bfbb205","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":10},"updated":"2026-02-10 21:43:59.000000000","message":"Even with SRST physically attached?","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"99630e11fe59ae7d30a44eae164543f9f5ce447f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Interfaces used: jlink, olimex-arm-usb-tiny-h, cmsis-dap"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"On openocd master the only command that works (on any adapter) is"},{"line_number":12,"context_line":"reset run."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"With this commit the following works on all adapters:"},{"line_number":15,"context_line":"\tReading flash"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e92cdd69_76096d73","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":10},"in_reply_to":"7683a057_8bfbb205","updated":"2026-02-10 21:51:08.000000000","message":"Thanks Paul,\n\nhttps://www.analog.com/media/en/technical-documentation/data-sheets/MAX32625-EVKIT.pdf\n\nI am using the MAX32625-EVKIT where srst is connected to MCU srst (according to schematic, and I can see a trace going under the MCU).\nBut I get a timeout error if reset_config srst_only is used with anything except the reset run command.\nSo, yes it seems to happen with SRST attached.\n\nOpen On-Chip Debugger 0.12.0+dev-02395-g00f768fd6 (2026-02-10-10:55)\nLicensed under GNU GPL v2\nFor bug reports, read\n        http://openocd.org/doc/doxygen/bugs.html\nWarn : DEPRECATED: auto-selecting transport \"jtag\". Use \u0027transport select jtag\u0027 to suppress this message.\nInfo : [max32xxx.cpu] Hardware thread awareness created\nWarn : An adapter speed is not selected in the init scripts. OpenOCD will try to run the adapter at very low speed (100 kHz).\nWarn : To remove this warnings and achieve reasonable communication speed with the target, set \"adapter speed\" or \"jtag_rclk\" in the init scripts.\nInfo : clock speed 100 kHz\nInfo : JTAG tap: max32xxx.cpu tap/device found: 0x4ba00477 (mfg: 0x23b (ARM Ltd), part: 0xba00, ver: 0x4)\nInfo : JTAG tap: rsvtap.tap tap/device found: 0x07f71197 (mfg: 0x0cb (Maxim Integrated Product), part: 0x7f71, ver: 0x0)\nInfo : [max32xxx.cpu] Cortex-M4 r0p1 processor detected\nInfo : [max32xxx.cpu] target has 6 breakpoints, 4 watchpoints\nInfo : [max32xxx.cpu] Examination succeed\nInfo : [max32xxx.cpu] starting gdb server on 3333\nInfo : Listening on port 3333 for gdb connections\nInfo : JTAG tap: max32xxx.cpu tap/device found: 0x4ba00477 (mfg: 0x23b (ARM Ltd), part: 0xba00, ver: 0x4)\nInfo : JTAG tap: rsvtap.tap tap/device found: 0x07f71197 (mfg: 0x0cb (Maxim Integrated Product), part: 0x7f71, ver: 0x0)\nError: timed out while waiting for target halted\nTARGET: max32xxx.cpu - Not halted","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"d67e857e0074cbc189a4a21e6a8cc89b2940aabe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e6542d48_7b17bef5","updated":"2026-02-10 18:13:15.000000000","message":"Hello Mark, thank you for the patch!\n\nIn OpenOCD \"reset_config none\" is default and it means that no JTAG TRST and SRST are connected. In general a good target should work like that, but also it should work just fine with \"reset_config srst_only\" provided that there\u0027s a physical connection between the debug adapter and the target.\n\nIn general target configs shouldn\u0027t have any \"reset_config\" specification at all unless the target has some quirks that limit it to only a specific arrangement.\n\nYour patch would overwrite the setting provided by end-user in a board config file or in openocd config file when SRST (and/or TRST) are actually connected and expected to be used.\n\nIf this  target is indeed incapable of working properly with hardware reset line used please describe the testing performed (and probably your theories explaining behaviour) in more detail, and add a corresponding comment to the target file where you force not using SRST/TRST even if they\u0027re actually connected and the user asks for that.","commit_id":"60e8baabd94ed83dc2ae11901206bc7e00c3242b"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"8e1ce783fa8e56bbc185f41c2471a22af8a14fcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d94b2f79_d36e22e4","updated":"2026-03-12 10:27:09.000000000","message":"Hello Mark,\nUsually Antonio handles changes that are ready on weekends, and the current state is definitely an improvement, so my impression is that it should go in.\nIt\u0027s kind of disappointing vendor engineers can\u0027t take a deeper look to figure out the exact constraints and potentially offer a workaround to make all reasonable hardware combinations work properly though.","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"93fb3eef04dbcaa5911dc788ff0b67e58aed417b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2508cd40_c7a9c52e","updated":"2026-03-27 15:32:40.000000000","message":"Hi Antonio,\n\nWould you be able to take a look?\n\nThanks,\nMark","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"e3ecccfd9d5453106a273d1599f20d8abde14d11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8fd3087b_bfd24348","updated":"2026-04-24 15:30:31.000000000","message":"Hi Tomas,\nWould you be able to look at this?\nThanks,\nMark","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"561f38aeaa4e9124291f8b0bf189f550c6193638","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7137015f_a2af4206","updated":"2026-02-10 22:12:11.000000000","message":"I see, thanks for the clarifications!\n\nIt looks like this target resets the vector catch on external reset signal and so if one really needs that some workaround would need to be found, probably with the help of manufacturer.\n\nHenrik, can you probably chime in here please?","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"cac5ecb9ae4a8519ee48e4f9236cf6cac5cd40fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c563775f_8a7131b9","updated":"2026-03-12 08:56:44.000000000","message":"Paul, I think this is back to you if you get a chance.\nThanks,\nMark","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"64b115bcd39f1bf43629bcc2cef1562aa165eba6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6a325d3_964bfbb3","updated":"2026-02-11 22:57:02.000000000","message":"Regarding the cmsis-dap issue with reset halt I mentioned in the commit message, I have been testing with this command:\nsrc/openocd -s tcl -f interface/cmsis-dap.cfg -f target/max32625.cfg -c \"init; reset halt; exit\"\n\nOn max32660 and max32670 (with onboard maxpico cmsis-dap adapter) the mcu resets and remains halted as expected.\nThe max32625, max32662 \u0026 max32690 (with external maxpico cmsis-dap adapter) do not remain halted after the command completes, unlike with jlink or the olimex interfaces.\nBut the reset halt command works as expected via telnet.\nSo it looks as if these boards are getting reset again when openocd exits.\n\nThere doesn\u0027t seem to be a single common factor, but it only seems to happen using cmsis-dap on boards with an external power supply.","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"a8bc8bb01d27d0cd4eb3a38f53fc1b4af02eb003","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"10aa9411_84e962ed","updated":"2026-02-10 21:43:59.000000000","message":"Thank you, indeed that\u0027s how a config for a regular (non-quirky) target looks like. I have a question about the commit message though, it still confuses me somewhat.","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"99630e11fe59ae7d30a44eae164543f9f5ce447f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3225a01f_5f9e1003","updated":"2026-02-10 21:51:08.000000000","message":"Thanks for the very prompt reviews","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"ecd895e9953fe41a5d7b20e3d2ac09613ef045aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"99552c1a_2cea04e1","in_reply_to":"2508cd40_c7a9c52e","updated":"2026-04-17 12:40:35.000000000","message":"Another gentle reminder about this. Thanks","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"65bff30553c838e3abcab51954b5db9c36f3cf7b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f295d36a_1df2453c","in_reply_to":"6a3ab5c9_4a17ee28","updated":"2026-04-27 20:03:47.000000000","message":"Thanks Tomas,\nALLOW_LOW_PWR_DBG is not being used, and plain halt does seem to work correctly.\nTo test that I used the following:\nsrc/openocd -s tcl -f interface/jlink.cfg -f target/max32625.cfg -c \"init; halt; shutdown\"\n\nBut the following gives error \"Error: timed out while waiting for target halted\": \nsrc/openocd -s tcl -f interface/jlink.cfg -f target/max32625.cfg -c \"init; reset halt; shutdown\"\n\nI do not get that error with \"reset_config trst_only\" or \"reset_config srst_gates_jtag\".\nShould I be selecting the latter?\nCould there be something missing, similar to the \"adapter srst delay\" perhaps?\n\nBehaviour is the same with jtag and swd.\n\nI will add a comment.","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"f4950adc24250d6aff80ad22d7a1d0a61b5363b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8c13cfdf_101f15f2","in_reply_to":"7137015f_a2af4206","updated":"2026-02-18 11:13:42.000000000","message":"Hi Paul,\n\nI\u0027ll look into this and get back to you.","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1002302,"name":"Henrik Mau","display_name":"Henrik Mau","email":"henrik.mau@analog.com","username":"hmauadi"},"change_message_id":"d0527582bc9006d7e8aec8f245bb8c6be0c3a758","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"258c06a1_1c4dd123","in_reply_to":"8c13cfdf_101f15f2","updated":"2026-02-24 15:10:37.000000000","message":"Hi Paul,\n\nWhilst there are some differences in the way reset and the debug interface is handled among those parts any difference in behavior as mentioned is not expected. Speculation is that it may be down to an issue in the firmware loaded into the maxpico used as the behaviour is changing based on whether an internal or external adapter is being used.","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"69205a2d6bf38d42cf7e4ac1265c2b9c5f7a89e6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a3ab5c9_4a17ee28","in_reply_to":"8fd3087b_bfd24348","updated":"2026-04-27 17:10:07.000000000","message":"Mark, I don\u0027t have any MAX MCU, neither any experience with.\nSeems me almost unbelievable that with wrong reset_config both flash read and write does not work. Perhaps ALLOW_LOW_PWR_DBG was used? (see max32xxx_common.cfg) Plain \u0027halt\u0027 didn\u0027t work?\n\nAnyway I would recommend to add a comment to the config file that `reset halt` does not work in `reset_config srst_only` config to save bad surprises for other users.","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"282568f9b2fca47792197b24ef15a155860178cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5cfe7d29_75e30356","in_reply_to":"b427c31b_1497f3a9","updated":"2026-05-08 13:09:38.000000000","message":"I have never tested with enable_debug so I have added a TODO here:\nhttps://review.openocd.org/c/openocd/+/9632","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7c96865640ab6f3f7a84e47b75d5862695c4d05c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b427c31b_1497f3a9","in_reply_to":"f295d36a_1df2453c","updated":"2026-04-27 20:48:58.000000000","message":"`srst_gates_jtag` is the default option and there is no opposite `srst_nogate` in this config nor in max32xxx_common.cfg so no point in explicitly setting `srst_gates_jtag`\n\nBesides `adapter srst delay` you may also configure \u0027adapter srst pulse_width\u0027. I doubt it would help here.\n\nI looked again to ALLOW_LOW_PWR_DBG. Tcl `proc enable_debug()` is just a simplified version of `halt` command. No idea why the Tcl re-implementation is necessary...","commit_id":"d443b3447758ca25c1739b0132391629d0c7c48d"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"643dbf22a4f66af21199190ac085c256a3ecd2a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8b1ccfee_9af18bfc","updated":"2026-05-15 08:27:45.000000000","message":"Hi guys,\nThis has been submittable for a while, so can we think about submitting?\nLet me know if reminders like this are not required.\nAnother question I had was if I should add reviewers myself, and if so should I add several or just one?\nI imagine you get a lot of email already :)\nThanks","commit_id":"c25078bb296247d0488009eb31b676374b53b6a2"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"282568f9b2fca47792197b24ef15a155860178cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e7204df6_47a8ad8f","updated":"2026-05-08 13:09:38.000000000","message":"Thanks","commit_id":"c25078bb296247d0488009eb31b676374b53b6a2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4d974e0c35cb6e27947c0cb3aa68d4ef010fe28b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e0a20c8_61c4d50a","updated":"2026-04-28 05:41:59.000000000","message":"Thanks!","commit_id":"c25078bb296247d0488009eb31b676374b53b6a2"}]}