)]}'
{"id":"openocd~master~I6cf9242ab8206184bff9390ef0245843261656bd","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2026-03-08 10:25:35.000000000","reason":"Change was submitted"},"1002072":{"account":{"_account_id":1002072,"name":"Anatoly Parshintsev","username":"aap-sc"},"last_update":"2026-03-08 10:25:35.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6cf9242ab8206184bff9390ef0245843261656bd","subject":"server/server: Fix build on FreeBSD","status":"MERGED","created":"2026-02-26 09:26:48.000000000","updated":"2026-03-08 10:25:35.000000000","submitted":"2026-03-08 10:25:35.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9477","meta_rev_id":"cab0f9118f871e7185355f42ce4d2e4f39324943","_number":9477,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-03-08 10:25:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-03-08 10:25:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-03-08 10:25:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1002072,"name":"Anatoly Parshintsev","username":"aap-sc"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002072,"name":"Anatoly Parshintsev","username":"aap-sc"},{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-26 09:27:01.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-02-26 09:49:15.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-02-26 10:19:57.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2026-02-26 10:19:57.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002072,"name":"Anatoly Parshintsev","username":"aap-sc"},"state":"REVIEWER"},{"updated":"2026-02-27 06:52:27.000000000","updated_by":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"reviewer":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"state":"REVIEWER"}],"messages":[{"id":"47477cb81312c974c758a68070abe79fe8f2f53f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-02-26 09:26:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4457fff3f1c6aa68f21e107897aadb4b559e47e3","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-02-26 09:49:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21872/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22762/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"bf169e1bc24349b7729330d058c7aa231030085c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-26 10:19:57.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"49ad8c013b892d183a72f3b01d8fcf07534513a0","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2026-02-27 06:52:27.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b23dbc5b12933106a26c93981dd4cb62e52a5c00","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2026-02-27 06:59:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3c696b4ff53f089b59b883417f54842d51a4ee28","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2026-02-27 07:05:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5f72b74b541d822883392dc2e620994bc5c6d01c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-08 10:25:29.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cab0f9118f871e7185355f42ce4d2e4f39324943","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-08 10:25:35.000000000","message":"Change has been successfully cherry-picked as e4c49d86052dfc241ec60bbd3b7e190307891722","accounts_in_message":[],"_revision_number":2}],"current_revision":"e4c49d86052dfc241ec60bbd3b7e190307891722","revisions":{"7c62d1b59f52a94a361275dee305a50c89e2a27c":{"kind":"REWORK","_number":1,"created":"2026-02-26 09:26:48.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/77/9477/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/9477/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/9477/1 \u0026\u0026 git checkout -b change-9477 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/9477/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/9477/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/9477/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/9477/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/9477/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"129e9d30055e5cbed5ad6f0229772a3dc89fa529","subject":"configure.ac: Replace --enable-malloc-logging with a new runtime log level."}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-02-26 09:14:34.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-02-26 09:25:23.000000000","tz":60},"subject":"server/server: Fix build on FreeBSD","message":"server/server: Fix build on FreeBSD\n\nOn FreeBSD, sig_atomic_t is of type \u0027long\u0027 rather than \u0027int\u0027. Remove\nthe assert() instead of replacing it with a more complex, size-agnostic\ncheck that would handle both \u0027int\u0027 and \u0027long\u0027. Since the signal number\ncomes from the operating system, an explicit range check is unnecessary.\n\nCheckpatch-ignore: COMMIT_LOG_LONG_LINE\n\nBuild error on FreeBSD:\n\n../src/server/server.c:616:39: error: result of comparison of constant 9223372036854775807 with expression of type \u0027int\u0027 is always true [-Werror,-Wtautological-constant-out-of-range-compare]\n  616 |                 assert(sig \u003e\u003d SIG_ATOMIC_MIN \u0026\u0026 sig \u003c\u003d SIG_ATOMIC_MAX);\n      |                                                 ~~~ ^  ~~~~~~~~~~~~~~\n/usr/include/assert.h:55:21: note: expanded from macro \u0027assert\u0027\n   55 | #define assert(e)       ((e) ? (void)0 : __assert(__func__, __FILE__, \\\n      |                           ^\n../src/server/server.c:616:14: error: result of comparison of constant -9223372036854775808 with expression of type \u0027int\u0027 is always true [-Werror,-Wtautological-constant-out-of-range-compare]\n  616 |                 assert(sig \u003e\u003d SIG_ATOMIC_MIN \u0026\u0026 sig \u003c\u003d SIG_ATOMIC_MAX);\n      |                        ~~~ ^  ~~~~~~~~~~~~~~\n/usr/include/assert.h:55:21: note: expanded from macro \u0027assert\u0027\n   55 | #define assert(e)       ((e) ? (void)0 : __assert(__func__, __FILE__, \\\n\nChange-Id: I6cf9242ab8206184bff9390ef0245843261656bd\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"e4c49d86052dfc241ec60bbd3b7e190307891722":{"kind":"REWORK","_number":2,"created":"2026-03-08 10:25:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/77/9477/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/77/9477/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/77/9477/2 \u0026\u0026 git checkout -b change-9477 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/77/9477/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/77/9477/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/77/9477/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/77/9477/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/77/9477/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"22e1e1b33e844c343eb3f24d24f630e2471d2b27","subject":"target/smp: reply to unknown packets in gdb_read_smp_packet"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-02-26 09:14:34.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-03-08 10:25:35.000000000","tz":0},"subject":"server/server: Fix build on FreeBSD","message":"server/server: Fix build on FreeBSD\n\nOn FreeBSD, sig_atomic_t is of type \u0027long\u0027 rather than \u0027int\u0027. Remove\nthe assert() instead of replacing it with a more complex, size-agnostic\ncheck that would handle both \u0027int\u0027 and \u0027long\u0027. Since the signal number\ncomes from the operating system, an explicit range check is unnecessary.\n\nCheckpatch-ignore: COMMIT_LOG_LONG_LINE\n\nBuild error on FreeBSD:\n\n../src/server/server.c:616:39: error: result of comparison of constant 9223372036854775807 with expression of type \u0027int\u0027 is always true [-Werror,-Wtautological-constant-out-of-range-compare]\n  616 |                 assert(sig \u003e\u003d SIG_ATOMIC_MIN \u0026\u0026 sig \u003c\u003d SIG_ATOMIC_MAX);\n      |                                                 ~~~ ^  ~~~~~~~~~~~~~~\n/usr/include/assert.h:55:21: note: expanded from macro \u0027assert\u0027\n   55 | #define assert(e)       ((e) ? (void)0 : __assert(__func__, __FILE__, \\\n      |                           ^\n../src/server/server.c:616:14: error: result of comparison of constant -9223372036854775808 with expression of type \u0027int\u0027 is always true [-Werror,-Wtautological-constant-out-of-range-compare]\n  616 |                 assert(sig \u003e\u003d SIG_ATOMIC_MIN \u0026\u0026 sig \u003c\u003d SIG_ATOMIC_MAX);\n      |                        ~~~ ^  ~~~~~~~~~~~~~~\n/usr/include/assert.h:55:21: note: expanded from macro \u0027assert\u0027\n   55 | #define assert(e)       ((e) ? (void)0 : __assert(__func__, __FILE__, \\\n\nChange-Id: I6cf9242ab8206184bff9390ef0245843261656bd\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9477\nReviewed-by: Anatoly P \u003ckupokupokupopo@gmail.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}