)]}'
{"id":"openocd~master~I9c7a5cc1085e15fed0f3f974ec943abad44e68a0","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2026-04-06 16:48:22.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-03-29 11:12:45.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I9c7a5cc1085e15fed0f3f974ec943abad44e68a0","subject":"Fix build issue on MSYS2 and Cygwin","status":"MERGED","created":"2026-02-26 16:08:54.000000000","updated":"2026-04-06 16:48:22.000000000","submitted":"2026-04-06 16:48:22.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9478","meta_rev_id":"5abc333754aba7f36206c56efe1ceb90c4fcd0b4","_number":9478,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-04-06 16:48:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-04-06 16:48:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-26 16:45:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-02-26 16:51:21.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2026-02-26 22:06:28.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-04-06 16:48:15.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"ba9f83a695542129dd8734ce5f7d28d0f89d4a42","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-02-26 16:08:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"779915aea50f392a9058d27e206e05c51d429ead","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-02-26 16:51:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bb1cf20956cbce3ece7ccd0d3a70d39095468014","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-02-26 22:06:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21886/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22782/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9d2ebc8e26913eea46067c89bdd5a9482e99bbb0","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-03-07 13:23:35.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2083f961c37b83f25a94a51545336eedcb7d6f4c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-03-09 16:09:09.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"6fc7b4271a6a0b0cd0591364003c225e12fa41e1","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-09 16:48:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21963/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22859/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"2e4602ecb5f7cea04915ddae4dbac00fb939ab50","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-28 17:11:11.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"0eb048effa2d104c45ff6f72949aacf71fffed9f","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-03-28 19:17:16.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ee61af356967db0d3b4092a80b1f9a17095f9a19","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-29 11:12:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4488f14f2be08b3ea08ce09dc2e4a66babee5a6a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:48:15.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5abc333754aba7f36206c56efe1ceb90c4fcd0b4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:48:22.000000000","message":"Change has been successfully cherry-picked as 232cd0b0f1dfe08177ea2d584913433d23fdd9cf","accounts_in_message":[],"_revision_number":3}],"current_revision":"232cd0b0f1dfe08177ea2d584913433d23fdd9cf","revisions":{"b03ea6b3da36951ff31b7b9378b81d7044b85436":{"kind":"REWORK","_number":1,"created":"2026-02-26 16:08:54.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/78/9478/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/9478/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/1 \u0026\u0026 git checkout -b change-9478 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/9478/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7c62d1b59f52a94a361275dee305a50c89e2a27c","subject":"server/server: Fix build on FreeBSD"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-02-26 13:56:57.000000000","tz":-480},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-02-26 16:06:52.000000000","tz":60},"subject":"Fix build issue on MSYS2 and Cygwin","message":"Fix build issue on MSYS2 and Cygwin\n\nThe is* macros on MSYS2 (native) and Cygwin are implemented as table\nlookups and expect values representable as \u0027unsigned char\u0027. Passing a\nsigned char can lead to negative array indices and compile-time\nerrors (-Werror\u003dchar-subscripts).\n\nAdd explicit casts to \u0027unsigned char\u0027 to all affected is* calls, as\nrecommended by the ISALPHA(3) manual page.\n\nExample error message on Cygwin:\n\n../src/helper/log.c: In function ‘find_nonprint_char’:\n../src/helper/log.c:525:33: error: array subscript has type ‘char’ [-Werror\u003dchar-subscripts]\n  525 |                 if (!isprint(buf[i]))\n\nChange-Id: I9c7a5cc1085e15fed0f3f974ec943abad44e68a0\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"232cd0b0f1dfe08177ea2d584913433d23fdd9cf":{"kind":"REWORK","_number":3,"created":"2026-04-06 16:48:22.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/78/9478/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/9478/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/3 \u0026\u0026 git checkout -b change-9478 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/9478/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a22e4331e7c9a7377e63dcd3de151e82f9b5ddbf","subject":"configure: Rework HAVE_CAPSTONE #define"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-02-26 13:56:57.000000000","tz":-480},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-04-06 16:48:22.000000000","tz":0},"subject":"Fix build issue on MSYS2 and Cygwin","message":"Fix build issue on MSYS2 and Cygwin\n\nThe is* macros on MSYS2 (native) and Cygwin are implemented as table\nlookups and expect values representable as \u0027unsigned char\u0027. Passing a\nsigned char can lead to negative array indices and compile-time\nerrors (-Werror\u003dchar-subscripts).\n\nAdd explicit casts to \u0027unsigned char\u0027 to all affected is* calls, as\nrecommended by the ISALPHA(3) manual page.\n\nExample error message on Cygwin:\n\n../src/helper/log.c: In function ‘find_nonprint_char’:\n../src/helper/log.c:525:33: error: array subscript has type ‘char’ [-Werror\u003dchar-subscripts]\n  525 |                 if (!isprint(buf[i]))\n\nChange-Id: I9c7a5cc1085e15fed0f3f974ec943abad44e68a0\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9478\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"3d9ebf7d922b6c8aef76298df793106e904f32a4":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-03-09 16:09:09.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/78/9478/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/9478/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/2 \u0026\u0026 git checkout -b change-9478 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/9478/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/9478/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e4c49d86052dfc241ec60bbd3b7e190307891722","subject":"server/server: Fix build on FreeBSD"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-02-26 13:56:57.000000000","tz":-480},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-03-08 11:14:13.000000000","tz":60},"subject":"Fix build issue on MSYS2 and Cygwin","message":"Fix build issue on MSYS2 and Cygwin\n\nThe is* macros on MSYS2 (native) and Cygwin are implemented as table\nlookups and expect values representable as \u0027unsigned char\u0027. Passing a\nsigned char can lead to negative array indices and compile-time\nerrors (-Werror\u003dchar-subscripts).\n\nAdd explicit casts to \u0027unsigned char\u0027 to all affected is* calls, as\nrecommended by the ISALPHA(3) manual page.\n\nExample error message on Cygwin:\n\n../src/helper/log.c: In function ‘find_nonprint_char’:\n../src/helper/log.c:525:33: error: array subscript has type ‘char’ [-Werror\u003dchar-subscripts]\n  525 |                 if (!isprint(buf[i]))\n\nChange-Id: I9c7a5cc1085e15fed0f3f974ec943abad44e68a0\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}