)]}'
{"id":"openocd~master~I18d772facba6426ab627fb45a6d50bfc19ec9c05","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2026-04-06 16:49:47.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-03-28 17:16:13.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"I18d772facba6426ab627fb45a6d50bfc19ec9c05","subject":"helper/log: Fix build issue on MSYS2 and Cygwin","status":"MERGED","created":"2026-02-26 16:08:54.000000000","updated":"2026-04-06 16:49:47.000000000","submitted":"2026-04-06 16:49:47.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9479","meta_rev_id":"e7307d9a50ee261a33d652b59e02b7882a3f51ee","_number":9479,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-04-06 16:49:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-04-06 16:49:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-02-26 17:14:45.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-02-26 22:25:41.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-07 13:23:56.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"807639f8a49ff3336098c3240b4eb3e9a65c8bb0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-02-26 16:08:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6a4b3c380104e72a0e2acd638a0f769cb95919f5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-02-26 22:25:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21887/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22783/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"eddea6ccbe3adb7cf8efabec023a90ef33d39c3d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-03-09 16:09:09.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"fea15c4e3f772977ddbd570963d91eacec268336","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-09 16:31:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21962/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22858/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e1c84d901fd1e3d241fbb3d81f2de95c4b4dd745","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-28 17:16:13.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3a23ba992486d5d800dbe26d38188dbff9b2522f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:49:41.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e7307d9a50ee261a33d652b59e02b7882a3f51ee","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:49:47.000000000","message":"Change has been successfully cherry-picked as b80f554fd982b65bd3b45bb151655abe634e938b","accounts_in_message":[],"_revision_number":3}],"current_revision":"b80f554fd982b65bd3b45bb151655abe634e938b","revisions":{"b80f554fd982b65bd3b45bb151655abe634e938b":{"kind":"REWORK","_number":3,"created":"2026-04-06 16:49:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/79/9479/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/9479/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/3 \u0026\u0026 git checkout -b change-9479 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/9479/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d83e9546e1f5050a7079eeca0a18d4259cd4949","subject":"flash/nor/fm4: Fix build on MSYS2 with Clang"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-02-26 14:48:43.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-04-06 16:49:47.000000000","tz":0},"subject":"helper/log: Fix build issue on MSYS2 and Cygwin","message":"helper/log: Fix build issue on MSYS2 and Cygwin\n\nOn MSYS2 (native) and Cygwin, the mallinfo struct uses \u0027size_t\u0027 instead\nof \u0027int\u0027, which leads to a compile-time error with the current code.\n\nUpdate the preprocessor logic so that Cygwin and MSYS2 builds use\nthe \u0027size_t\u0027 format specifier.\n\nCheckpatch-ignore: COMMIT_LOG_LONG_LINE\n\nBuild error on MSYS2:\n\n../src/helper/log.c: In function \u0027get_free_memory_space\u0027:\n../src/helper/log.c:78:45: error: format \u0027%d\u0027 expects argument of type \u0027int\u0027, but argument 4 has type \u0027size_t\u0027 {aka \u0027long unsigned int\u0027} [-Werror\u003dformat\u003d]\n   78 |                 snprintf(s, MEM_STR_LEN, \" %d\", info.fordblks);\n      |                                            ~^   ~~~~~~~~~~~~~\n      |                                             |       |\n      |                                             int     size_t {aka long unsigned int}\n      |                                            %ld\n\nChange-Id: I18d772facba6426ab627fb45a6d50bfc19ec9c05\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9479\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"08cd6cbec19073c79415de51d8675325d912b888":{"kind":"REWORK","_number":2,"created":"2026-03-09 16:09:09.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/79/9479/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/9479/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/2 \u0026\u0026 git checkout -b change-9479 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/9479/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d9ebf7d922b6c8aef76298df793106e904f32a4","subject":"Fix build issue on MSYS2 and Cygwin"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-02-26 14:48:43.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-03-09 15:43:13.000000000","tz":60},"subject":"helper/log: Fix build issue on MSYS2 and Cygwin","message":"helper/log: Fix build issue on MSYS2 and Cygwin\n\nOn MSYS2 (native) and Cygwin, the mallinfo struct uses \u0027size_t\u0027 instead\nof \u0027int\u0027, which leads to a compile-time error with the current code.\n\nUpdate the preprocessor logic so that Cygwin and MSYS2 builds use\nthe \u0027size_t\u0027 format specifier.\n\nCheckpatch-ignore: COMMIT_LOG_LONG_LINE\n\nBuild error on MSYS2:\n\n../src/helper/log.c: In function \u0027get_free_memory_space\u0027:\n../src/helper/log.c:78:45: error: format \u0027%d\u0027 expects argument of type \u0027int\u0027, but argument 4 has type \u0027size_t\u0027 {aka \u0027long unsigned int\u0027} [-Werror\u003dformat\u003d]\n   78 |                 snprintf(s, MEM_STR_LEN, \" %d\", info.fordblks);\n      |                                            ~^   ~~~~~~~~~~~~~\n      |                                             |       |\n      |                                             int     size_t {aka long unsigned int}\n      |                                            %ld\n\nChange-Id: I18d772facba6426ab627fb45a6d50bfc19ec9c05\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"240ad80f3e80a92eb78a72f40271669b721533bd":{"kind":"REWORK","_number":1,"created":"2026-02-26 16:08:54.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/79/9479/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/9479/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/1 \u0026\u0026 git checkout -b change-9479 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/9479/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/9479/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b03ea6b3da36951ff31b7b9378b81d7044b85436","subject":"Fix build issue on MSYS2 and Cygwin"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-02-26 14:48:43.000000000","tz":60},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-02-26 16:07:33.000000000","tz":60},"subject":"helper/log: Fix build issue on MSYS2 and Cygwin","message":"helper/log: Fix build issue on MSYS2 and Cygwin\n\nOn MSYS2 (native) and Cygwin, the mallinfo struct uses \u0027size_t\u0027 instead\nof \u0027int\u0027, which leads to a compile-time error with the current code.\n\nUpdate the preprocessor logic so that Cygwin and MSYS2 builds use\nthe \u0027size_t\u0027 format specifier.\n\nCheckpatch-ignore: COMMIT_LOG_LONG_LINE\n\nBuild error on Cygwin:\n\n../src/helper/log.c: In function ‘log_puts’:\n../src/helper/log.c:115:45: error: format ‘%d’ expects argument of type ‘int’, but argument 9 has type ‘size_t’ {aka ‘long unsigned int’} [-Werror\u003dformat\u003d]\n  115 |                         fprintf(log_output, \"%s%u %\" PRId64 \" %s:%d %s()\"\n      |                                             ^~~~~~~~\n......\n  122 |                                         info.fordblks,\n      |                                         ~~~~~~~~~~~~~\n      |                                             |\n      |                                             size_t {aka long unsigned int}\n\nChange-Id: I18d772facba6426ab627fb45a6d50bfc19ec9c05\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}