)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5a0bae3f495789113be0457e7ede523aed925d61","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kulyatskaya Alexandra \u003ca.kulyatskaya@syntacore.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-04-17 16:02:47 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[src/target] Redesign bp/wp interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Redesign breakpoint command interface"},{"line_number":10,"context_line":"- Add support for named arguments (-hw, -address, -length, -asid)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"c8ff1af9_fa91ebbf","line":7,"updated":"2026-07-04 23:21:23.000000000","message":"Please change the title as\n`target: breakpoint: change syntax to bp command`\nor something similar","commit_id":"f25c6ccbbfb5ff74caccc34c7ae47a0cfaa3fc35"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"},"change_message_id":"05f2895287cc5a442d2d8199f9808c209adbc893","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"268f5d07_bf98f503","updated":"2026-04-17 11:33:32.000000000","message":"@Antonio, could you please check?","commit_id":"7302374a8501403fe4b58b042d8487bd6704d16d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f4108d780a8797fda5e319854977f6eb18a08156","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2f8756a7_4cd0935f","updated":"2026-07-04 23:19:49.000000000","message":"This change does not manage the backward compatibility of the command `bp`.\nEvery time we change a command syntax we should accept the old syntax for some time, printing a warning for deprecated syntax.\nWe usually put some Tcl `proc` to handle the deprecation, but here I think that the only solution to handle the deprecation is by coding it in the `bp` command itself.","commit_id":"f25c6ccbbfb5ff74caccc34c7ae47a0cfaa3fc35"},{"author":{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"},"change_message_id":"8d0d77cb0fd5bf254bc2bfe1d2e5f2a02b3f0e3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ec51a422_7348ff02","updated":"2026-07-02 08:49:06.000000000","message":"gentle ping","commit_id":"f25c6ccbbfb5ff74caccc34c7ae47a0cfaa3fc35"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"164c965f2d186f0beba2466e40524e7eb78c2b7a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2e1dff36_685b0494","in_reply_to":"2f8756a7_4cd0935f","updated":"2026-07-20 14:05:33.000000000","message":"I\u0027d like to clarify:\nThe case of `bp \u003caddress\u003e \u003clength\u003e` is supported (see the `if (!n-\u003ename) {` handling), as well as `bp \u003caddress\u003e \u003clength\u003e hw`.\nThe case of `bp \u003caddress\u003e \u003casid\u003e \u003clength\u003e ...` is broken, passing `-asid` is required.\nAlso the support `hw_ctx` is dropped.\n\nCertainly, the compatibility can be improved.","commit_id":"f25c6ccbbfb5ff74caccc34c7ae47a0cfaa3fc35"}],"src/target/target.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f4108d780a8797fda5e319854977f6eb18a08156","unresolved":true,"context_lines":[{"line_number":1503,"context_line":"\tif (!type-\u003echeck_reset)"},{"line_number":1504,"context_line":"\t\ttype-\u003echeck_reset \u003d default_check_reset;"},{"line_number":1505,"context_line":""},{"line_number":1506,"context_line":"\tif (!type-\u003eset_default_breakpoint_params)"},{"line_number":1507,"context_line":"\t\ttype-\u003eset_default_breakpoint_params \u003d set_default_breakpoint_params;"},{"line_number":1508,"context_line":""},{"line_number":1509,"context_line":"\tassert(type-\u003einit_target);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"72312936_cb2ec4aa","line":1506,"updated":"2026-07-04 23:19:49.000000000","message":"No, please, don\u0027t overwrite `target_type`. I\u0027m going to drop this function in order to make `target-\u003etype` const!\nI prefer that in the caller you use something like:\n```\n// set default bp values\ntarget_addr_t addr \u003d 0; // invalid\nint length \u003d 0; // invalid\nint hw \u003d BKPT_SOFT;\nuint32_t asid;\nbool has_asid \u003d false;\n\n// let target overwrite the default\nif (type-\u003edefault_breakpoint_params)\n\ttype-\u003edefault_breakpoint_params(target, \u0026length, \u0026hw);\n\n// parse bp command line\n...\n```","commit_id":"f25c6ccbbfb5ff74caccc34c7ae47a0cfaa3fc35"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f4108d780a8797fda5e319854977f6eb18a08156","unresolved":true,"context_lines":[{"line_number":3878,"context_line":"\treturn ERROR_OK;"},{"line_number":3879,"context_line":"}"},{"line_number":3880,"context_line":""},{"line_number":3881,"context_line":"COMMAND_HELPER(set_default_breakpoint_params,"},{"line_number":3882,"context_line":"\t\tconst struct target *target,"},{"line_number":3883,"context_line":"\t\tstruct set_bp_opts bp_params[static BP_N_OPTS])"},{"line_number":3884,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"6a720b77_018d7112","line":3881,"updated":"2026-07-04 23:19:49.000000000","message":"I think it doesn\u0027t need to be `COMMAND_HELPER`","commit_id":"f25c6ccbbfb5ff74caccc34c7ae47a0cfaa3fc35"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f4108d780a8797fda5e319854977f6eb18a08156","unresolved":true,"context_lines":[{"line_number":4020,"context_line":"\t\t}"},{"line_number":4021,"context_line":""},{"line_number":4022,"context_line":"\t\tswitch (n-\u003evalue) {"},{"line_number":4023,"context_line":"\t\tcase BP_ADDRESS:"},{"line_number":4024,"context_line":"\t\t\tCOMMAND_PARSE_ADDRESS(CMD_ARGV[index++],"},{"line_number":4025,"context_line":"\t\t\t\t\tbp_params[BP_ADDRESS].addr);"},{"line_number":4026,"context_line":"\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"c0e31532_7671ac86","line":4023,"updated":"2026-07-04 23:19:49.000000000","message":"I prefer the command does not require the prefix `-addr`, as passing an address is the most common option. E.g. `bp 0x123456`.\nWhat about dropping this `case` and move the `COMMAND_PARSE_ADDRESS` in the `default` case?\nIf you really think that `-addr` still needs to be present in some use case, what about making it optional by duplicating the `COMMAND_PARSE_ADDRESS` here and in the `default` case?","commit_id":"f25c6ccbbfb5ff74caccc34c7ae47a0cfaa3fc35"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"164c965f2d186f0beba2466e40524e7eb78c2b7a","unresolved":true,"context_lines":[{"line_number":4020,"context_line":"\t\t}"},{"line_number":4021,"context_line":""},{"line_number":4022,"context_line":"\t\tswitch (n-\u003evalue) {"},{"line_number":4023,"context_line":"\t\tcase BP_ADDRESS:"},{"line_number":4024,"context_line":"\t\t\tCOMMAND_PARSE_ADDRESS(CMD_ARGV[index++],"},{"line_number":4025,"context_line":"\t\t\t\t\tbp_params[BP_ADDRESS].addr);"},{"line_number":4026,"context_line":"\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"ea11f232_5223ac81","line":4023,"in_reply_to":"c0e31532_7671ac86","updated":"2026-07-20 14:05:33.000000000","message":"Please take a closer look. `-addr` is not required, `bp \u003caddress\u003e \u003clength\u003e` is the same as `bp -addr \u003caddress\u003e -length \u003clength\u003e`, `bp -length \u003clength\u003e -addr \u003caddress\u003e` and `bp -length \u003clength\u003e \u003caddress\u003e`.","commit_id":"f25c6ccbbfb5ff74caccc34c7ae47a0cfaa3fc35"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f4108d780a8797fda5e319854977f6eb18a08156","unresolved":true,"context_lines":[{"line_number":4036,"context_line":"\t\t\tbp_params[BP_HW].hw \u003d BKPT_HARD;"},{"line_number":4037,"context_line":"\t\t\tbreak;"},{"line_number":4038,"context_line":"\t\tdefault:"},{"line_number":4039,"context_line":"\t\t\tassert(false);"},{"line_number":4040,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":4041,"context_line":"\t\t}"},{"line_number":4042,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"02ec766a_7dc25569","line":4039,"updated":"2026-07-04 23:19:49.000000000","message":"No, never ever `assert()` on what the user types in a command!\nThis error must return `ERROR_COMMAND_SYNTAX_ERROR`","commit_id":"f25c6ccbbfb5ff74caccc34c7ae47a0cfaa3fc35"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"164c965f2d186f0beba2466e40524e7eb78c2b7a","unresolved":true,"context_lines":[{"line_number":4036,"context_line":"\t\t\tbp_params[BP_HW].hw \u003d BKPT_HARD;"},{"line_number":4037,"context_line":"\t\t\tbreak;"},{"line_number":4038,"context_line":"\t\tdefault:"},{"line_number":4039,"context_line":"\t\t\tassert(false);"},{"line_number":4040,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":4041,"context_line":"\t\t}"},{"line_number":4042,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"f9dd88fe_0a72d2d2","line":4039,"in_reply_to":"02ec766a_7dc25569","updated":"2026-07-20 14:05:33.000000000","message":"Please take a closer look. This is not an assertion on user input. Please take a look at the `if (!n-\u003ename)` case.\nIf after the call to `nvp_name2value()` `n-\u003ename` is not `NULL`, `n-\u003evalue` should be one of the values above and the `default` clause should not be reachable.","commit_id":"f25c6ccbbfb5ff74caccc34c7ae47a0cfaa3fc35"}]}