)]}'
{"id":"openocd~master~I2947b46e714c365021a945705f71d099168d30f4","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002476":{"account":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"last_update":"2026-04-06 16:22:07.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2947b46e714c365021a945705f71d099168d30f4","subject":"flash/nand/core: remove redundant NULL check","status":"MERGED","created":"2026-03-09 22:10:38.000000000","updated":"2026-04-06 16:22:07.000000000","submitted":"2026-04-06 16:22:07.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9496","meta_rev_id":"01a1e2d72667e5c9651a87a78972f12310245a21","_number":9496,"owner":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-04-06 16:22:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-04-06 16:22:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-09 22:16:39.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-09 22:48:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-10 12:40:07.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"70c703ca95733cd777d3487540093b6435584164","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"real_author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"date":"2026-03-09 22:10:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c72fe730cdb36c06182961d304cf1dff007e6de7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-09 22:48:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21966/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22862/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e41e766859bc0d68c8d50db59d326a567611dc3e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-10 12:40:07.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d4c1d526fabdf168fc3d55471ef498af5694092d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:22:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"01a1e2d72667e5c9651a87a78972f12310245a21","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:22:07.000000000","message":"Change has been successfully cherry-picked as 4e23bf155f8e132f90720dfdcca77835934efddb","accounts_in_message":[],"_revision_number":2}],"current_revision":"4e23bf155f8e132f90720dfdcca77835934efddb","revisions":{"6f0e4b85db48a3e910477a294d175dcca306637d":{"kind":"REWORK","_number":1,"created":"2026-03-09 22:10:38.000000000","uploader":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"ref":"refs/changes/96/9496/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/96/9496/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/96/9496/1 \u0026\u0026 git checkout -b change-9496 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/96/9496/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/96/9496/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/96/9496/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/96/9496/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/96/9496/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e4c49d86052dfc241ec60bbd3b7e190307891722","subject":"server/server: Fix build on FreeBSD"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-02-24 20:32:02.000000000","tz":0},"committer":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-09 21:57:30.000000000","tz":0},"subject":"flash/nand/core: remove redundant NULL check","message":"flash/nand/core: remove redundant NULL check\n\nThe value p can never be NULL here.\nFound by cppcheck.\n\nChange-Id: I2947b46e714c365021a945705f71d099168d30f4\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\n"}},"4e23bf155f8e132f90720dfdcca77835934efddb":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-04-06 16:22:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/96/9496/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/96/9496/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/96/9496/2 \u0026\u0026 git checkout -b change-9496 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/96/9496/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/96/9496/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/96/9496/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/96/9496/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/96/9496/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e4c49d86052dfc241ec60bbd3b7e190307891722","subject":"server/server: Fix build on FreeBSD"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-02-24 20:32:02.000000000","tz":0},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-04-06 16:22:07.000000000","tz":0},"subject":"flash/nand/core: remove redundant NULL check","message":"flash/nand/core: remove redundant NULL check\n\nThe value p can never be NULL here.\nFound by cppcheck.\n\nChange-Id: I2947b46e714c365021a945705f71d099168d30f4\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9496\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}