)]}'
{"id":"openocd~master~Iec61a98eecd6657ff6ba1dcad6fff76052c917e3","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-04-06 16:22:24.000000000","reason":"removed on reply"},"1002476":{"account":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"last_update":"2026-04-06 16:22:28.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iec61a98eecd6657ff6ba1dcad6fff76052c917e3","subject":"flash/nor/str7x: fix undefined behaviour","status":"MERGED","created":"2026-03-09 22:10:38.000000000","updated":"2026-04-06 16:22:28.000000000","submitted":"2026-04-06 16:22:28.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9497","meta_rev_id":"a20cb8e6f963a905d41e8466870b765ed19a6484","_number":9497,"owner":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-04-06 16:22:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-04-06 16:22:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-09 22:32:30.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-09 23:06:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-10 12:42:12.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2026-03-10 14:57:38.000000000","updated_by":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"reviewer":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"state":"CC"}],"messages":[{"id":"3e62d5338ba67b259c592a5e8bcb9317de520405","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"real_author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"date":"2026-03-09 22:10:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"46bb6105aecb63b1210770d16f408cbf00000649","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-09 23:06:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21967/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22863/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9c932d92616b80bd17960f5c83716bb678db4ca2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-10 12:42:12.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1f9d69a38626664577a6b6a2a53d608332427d58","author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"real_author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"date":"2026-03-10 14:57:38.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e059e0a55d4258f565483b093d142bb7bb0cf8b4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:22:24.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a20cb8e6f963a905d41e8466870b765ed19a6484","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:22:28.000000000","message":"Change has been successfully cherry-picked as 92dc88978ada47764c7c4b093702952c92bd7484","accounts_in_message":[],"_revision_number":2}],"current_revision":"92dc88978ada47764c7c4b093702952c92bd7484","revisions":{"92dc88978ada47764c7c4b093702952c92bd7484":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-04-06 16:22:28.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/97/9497/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/9497/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/9497/2 \u0026\u0026 git checkout -b change-9497 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/9497/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/9497/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/9497/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/9497/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/9497/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4e23bf155f8e132f90720dfdcca77835934efddb","subject":"flash/nand/core: remove redundant NULL check"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-09 21:48:16.000000000","tz":0},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-04-06 16:22:28.000000000","tz":0},"subject":"flash/nor/str7x: fix undefined behaviour","message":"flash/nor/str7x: fix undefined behaviour\n\nShifting 32 bit signed variables by 31 bits is undefined behaviour\n\nChange-Id: Iec61a98eecd6657ff6ba1dcad6fff76052c917e3\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9497\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"a074306a189b30c364b414b6d5f8ec7d74ad440a":{"kind":"REWORK","_number":1,"created":"2026-03-09 22:10:38.000000000","uploader":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"ref":"refs/changes/97/9497/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/97/9497/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/97/9497/1 \u0026\u0026 git checkout -b change-9497 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/97/9497/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/97/9497/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/97/9497/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/97/9497/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/97/9497/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6f0e4b85db48a3e910477a294d175dcca306637d","subject":"flash/nand/core: remove redundant NULL check"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-09 21:48:16.000000000","tz":0},"committer":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-09 21:57:37.000000000","tz":0},"subject":"flash/nor/str7x: fix undefined behaviour","message":"flash/nor/str7x: fix undefined behaviour\n\nShifting 32 bit signed variables by 31 bits is undefined behaviour\n\nChange-Id: Iec61a98eecd6657ff6ba1dcad6fff76052c917e3\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}