)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"b3b24e4158ce1fc3365b489d7615d497cbad3430","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"572d8de1_0acf3241","updated":"2026-03-10 12:53:15.000000000","message":"Good catch, thanks","commit_id":"24bfc3df5cc4cbe77a62d13803d81d88281429a0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1b12b8c5a51209c3828dcf76972dfb5799defb5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"720f0993_6f3a7b0c","updated":"2026-03-28 16:26:45.000000000","message":"Looks correct.\nThanks","commit_id":"24bfc3df5cc4cbe77a62d13803d81d88281429a0"}],"src/target/arm_simulator.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9aaceb2d84290780740402772b2aae19df52159d","unresolved":true,"context_lines":[{"line_number":44,"context_line":"\t\t\t*carry \u003d (rm \u003e\u003e (shift_amount - 1)) \u0026 1;"},{"line_number":45,"context_line":"\t\t} else if (shift_amount \u003d\u003d 32) {"},{"line_number":46,"context_line":"\t\t\treturn_value \u003d 0x0;"},{"line_number":47,"context_line":"\t\t\t*carry \u003d rm \u0026 0x80000000;"},{"line_number":48,"context_line":"\t\t} else if (shift_amount \u003e 32) {"},{"line_number":49,"context_line":"\t\t\treturn_value \u003d 0x0;"},{"line_number":50,"context_line":"\t\t\t*carry \u003d 0x0;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c9bf4b2e_9e49555f","line":47,"updated":"2026-03-10 12:37:16.000000000","message":"`*carry` is `uint8_t`!\nThe operation returns a 32 bits value, that gets truncated when assigned to uint8_t, resulting in always zero assignment! Maybe:\n`*carry \u003d (rm \u003e\u003e 31) \u0026 0x1;`\n?","commit_id":"53fccd7c02da2c8653167878b518db25c9c5e396"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"b3b24e4158ce1fc3365b489d7615d497cbad3430","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\t\t\t*carry \u003d (rm \u003e\u003e (shift_amount - 1)) \u0026 1;"},{"line_number":45,"context_line":"\t\t} else if (shift_amount \u003d\u003d 32) {"},{"line_number":46,"context_line":"\t\t\treturn_value \u003d 0x0;"},{"line_number":47,"context_line":"\t\t\t*carry \u003d rm \u0026 0x80000000;"},{"line_number":48,"context_line":"\t\t} else if (shift_amount \u003e 32) {"},{"line_number":49,"context_line":"\t\t\treturn_value \u003d 0x0;"},{"line_number":50,"context_line":"\t\t\t*carry \u003d 0x0;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2e836f2e_3b509430","line":47,"in_reply_to":"c9bf4b2e_9e49555f","updated":"2026-03-10 12:53:15.000000000","message":"Done","commit_id":"53fccd7c02da2c8653167878b518db25c9c5e396"}]}