)]}'
{"id":"openocd~master~I846619a522c747f9c3b11a814a1864d1d51cfe87","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-03-28 16:26:45.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002476":{"account":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"last_update":"2026-04-06 16:23:33.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I846619a522c747f9c3b11a814a1864d1d51cfe87","subject":"target/arm_simulator: fix undefined behaviour","status":"MERGED","created":"2026-03-09 22:10:38.000000000","updated":"2026-04-06 16:23:33.000000000","submitted":"2026-04-06 16:23:33.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9502","meta_rev_id":"3e66f896dbd7187e411aa26c4f5a5b73fb7dcd6e","_number":9502,"owner":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-04-06 16:23:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-04-06 16:23:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-09 22:53:06.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-10 00:03:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-10 12:37:16.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2026-03-10 12:53:15.000000000","updated_by":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"reviewer":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"state":"CC"},{"updated":"2026-03-28 16:26:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"f214d1b8ff0e8c39e52711f66f8da046390b4341","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"real_author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"date":"2026-03-09 22:10:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"72bbad99a09346838aa4c26eacfb24c8b78c14b0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-10 00:03:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21970/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22866/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"9aaceb2d84290780740402772b2aae19df52159d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-10 12:37:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cdd97b37baf43d17e589a8a0594168433192bdd0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"real_author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"date":"2026-03-10 12:52:06.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"b3b24e4158ce1fc3365b489d7615d497cbad3430","author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"real_author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"date":"2026-03-10 12:53:15.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"c0eba5b6262d7a9147d0be004de11b097424fdbf","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-10 13:34:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21974/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22870/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"1b12b8c5a51209c3828dcf76972dfb5799defb5d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-28 16:26:45.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5e110eed218772ed7085279c48e4f7f26e0350bf","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:23:29.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3e66f896dbd7187e411aa26c4f5a5b73fb7dcd6e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:23:33.000000000","message":"Change has been successfully cherry-picked as 231aa88ee5170f28c3a6f9c2bd3055ba7f242c99","accounts_in_message":[],"_revision_number":3}],"current_revision":"231aa88ee5170f28c3a6f9c2bd3055ba7f242c99","revisions":{"231aa88ee5170f28c3a6f9c2bd3055ba7f242c99":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2026-04-06 16:23:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/02/9502/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/02/9502/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/3 \u0026\u0026 git checkout -b change-9502 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/02/9502/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"49e75c74d5572d49f575603ceae2b65ef9b08a81","subject":"rtos/hwthread: move pointer deref after NULL check"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-09 21:24:32.000000000","tz":0},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-04-06 16:23:33.000000000","tz":0},"subject":"target/arm_simulator: fix undefined behaviour","message":"target/arm_simulator: fix undefined behaviour\n\nShifting 32 bit unsigned variables by 32 bits is undefined behaviour\n\nChange-Id: I846619a522c747f9c3b11a814a1864d1d51cfe87\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9502\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"24bfc3df5cc4cbe77a62d13803d81d88281429a0":{"kind":"REWORK","_number":2,"created":"2026-03-10 12:52:06.000000000","uploader":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"ref":"refs/changes/02/9502/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/02/9502/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/2 \u0026\u0026 git checkout -b change-9502 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/02/9502/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dc8f1599db9aad8c40d25fcd3a27f9ca4bf92164","subject":"rtos/hwthread: move pointer deref after NULL check"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-09 21:24:32.000000000","tz":0},"committer":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-10 12:45:45.000000000","tz":0},"subject":"target/arm_simulator: fix undefined behaviour","message":"target/arm_simulator: fix undefined behaviour\n\nShifting 32 bit unsigned variables by 32 bits is undefined behaviour\n\nChange-Id: I846619a522c747f9c3b11a814a1864d1d51cfe87\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\n"}},"53fccd7c02da2c8653167878b518db25c9c5e396":{"kind":"REWORK","_number":1,"created":"2026-03-09 22:10:38.000000000","uploader":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"ref":"refs/changes/02/9502/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/02/9502/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/1 \u0026\u0026 git checkout -b change-9502 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/02/9502/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/02/9502/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dc8f1599db9aad8c40d25fcd3a27f9ca4bf92164","subject":"rtos/hwthread: move pointer deref after NULL check"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-09 21:24:32.000000000","tz":0},"committer":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-09 21:58:03.000000000","tz":0},"subject":"target/arm_simulator: fix undefined behaviour","message":"target/arm_simulator: fix undefined behaviour\n\nShifting 32 bit unsigned variables by 32 bits is undefined behaviour\n\nChange-Id: I846619a522c747f9c3b11a814a1864d1d51cfe87\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}