)]}'
{"id":"openocd~master~Iff5cef0ffc78ec19bc7630bc2cc9bc4eea002e47","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002476":{"account":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"last_update":"2026-04-06 16:23:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iff5cef0ffc78ec19bc7630bc2cc9bc4eea002e47","subject":"target/semihosting_common: remove redundant NULL check","status":"MERGED","created":"2026-03-09 22:10:38.000000000","updated":"2026-04-06 16:23:52.000000000","submitted":"2026-04-06 16:23:52.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9503","meta_rev_id":"0623e209cf2d9fe4d1848694f04edcf4ef7865f1","_number":9503,"owner":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-04-06 16:23:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-04-06 16:23:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-09 23:11:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-10 00:32:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-28 16:27:48.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"63c7f19480e947c65b97d63991c4723187aeb8d4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"real_author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"date":"2026-03-09 22:10:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f97fdd302beb25451fb578b16b0e05b40d962699","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-10 00:32:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21972/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22868/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"7621090c4932e04ead9888504411e7a8646500d6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"real_author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"date":"2026-03-10 12:52:06.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"20a9d667602444136404945555504cf6fb9a5ec8","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-10 14:19:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21976/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22872/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"41d25b1e2a07d107c91be54a618686a4f9a74d18","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-28 16:27:48.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ffa3e3cbf9ee02c7518057ab98977371b30496b3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:23:41.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0623e209cf2d9fe4d1848694f04edcf4ef7865f1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:23:52.000000000","message":"Change has been successfully cherry-picked as b8cfd063683cec565aa137ca4b754182eacb72e9","accounts_in_message":[],"_revision_number":3}],"current_revision":"b8cfd063683cec565aa137ca4b754182eacb72e9","revisions":{"48c20b257a6a8f3c9c25733bde5139880a83a0db":{"kind":"REWORK","_number":1,"created":"2026-03-09 22:10:38.000000000","uploader":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"ref":"refs/changes/03/9503/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/9503/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/1 \u0026\u0026 git checkout -b change-9503 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/9503/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"53fccd7c02da2c8653167878b518db25c9c5e396","subject":"target/arm_simulator: fix undefined behaviour"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-02-24 20:49:50.000000000","tz":0},"committer":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-09 21:58:03.000000000","tz":0},"subject":"target/semihosting_common: remove redundant NULL check","message":"target/semihosting_common: remove redundant NULL check\n\nThe value semihosting can never be NULL here.\nFound by cppcheck.\n\nChange-Id: Iff5cef0ffc78ec19bc7630bc2cc9bc4eea002e47\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\n"}},"b8cfd063683cec565aa137ca4b754182eacb72e9":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2026-04-06 16:23:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/9503/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/9503/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/3 \u0026\u0026 git checkout -b change-9503 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/9503/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"231aa88ee5170f28c3a6f9c2bd3055ba7f242c99","subject":"target/arm_simulator: fix undefined behaviour"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-02-24 20:49:50.000000000","tz":0},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-04-06 16:23:52.000000000","tz":0},"subject":"target/semihosting_common: remove redundant NULL check","message":"target/semihosting_common: remove redundant NULL check\n\nThe value semihosting can never be NULL here.\nFound by cppcheck.\n\nChange-Id: Iff5cef0ffc78ec19bc7630bc2cc9bc4eea002e47\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9503\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"053e7c0bfa219974c4b5c9b87212a02cd4fb9f46":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-03-10 12:52:06.000000000","uploader":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"ref":"refs/changes/03/9503/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/9503/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/2 \u0026\u0026 git checkout -b change-9503 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/9503/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/9503/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"24bfc3df5cc4cbe77a62d13803d81d88281429a0","subject":"target/arm_simulator: fix undefined behaviour"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-02-24 20:49:50.000000000","tz":0},"committer":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-10 12:45:54.000000000","tz":0},"subject":"target/semihosting_common: remove redundant NULL check","message":"target/semihosting_common: remove redundant NULL check\n\nThe value semihosting can never be NULL here.\nFound by cppcheck.\n\nChange-Id: Iff5cef0ffc78ec19bc7630bc2cc9bc4eea002e47\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}