)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"11d1bb126da1ab86a299bd345086aab59cf9360f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f2af8c59_3ede30dd","updated":"2026-03-28 13:52:18.000000000","message":"To be rebased after merge of https://review.openocd.org/c/openocd/+/9540","commit_id":"ee7112e73c7ca8e14bccaaf205bc622b8a0be11b"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"941880a0a26e4bae9247f75cd2fa1689382e755f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"13810897_99e399d8","updated":"2026-05-05 20:21:21.000000000","message":"Looks good, just recommend a minor formatting improvement","commit_id":"7d594f570dd6bb0243340ace32cfeaa9baf8def0"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"aec1327684bbd683ddafefc5c748352aac12c1b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"89174e42_8160604a","updated":"2026-05-10 10:58:24.000000000","message":"Works as expected, tested on Cortex-M targets. Except for my comments below, +1 for the patch series.","commit_id":"5a899c3b538343f58ddf8b87c353c08cef25895b"}],"src/target/oocd_capstone.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"941880a0a26e4bae9247f75cd2fa1689382e755f","unresolved":true,"context_lines":[{"line_number":48,"context_line":"\tfor (uint16_t i \u003d 0; i \u003c insn-\u003esize; i++)"},{"line_number":49,"context_line":"\t\tsprintf(\u0026opcode[3 * i], \" %02\" PRIx8, insn-\u003ebytes[i]);"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"\tcommand_print(cmd, \"0x%08\" PRIx64 \"  %s\\t%s%s%s\","},{"line_number":52,"context_line":"\t\t\t\t  insn-\u003eaddress, opcode, insn-\u003emnemonic,"},{"line_number":53,"context_line":"\t\t\t\t  insn-\u003eop_str[0] ? \"\\t\" : \"\", insn-\u003eop_str);"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d46e2975_d14b5671","line":51,"range":{"start_line":51,"start_character":36,"end_line":51,"end_character":38},"updated":"2026-05-05 20:21:21.000000000","message":"In Thumb2 code 4 bytes opcodes shift mnemonic one more tab to right resulting in somewhat ugly format:\n```\n0x0a00084c   42 e8 00 31        strex   r1, r3, [r2]\n0x0a000850   00 29      cmp     r1, #0\n```\n\nIf we reduce this to one space (second one comes from opcode[0]), both 2 and 4 byte opcodes fit to the same tab pos:\n```\n0x0a00084c  42 e8 00 31 strex   r1, r3, [r2]\n0x0a000850  00 29       cmp     r1, #0\n```","commit_id":"7d594f570dd6bb0243340ace32cfeaa9baf8def0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"21b66bce475436c260ae74afa416342c40a1df6f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\tfor (uint16_t i \u003d 0; i \u003c insn-\u003esize; i++)"},{"line_number":49,"context_line":"\t\tsprintf(\u0026opcode[3 * i], \" %02\" PRIx8, insn-\u003ebytes[i]);"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"\tcommand_print(cmd, \"0x%08\" PRIx64 \"  %s\\t%s%s%s\","},{"line_number":52,"context_line":"\t\t\t\t  insn-\u003eaddress, opcode, insn-\u003emnemonic,"},{"line_number":53,"context_line":"\t\t\t\t  insn-\u003eop_str[0] ? \"\\t\" : \"\", insn-\u003eop_str);"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4a2afead_382d11e9","line":51,"range":{"start_line":51,"start_character":36,"end_line":51,"end_character":38},"in_reply_to":"d46e2975_d14b5671","updated":"2026-05-08 16:57:21.000000000","message":"Done","commit_id":"7d594f570dd6bb0243340ace32cfeaa9baf8def0"}],"src/target/target.c":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"aec1327684bbd683ddafefc5c748352aac12c1b5","unresolved":true,"context_lines":[{"line_number":5513,"context_line":"\t\tint retval \u003d target_insn_set(CMD, target, \u0026insn_set);"},{"line_number":5514,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":5515,"context_line":"\t\t\treturn retval;"},{"line_number":5516,"context_line":"\t\tcommand_print(CMD, \"instruction-set \\\"%s\\\"\", insn_set);"},{"line_number":5517,"context_line":"\t}"},{"line_number":5518,"context_line":""},{"line_number":5519,"context_line":"\treturn oocd_cs_disassemble(CMD, target, address, count, insn_set);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"35cdbd05_ad87b4de","line":5516,"updated":"2026-05-10 10:58:24.000000000","message":"\u003e \u003e pic64gx.e51 disassemble 0x0 \n\u003e instruction-set \"riscv64\"\n\u003e Unknown instruction-set \"riscv64\"\n\nI find this output a bit confusing. Maybe \"using default instruction set\" ... or something like that. Also, I\u0027m not sure if this should be a Tcl output or rather  debug / info message. Is this command intended to be machine-readable?\n\nGeneral: I think it should be \"instruction set\" instead of \"instruction-set\" (no hyphen).","commit_id":"5a899c3b538343f58ddf8b87c353c08cef25895b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"82a8710340952a3e77edceca76fe9a6ac399234f","unresolved":false,"context_lines":[{"line_number":5513,"context_line":"\t\tint retval \u003d target_insn_set(CMD, target, \u0026insn_set);"},{"line_number":5514,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":5515,"context_line":"\t\t\treturn retval;"},{"line_number":5516,"context_line":"\t\tcommand_print(CMD, \"instruction-set \\\"%s\\\"\", insn_set);"},{"line_number":5517,"context_line":"\t}"},{"line_number":5518,"context_line":""},{"line_number":5519,"context_line":"\treturn oocd_cs_disassemble(CMD, target, address, count, insn_set);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"976b9362_07c0d57f","line":5516,"in_reply_to":"19f98b34_7fb6f31e","updated":"2026-05-12 14:44:04.000000000","message":"Fixed.\nAlso changed some commit message in the series to address the `s/instruction-set/instruction set/`","commit_id":"5a899c3b538343f58ddf8b87c353c08cef25895b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"568e1d38723372100aa90588b87dee7471a6ff2d","unresolved":true,"context_lines":[{"line_number":5513,"context_line":"\t\tint retval \u003d target_insn_set(CMD, target, \u0026insn_set);"},{"line_number":5514,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":5515,"context_line":"\t\t\treturn retval;"},{"line_number":5516,"context_line":"\t\tcommand_print(CMD, \"instruction-set \\\"%s\\\"\", insn_set);"},{"line_number":5517,"context_line":"\t}"},{"line_number":5518,"context_line":""},{"line_number":5519,"context_line":"\treturn oocd_cs_disassemble(CMD, target, address, count, insn_set);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"19f98b34_7fb6f31e","line":5516,"in_reply_to":"35cdbd05_ad87b4de","updated":"2026-05-11 07:51:34.000000000","message":"Agree, this would be better handled as `LOG_DEBUG()`\nAnd also the following message\n\u003e Unknown instruction-set \"...\"\n\nshould be better `Unsupported ... by Capstone`\nAll with `s/instruction-set/instruction set/` in text and\n`s/instruction-set/instruction_set/`in the usage below","commit_id":"5a899c3b538343f58ddf8b87c353c08cef25895b"}]}