)]}'
{"id":"openocd~master~Ifd832e97794e5d9988629898f482829400bc2ae0","project":"openocd","branch":"master","hashtags":[],"change_id":"Ifd832e97794e5d9988629898f482829400bc2ae0","subject":"target: extend use of capstone disassembler","status":"NEW","created":"2026-03-17 10:35:18.000000000","updated":"2026-04-06 22:04:04.000000000","submit_type":"CHERRY_PICK","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a1094f0cb752752f9a03db6b83df5f916df3a8d1","_number":9507,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-04-06 19:56:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":1,"date":"2026-04-06 22:04:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-17 10:35:31.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-17 11:29:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"358f96b577e4d5d96d3b7e20283cb8319766bd10","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-17 10:35:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"22b73bb93d7bdfc3eb73fdcee09e3a57aa31dddc","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-17 11:29:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21986/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22882/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"11d1bb126da1ab86a299bd345086aab59cf9360f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-28 13:52:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"57bd6667b149b0850390f0422db6a3bca0df7d3d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 17:02:16.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"793efb97067b2559ff43280f8c28821e8842a9f6","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-04-06 19:56:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22059/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22955/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a1094f0cb752752f9a03db6b83df5f916df3a8d1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 22:04:04.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2}],"current_revision":"7d594f570dd6bb0243340ace32cfeaa9baf8def0","revisions":{"ee7112e73c7ca8e14bccaaf205bc622b8a0be11b":{"kind":"REWORK","_number":1,"created":"2026-03-17 10:35:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/9507/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/9507/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/9507/1 \u0026\u0026 git checkout -b change-9507 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/9507/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/9507/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/9507/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/9507/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/9507/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e4c49d86052dfc241ec60bbd3b7e190307891722","subject":"server/server: Fix build on FreeBSD"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-03-15 00:01:13.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-03-17 10:33:26.000000000","tz":60},"subject":"target: extend use of capstone disassembler","message":"target: extend use of capstone disassembler\n\nOpenOCD uses capstone library for the disassemble commands, but\nonly limited to aarch64 and arm, and using dedicated commands.\nThe code also has some issue in handling capstone return errors,\ndoes not provide the correct settings for Cortex-M, does not\nsupport endianness and does not handle the different modes of\naarch64.\n\nWhile support for MIPS is already present in Capstone v4.0 but\nnot in OpenOCD, the latest v5.0 have also support for RISC-V, and\nnext v6.0 already includes support for esp32 and arc.\n\nCreate a new generic command \u0027$target_name disassemble\u0027. It can\nuse the instruction-set of the current target, and is also allows\nthe disassemble of a specific instruction-set while using the\ncurrent target only for reading the instructions from memory; this\nis useful with a mem-ap target.\nIntroduce a callback target_type::insn_set() to let a target to\nfeedback the current instruction-set and endianness to the new\ncommand.\n\nChange-Id: Ifd832e97794e5d9988629898f482829400bc2ae0\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"7d594f570dd6bb0243340ace32cfeaa9baf8def0":{"kind":"REWORK","_number":2,"created":"2026-04-06 17:02:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/9507/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/9507/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/9507/2 \u0026\u0026 git checkout -b change-9507 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/9507/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/9507/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/9507/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/9507/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/9507/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b80f554fd982b65bd3b45bb151655abe634e938b","subject":"helper/log: Fix build issue on MSYS2 and Cygwin"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-03-15 00:01:13.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-04-06 17:00:11.000000000","tz":120},"subject":"target: extend use of capstone disassembler","message":"target: extend use of capstone disassembler\n\nOpenOCD uses capstone library for the disassemble commands, but\nonly limited to aarch64 and arm, and using dedicated commands.\nThe code also has some issue in handling capstone return errors,\ndoes not provide the correct settings for Cortex-M, does not\nsupport endianness and does not handle the different modes of\naarch64.\n\nWhile support for MIPS is already present in Capstone v4.0 but\nnot in OpenOCD, the latest v5.0 have also support for RISC-V, and\nnext v6.0 already includes support for esp32 and arc.\n\nCreate a new generic command \u0027$target_name disassemble\u0027. It can\nuse the instruction-set of the current target, and is also allows\nthe disassemble of a specific instruction-set while using the\ncurrent target only for reading the instructions from memory; this\nis useful with a mem-ap target.\nIntroduce a callback target_type::insn_set() to let a target to\nfeedback the current instruction-set and endianness to the new\ncommand.\n\nChange-Id: Ifd832e97794e5d9988629898f482829400bc2ae0\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}