)]}'
{"id":"openocd~master~I57a84f8cc2ef0bcc6def7e673bb52236d4725dda","project":"openocd","branch":"master","hashtags":[],"change_id":"I57a84f8cc2ef0bcc6def7e673bb52236d4725dda","subject":"OpenULINK firmware: fix build with sdcc versions \u003e\u003d 4.2.3","status":"NEW","created":"2026-03-13 01:21:10.000000000","updated":"2026-03-13 02:00:59.000000000","submit_type":"CHERRY_PICK","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d67123e0496af39569b71726b950c014626abf65","_number":9514,"owner":{"_account_id":1002500,"name":"Charles Mirabile","email":"cmirabil@redhat.com","username":"cmirabil"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-03-13 02:00:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-13 01:21:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-13 02:00:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"dcc0e322c31829aa952890f25f3c9fa175a8076b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002500,"name":"Charles Mirabile","email":"cmirabil@redhat.com","username":"cmirabil"},"real_author":{"_account_id":1002500,"name":"Charles Mirabile","email":"cmirabil@redhat.com","username":"cmirabil"},"date":"2026-03-13 01:21:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"89650e66837d20f038922573bc6f9698d28a0d18","author":{"_account_id":1002500,"name":"Charles Mirabile","email":"cmirabil@redhat.com","username":"cmirabil"},"real_author":{"_account_id":1002500,"name":"Charles Mirabile","email":"cmirabil@redhat.com","username":"cmirabil"},"date":"2026-03-13 01:44:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d67123e0496af39569b71726b950c014626abf65","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-13 02:00:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/21984/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22880/ : SUCCESS","accounts_in_message":[],"_revision_number":1}],"current_revision":"bf9b1dbb6556fbfdf46ce591465b9262cd235151","revisions":{"bf9b1dbb6556fbfdf46ce591465b9262cd235151":{"kind":"REWORK","_number":1,"created":"2026-03-13 01:21:10.000000000","uploader":{"_account_id":1002500,"name":"Charles Mirabile","email":"cmirabil@redhat.com","username":"cmirabil"},"ref":"refs/changes/14/9514/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/14/9514/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/14/9514/1 \u0026\u0026 git checkout -b change-9514 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/14/9514/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/14/9514/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/14/9514/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/14/9514/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/14/9514/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e4c49d86052dfc241ec60bbd3b7e190307891722","subject":"server/server: Fix build on FreeBSD"}],"author":{"name":"Charles Mirabile","email":"cmirabil@redhat.com","date":"2026-03-13 01:05:22.000000000","tz":-240},"committer":{"name":"Charles Mirabile","email":"cmirabil@redhat.com","date":"2026-03-13 01:18:35.000000000","tz":-240},"subject":"OpenULINK firmware: fix build with sdcc versions \u003e\u003d 4.2.3","message":"OpenULINK firmware: fix build with sdcc versions \u003e\u003d 4.2.3\n\nSince sdcc 4.2.3 the numeric parameter to `__interrupt` must be between\nparentheses.\n\nCheck patch does not recognize the interrupt keyword as a function\nattribute, it thinks that they are casts and gets confused, hence:\nCheckpatch-ignore: SPACING\n\nChange-Id: I57a84f8cc2ef0bcc6def7e673bb52236d4725dda\nSigned-off-by: Charles Mirabile \u003ccmirabil@redhat.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}