)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002508,"name":"fboyer-mchp","email":"frederic.boyer@microchip.com","username":"fboyer-mchp"},"change_message_id":"c727bc115a72dd3b7d412def345dd7e7d07cebf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ecf65f67_974bba42","updated":"2026-04-14 09:40:37.000000000","message":"Hi Leo, Dinesh,\nMay worth looking at this for our MPUs support.\nThanks a lot","commit_id":"bc33cc16c865db7d176f4311abedda13f38fbdd2"},{"author":{"_account_id":1002508,"name":"fboyer-mchp","email":"frederic.boyer@microchip.com","username":"fboyer-mchp"},"change_message_id":"51168ee42e9418b3b0b38e93ddc0faed745cf789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36ea4033_9003f76a","updated":"2026-04-10 08:53:27.000000000","message":"Hi Thomas,\nIt seems you are looking at new target support. \nMay I ask you to review mine please?","commit_id":"bc33cc16c865db7d176f4311abedda13f38fbdd2"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"46ad79164d971b0616e1a84afd6104fc996f6457","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f6af5c25_c89a686e","updated":"2026-04-15 09:00:23.000000000","message":"Name the file `sama7d65-curiosity.cfg` (`_` -\u003e `-`), please (see config style guide).","commit_id":"bc33cc16c865db7d176f4311abedda13f38fbdd2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"193009722d863e9dc1b51b7ce9eaa563657f309c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bd2d91f8_2eb947fa","in_reply_to":"02be86d5_8224c692","updated":"2026-04-18 08:06:41.000000000","message":"I was looking in my local branch for patches I\u0027m following, but not merged upstream.\nThe file `tcl/board/nxp/imx93-evk.cfg` is available here\nhttps://review.openocd.org/c/openocd/+/8353\nThe typos were already reported last November, but never fixed by the author","commit_id":"bc33cc16c865db7d176f4311abedda13f38fbdd2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"897fab28f83907b371e0117979e0753f33aa9b5c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"02be86d5_8224c692","in_reply_to":"14f706a6_9ad64f3d","updated":"2026-04-18 06:18:44.000000000","message":"Has Marc already highlighted, this board has an embedded on-board J-Link. This should be in the board file.\n\nBut the board also has two connectors for external debug probes.\nTo handle both internal and external probes, please check the implementation in\n`tcl/board/nxp/imx93-evk.cfg`\n```\n# Could specify external adpater by:\n# openocd -f interface/jlink.cfg -f board/nxp/imx8ulp-evk.cfg\n# otherwise use FTDI-based JTAG adapte by default.\n#\nif { [adapter name] eq \"undefined\" } {\n  # Use on-board FTDI-based adapter\n  echo \"Info : use FTDI adapter\"\n  source [find interface/ftdi/nxp/imx93-evk.cfg]\n}\n```\n\nI believe the same code structure could be beneficial here too!\n\nOoops, two typos in the comment I copy/paste! I will fix them there! Of course, don\u0027t copy the same typos ;-)","commit_id":"bc33cc16c865db7d176f4311abedda13f38fbdd2"},{"author":{"_account_id":1002508,"name":"fboyer-mchp","email":"frederic.boyer@microchip.com","username":"fboyer-mchp"},"change_message_id":"5bf60bc101b99a15e83fd6192a3569447ca5de4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc6f85f0_94d6417c","in_reply_to":"75481757_e34ad9f0","updated":"2026-04-22 10:13:48.000000000","message":"Done","commit_id":"bc33cc16c865db7d176f4311abedda13f38fbdd2"},{"author":{"_account_id":1002508,"name":"fboyer-mchp","email":"frederic.boyer@microchip.com","username":"fboyer-mchp"},"change_message_id":"40682dd36ae004282e31b58fe63720241b90d108","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75481757_e34ad9f0","in_reply_to":"bd2d91f8_2eb947fa","updated":"2026-04-22 10:13:05.000000000","message":"Thanks for the info.\nI\u0027ve improved this on a new version I will push","commit_id":"bc33cc16c865db7d176f4311abedda13f38fbdd2"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"97a98c01570652e74c5d478aa9d43a33221f3c7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"14f706a6_9ad64f3d","in_reply_to":"e78eb046_c632628e","updated":"2026-04-16 07:09:01.000000000","message":"Hi Frederic,\n\naccording to the user\u0027s guide the board has an onboard J-Link adapter which is enabled by default. Why it is not part of your board configuration?","commit_id":"bc33cc16c865db7d176f4311abedda13f38fbdd2"},{"author":{"_account_id":1002508,"name":"fboyer-mchp","email":"frederic.boyer@microchip.com","username":"fboyer-mchp"},"change_message_id":"52ab75b275a8aa9394822ad6037812dab3be82d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e78eb046_c632628e","in_reply_to":"f6af5c25_c89a686e","updated":"2026-04-15 11:28:15.000000000","message":"Hi Marc,\nIt should be good now.\nCould you approve it?","commit_id":"bc33cc16c865db7d176f4311abedda13f38fbdd2"},{"author":{"_account_id":1002508,"name":"fboyer-mchp","email":"frederic.boyer@microchip.com","username":"fboyer-mchp"},"change_message_id":"4bb219b35858f389d35aacbd0e0026e93f0b24cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cfb494a2_282c3839","updated":"2026-04-22 13:43:16.000000000","message":"Dear Reviewers,\nI\u0027ve applied all requested improvements.\nCan you please review/approve?","commit_id":"1626c1f12a1eb3e89ff453e13808e198cb49375a"},{"author":{"_account_id":1002508,"name":"fboyer-mchp","email":"frederic.boyer@microchip.com","username":"fboyer-mchp"},"change_message_id":"3df23032f416d89148c152a80ce6b68c176935de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f60e2560_ff20673a","in_reply_to":"adc97f83_2e978f37","updated":"2026-04-23 06:43:27.000000000","message":"Hi Mark,\nShould the target config explicitly set a default transport, or should it rely on the board config / command line? Based on earlier reviewer feedback, the board config handles it. The warning is expected when using the target config directly without a board config.","commit_id":"1626c1f12a1eb3e89ff453e13808e198cb49375a"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"a98f12f9b78aea63b243febb9ff0aa84f5e017e2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"adc97f83_2e978f37","in_reply_to":"cfb494a2_282c3839","updated":"2026-04-23 06:16:02.000000000","message":"Hi Frederic,\n\nI see the following output\n\n\u003e Warn : DEPRECATED: auto-selecting transport \"swd\". Use \u0027transport select swd\u0027 to suppress this message.\n\nThat\u0027s because you removed the entire `transport select` command in the target configuration instead of only the `catch` statement.\n\nAlso your commit message is not fixed, it still says\n\n\u003e Supports J-Link and CMSIS-DAP debug probes.","commit_id":"1626c1f12a1eb3e89ff453e13808e198cb49375a"},{"author":{"_account_id":1002508,"name":"fboyer-mchp","email":"frederic.boyer@microchip.com","username":"fboyer-mchp"},"change_message_id":"83ada52a5f9cbe8b67bb4a3305825206fea5551a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b887e0ce_4aa3288a","in_reply_to":"d1f6180f_5403c211","updated":"2026-04-23 14:20:41.000000000","message":"Got it, thanks !\nI\u0027m updating right now and will send new patch","commit_id":"1626c1f12a1eb3e89ff453e13808e198cb49375a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"74db0385e7f79ffb71a9f65ddb923698b4d736cf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d1f6180f_5403c211","in_reply_to":"f60e2560_ff20673a","updated":"2026-04-23 14:03:39.000000000","message":"Frederic,\nthe target file is allowed to set the transport only if it only supports one transport (e.g. JTAG only).\nFor targets that support multiple transports (e.g. SWD or JTAG), the proper place is to put it in the board file.\nIn this case the adapter is optional, so the transport should be added only in the if/then/else branch where the JLink is selected.\nIn case of an external adapter, it could be JTAG only or SWD only, so it\u0027s up to the user to select the transport in the command line.","commit_id":"1626c1f12a1eb3e89ff453e13808e198cb49375a"},{"author":{"_account_id":1002508,"name":"fboyer-mchp","email":"frederic.boyer@microchip.com","username":"fboyer-mchp"},"change_message_id":"812d4a715579e4c0b25eff5851f91501da824196","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"77064465_c71dfcbe","updated":"2026-04-24 15:16:28.000000000","message":"Dear Reviewers,\nLet me know if we are good with this one 😊","commit_id":"bde5b37ad40dc99d95c5383aed5a11413528a65b"}],"tcl/board/microchip/sama7g54-ek.cfg":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"97a98c01570652e74c5d478aa9d43a33221f3c7b","unresolved":true,"context_lines":[{"line_number":52,"context_line":"#           -f board/microchip/sama7g54-ek.cfg"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Default to JTAG -- silently ignored if already selected"},{"line_number":55,"context_line":"catch { transport select jtag }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Target configuration (supports both JTAG and SWD)"},{"line_number":58,"context_line":"source [find target/microchip/sama7g5.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"073fcdb8_635eabb1","line":55,"updated":"2026-04-16 07:09:01.000000000","message":"Remove this catch, if transport is already selected there is an error in your setup and should be fixed.","commit_id":"6e14553efb7cb0355a98a4338b090712c34c9e51"},{"author":{"_account_id":1002508,"name":"fboyer-mchp","email":"frederic.boyer@microchip.com","username":"fboyer-mchp"},"change_message_id":"97bbc81eb7ca183c244dfcb27dcdc858fc9c8cac","unresolved":true,"context_lines":[{"line_number":52,"context_line":"#           -f board/microchip/sama7g54-ek.cfg"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Default to JTAG -- silently ignored if already selected"},{"line_number":55,"context_line":"catch { transport select jtag }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Target configuration (supports both JTAG and SWD)"},{"line_number":58,"context_line":"source [find target/microchip/sama7g5.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"99539fed_176888a0","line":55,"in_reply_to":"073fcdb8_635eabb1","updated":"2026-04-22 08:57:19.000000000","message":"Done","commit_id":"6e14553efb7cb0355a98a4338b090712c34c9e51"},{"author":{"_account_id":1002508,"name":"fboyer-mchp","email":"frederic.boyer@microchip.com","username":"fboyer-mchp"},"change_message_id":"12bfcddcf66e51c86f08287c3f6760809f96eb12","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#           -f board/microchip/sama7g54-ek.cfg"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Default to JTAG -- silently ignored if already selected"},{"line_number":55,"context_line":"catch { transport select jtag }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Target configuration (supports both JTAG and SWD)"},{"line_number":58,"context_line":"source [find target/microchip/sama7g5.cfg]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"4e61b2e4_3339fef1","line":55,"in_reply_to":"99539fed_176888a0","updated":"2026-04-22 08:57:39.000000000","message":"Remove","commit_id":"6e14553efb7cb0355a98a4338b090712c34c9e51"}]}