)]}'
{"id":"openocd~master~I7b98db25e518173ddde64379477100180e4a3d25","project":"openocd","branch":"master","attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2026-03-24 13:46:06.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I7b98db25e518173ddde64379477100180e4a3d25","subject":"semihosting: Don\u0027t mix buffered and unbuffered write","status":"NEW","created":"2026-03-24 13:41:30.000000000","updated":"2026-03-24 14:06:11.000000000","submit_type":"CHERRY_PICK","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cf7e9fa4e87a57eb9ed8ff7b26ed313ae898d9bd","_number":9542,"owner":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-03-24 14:06:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-24 13:41:38.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-24 13:46:06.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4eae6ea6973bf2a6cb76f29be964773803e3d638","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2026-03-24 13:41:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c4e245caef015b8c64d1188c7d42c959d594c04c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2026-03-24 13:46:01.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"1a2b5c267e2a90a47988ab1ad1187bb58ce06fc2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-24 13:46:06.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22014/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/22910/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cf7e9fa4e87a57eb9ed8ff7b26ed313ae898d9bd","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-24 14:06:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22015/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22911/ : SUCCESS","accounts_in_message":[],"_revision_number":2}],"current_revision":"1e3b998a24d3f43779e9cb492d89984c9f2ddda4","revisions":{"1a257c6b306e01ba6b8d7a60ded15d02dc1fb14a":{"kind":"REWORK","_number":1,"created":"2026-03-24 13:41:30.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/42/9542/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9542/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9542/1 \u0026\u0026 git checkout -b change-9542 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9542/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9542/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9542/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9542/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9542/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"636f43d28aca8d49b9b7c81d4cafdc27aab5b302","subject":"helper/replacements: Fix Windows build using clang (-Wsign-compare)"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2026-03-24 13:32:06.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2026-03-24 13:40:32.000000000","tz":60},"subject":"semihosting: Don\u0027t mix buffered and unbuffered write","message":"semihosting: Don\u0027t mix buffered and unbuffered write\n\nBuffered access to the same file should not be combined\nwith unbuffered access.\n\nFor that reason, when writing via semihosting to\nstdout/stderr, don\u0027t circumvent the libc via a direct\nwrite() system call. Instead use a fputc() from libc\nto avoid any clashes and unexpected behavior.\n\nIn Codasip, we in past internally encountered one case\nof unexpected syscall output that could possibly be\nattributed to this mixing of printf() + write() on\nthe standard streams.\n\nChange-Id: I7b98db25e518173ddde64379477100180e4a3d25\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}},"1e3b998a24d3f43779e9cb492d89984c9f2ddda4":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-03-24 13:46:01.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/42/9542/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9542/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9542/2 \u0026\u0026 git checkout -b change-9542 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9542/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9542/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9542/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9542/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9542/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"636f43d28aca8d49b9b7c81d4cafdc27aab5b302","subject":"helper/replacements: Fix Windows build using clang (-Wsign-compare)"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2026-03-24 13:32:06.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2026-03-24 13:45:55.000000000","tz":60},"subject":"semihosting: Don\u0027t mix buffered and unbuffered write","message":"semihosting: Don\u0027t mix buffered and unbuffered write\n\nBuffered access to the same file should not be combined\nwith unbuffered access.\n\nFor that reason, when writing via semihosting to\nstdout/stderr, don\u0027t circumvent the libc via a direct\nwrite() system call. Instead use a fputc() from libc\nto avoid any clashes and unexpected behavior.\n\nIn Codasip, we in past internally encountered one case\nof unexpected syscall output that could possibly be\nrelated to this.\n\nChange-Id: I7b98db25e518173ddde64379477100180e4a3d25\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}