)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3b3c06cb00878341e94e0a268595905ed2674c2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"064e4efd_e7b9cc28","updated":"2026-03-29 16:43:17.000000000","message":"YES! Thanks.\nThere are few things that could be improved, see below.\nI let you decide to implement them as a new version of this patch, or a separate patch on top of the series.","commit_id":"777deecd2f556aad9034566ec346bb5a32ec0397"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e723ac3e826764d0aaac35c5cb54071ecbe0bdc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ac7eee6e_73ffbcf5","updated":"2026-03-29 22:15:46.000000000","message":"I have just sent out https://review.openocd.org/c/openocd/+/9552 that also touches this file.\nI plan to first merge your series, then I will modify mine","commit_id":"49ffe4b73bdbbfa472c332d76e1b725b29df5948"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f134cc7fd45223add223e01882133cc8ea5e928d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c9e4be4_15151d75","updated":"2026-04-06 16:21:54.000000000","message":"Ok, not done here but in https://review.openocd.org/c/openocd/+/955o","commit_id":"49ffe4b73bdbbfa472c332d76e1b725b29df5948"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"1ce2aabbc5c8ec163f5167b17d069f3b4c8f85a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f2debd81_dc4b3ea4","updated":"2026-03-29 21:24:57.000000000","message":"Should be fixed now. Also fixed some indentation issues I had made","commit_id":"49ffe4b73bdbbfa472c332d76e1b725b29df5948"}],"src/target/dsp5680xx.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3b3c06cb00878341e94e0a268595905ed2674c2c","unresolved":true,"context_lines":[{"line_number":252,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":253,"context_line":"\t\treturn retval;"},{"line_number":254,"context_line":"\tretval \u003d jtag_data_write16(target, opcode, NULL);"},{"line_number":255,"context_line":"\treturn retval;"},{"line_number":256,"context_line":"}"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"/* Executes two word DSP instruction */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"79d1172a_3b2022d3","line":255,"updated":"2026-03-29 16:43:17.000000000","message":"this can be directly\n`return jtag_data_write16(...);`\nThere are other such cases below","commit_id":"777deecd2f556aad9034566ec346bb5a32ec0397"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"1ce2aabbc5c8ec163f5167b17d069f3b4c8f85a2","unresolved":false,"context_lines":[{"line_number":252,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":253,"context_line":"\t\treturn retval;"},{"line_number":254,"context_line":"\tretval \u003d jtag_data_write16(target, opcode, NULL);"},{"line_number":255,"context_line":"\treturn retval;"},{"line_number":256,"context_line":"}"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"/* Executes two word DSP instruction */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e74caf03_724b68a5","line":255,"in_reply_to":"79d1172a_3b2022d3","updated":"2026-03-29 21:24:57.000000000","message":"Done","commit_id":"777deecd2f556aad9034566ec346bb5a32ec0397"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3b3c06cb00878341e94e0a268595905ed2674c2c","unresolved":true,"context_lines":[{"line_number":538,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":539,"context_line":"\t\treturn retval;"},{"line_number":540,"context_line":"\tLOG_DEBUG(\"Reg. data: 0x%02X.\", *data_read);"},{"line_number":541,"context_line":"\treturn retval;"},{"line_number":542,"context_line":"}"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"static int eonce_read_status_reg(struct target *target, uint16_t *data)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"44408db3_89eddbd9","line":541,"updated":"2026-03-29 16:43:17.000000000","message":"this can become\n`return ERROR_OK;`\nas the value has already been checked above","commit_id":"777deecd2f556aad9034566ec346bb5a32ec0397"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"1ce2aabbc5c8ec163f5167b17d069f3b4c8f85a2","unresolved":false,"context_lines":[{"line_number":538,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":539,"context_line":"\t\treturn retval;"},{"line_number":540,"context_line":"\tLOG_DEBUG(\"Reg. data: 0x%02X.\", *data_read);"},{"line_number":541,"context_line":"\treturn retval;"},{"line_number":542,"context_line":"}"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"static int eonce_read_status_reg(struct target *target, uint16_t *data)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"59a3caec_2c52c9ba","line":541,"in_reply_to":"44408db3_89eddbd9","updated":"2026-03-29 21:24:57.000000000","message":"Done","commit_id":"777deecd2f556aad9034566ec346bb5a32ec0397"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3b3c06cb00878341e94e0a268595905ed2674c2c","unresolved":true,"context_lines":[{"line_number":631,"context_line":"\t\tcore_tap-\u003eenabled \u003d false;"},{"line_number":632,"context_line":"\t\tmaster_tap-\u003eenabled \u003d true;"},{"line_number":633,"context_line":"\t}"},{"line_number":634,"context_line":"\treturn retval;"},{"line_number":635,"context_line":"}"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4dacb159_9a17fce0","line":634,"updated":"2026-03-29 16:43:17.000000000","message":"also here\n`return ERROR_OK;`","commit_id":"777deecd2f556aad9034566ec346bb5a32ec0397"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"1ce2aabbc5c8ec163f5167b17d069f3b4c8f85a2","unresolved":false,"context_lines":[{"line_number":631,"context_line":"\t\tcore_tap-\u003eenabled \u003d false;"},{"line_number":632,"context_line":"\t\tmaster_tap-\u003eenabled \u003d true;"},{"line_number":633,"context_line":"\t}"},{"line_number":634,"context_line":"\treturn retval;"},{"line_number":635,"context_line":"}"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"58158d36_95e68c64","line":634,"in_reply_to":"4dacb159_9a17fce0","updated":"2026-03-29 21:24:57.000000000","message":"Done","commit_id":"777deecd2f556aad9034566ec346bb5a32ec0397"}]}