)]}'
{"id":"openocd~master~Iccba4196d1d40405b596957aa53f18c106db1dc7","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-03-29 22:16:43.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002476":{"account":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"last_update":"2026-04-06 16:24:46.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iccba4196d1d40405b596957aa53f18c106db1dc7","subject":"target/dsp5680xx: remove err_check()","status":"MERGED","created":"2026-03-29 13:58:13.000000000","updated":"2026-04-06 16:24:46.000000000","submitted":"2026-04-06 16:24:46.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9547","meta_rev_id":"36001818b943d13b56fb64913518f4e066b8afda","_number":9547,"owner":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-04-06 16:24:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-04-06 16:24:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-29 14:43:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-29 15:52:04.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-29 16:50:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"9d82b37b95f82a8d53d8d30338fde326b237c0fb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"real_author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"date":"2026-03-29 13:58:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"babf4d3db64eb24d8387180e6e2ae9831e0466ad","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-29 15:52:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22025/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22921/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"de6083d0c7e4f5b5c26db1c5483411ed83527b6a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-29 16:50:18.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"dba2c7f00923ede25f25b9ef1f56c8e92fb58cc7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"real_author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"date":"2026-03-29 21:23:16.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"07ac24c59913125cd65b658ab3e5d7a4ab21d523","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-29 22:16:43.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d0044692074d81a92065f9f0fd2cd241051a5ed0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-29 23:53:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22032/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22929/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"f5680452e62d8ab9105e33069d03cf9447a861d2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:24:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"36001818b943d13b56fb64913518f4e066b8afda","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:24:46.000000000","message":"Change has been successfully cherry-picked as 4894527eec68f43bd030779b1620cb1c64f187a0","accounts_in_message":[],"_revision_number":3}],"current_revision":"4894527eec68f43bd030779b1620cb1c64f187a0","revisions":{"28b972bb156d0ddbb2ff0770788eab0c1318ec30":{"kind":"REWORK","_number":1,"created":"2026-03-29 13:58:13.000000000","uploader":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"ref":"refs/changes/47/9547/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/47/9547/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/1 \u0026\u0026 git checkout -b change-9547 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/47/9547/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"27249e3e3145fb50a9b63820717565818f41f530","subject":"target/dsp5680xx: remove check_halt_and_debug()"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 11:47:17.000000000","tz":60},"committer":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 13:45:24.000000000","tz":60},"subject":"target/dsp5680xx: remove err_check()","message":"target/dsp5680xx: remove err_check()\n\nImprove readability by dropping macros containing `return`\n\nChange-Id: Iccba4196d1d40405b596957aa53f18c106db1dc7\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\n"}},"4894527eec68f43bd030779b1620cb1c64f187a0":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2026-04-06 16:24:46.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/47/9547/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/47/9547/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/3 \u0026\u0026 git checkout -b change-9547 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/47/9547/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4c072f0d0a3a308e0f8f1e596814838cd32cbdc3","subject":"target/dsp5680xx: remove check_halt_and_debug()"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 11:47:17.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-04-06 16:24:46.000000000","tz":0},"subject":"target/dsp5680xx: remove err_check()","message":"target/dsp5680xx: remove err_check()\n\nImprove readability by dropping macros containing `return`\n\nChange-Id: Iccba4196d1d40405b596957aa53f18c106db1dc7\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9547\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"995c0db4d6ff992308b688f8d0400097a937eff5":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-03-29 21:23:16.000000000","uploader":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"ref":"refs/changes/47/9547/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/47/9547/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/2 \u0026\u0026 git checkout -b change-9547 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/47/9547/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/47/9547/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"601fafc44a0e7004e2a79772e71dcc1ca292392b","subject":"target/dsp5680xx: remove check_halt_and_debug()"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 11:47:17.000000000","tz":60},"committer":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 21:08:58.000000000","tz":60},"subject":"target/dsp5680xx: remove err_check()","message":"target/dsp5680xx: remove err_check()\n\nImprove readability by dropping macros containing `return`\n\nChange-Id: Iccba4196d1d40405b596957aa53f18c106db1dc7\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}