)]}'
{"id":"openocd~master~I51c4ab29c4a958a721661e371a39bdf9f0c2a5e4","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-03-29 22:17:21.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1002476":{"account":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"last_update":"2026-04-06 16:24:57.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I51c4ab29c4a958a721661e371a39bdf9f0c2a5e4","subject":"target/dsp5680xx: declare vars at first use","status":"MERGED","created":"2026-03-29 13:58:13.000000000","updated":"2026-04-06 16:24:57.000000000","submitted":"2026-04-06 16:24:57.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9548","meta_rev_id":"c5cd41bdc82d473d2ac58712708f83599bd2c235","_number":9548,"owner":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-04-06 16:24:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-04-06 16:24:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-29 14:51:00.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-29 16:25:13.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-29 16:56:01.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2026-03-29 21:26:38.000000000","updated_by":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"reviewer":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"state":"CC"}],"messages":[{"id":"38b0fcec5f8719e6c2d4b43872b56a7c99fe0071","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"real_author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"date":"2026-03-29 13:58:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3ae2cef4d277e842e2bdac856b7eba0d1f07f1eb","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-29 16:25:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22026/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22922/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"24d11beb84f0cd77864c9a40628713c811c78f52","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-29 16:56:01.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0fc388c425647f817bc8e49e7d71fe81b552bf40","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"real_author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"date":"2026-03-29 21:23:16.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"fc5195ffef84ced256fc902b79ef6e0add1536e0","author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"real_author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"date":"2026-03-29 21:26:38.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"f5754cd6773b6c7ae3676350fcacf4a6372def39","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-29 22:17:21.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"14339405cdad15fb8f5bd81db64b604ac70d777d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-30 00:18:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22033/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22928/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"655a3709ccd1be490c881c0e5c0d880fb08c73d9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:24:54.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c5cd41bdc82d473d2ac58712708f83599bd2c235","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:24:57.000000000","message":"Change has been successfully cherry-picked as 607a16f20c38779ec62336cb8ad77640a8c2160a","accounts_in_message":[],"_revision_number":3}],"current_revision":"607a16f20c38779ec62336cb8ad77640a8c2160a","revisions":{"607a16f20c38779ec62336cb8ad77640a8c2160a":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2026-04-06 16:24:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/48/9548/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/9548/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/3 \u0026\u0026 git checkout -b change-9548 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/9548/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4894527eec68f43bd030779b1620cb1c64f187a0","subject":"target/dsp5680xx: remove err_check()"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 13:28:19.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-04-06 16:24:57.000000000","tz":0},"subject":"target/dsp5680xx: declare vars at first use","message":"target/dsp5680xx: declare vars at first use\n\nDeclare vars at point of first use as mentioned in C Style Guide.\n\nChange-Id: I51c4ab29c4a958a721661e371a39bdf9f0c2a5e4\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9548\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"7c12d9ac6e661f06691aa7cb207b439e68903343":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-03-29 21:23:16.000000000","uploader":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"ref":"refs/changes/48/9548/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/9548/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/2 \u0026\u0026 git checkout -b change-9548 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/9548/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"995c0db4d6ff992308b688f8d0400097a937eff5","subject":"target/dsp5680xx: remove err_check()"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 13:28:19.000000000","tz":60},"committer":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 21:08:58.000000000","tz":60},"subject":"target/dsp5680xx: declare vars at first use","message":"target/dsp5680xx: declare vars at first use\n\nDeclare vars at point of first use as mentioned in C Style Guide.\n\nChange-Id: I51c4ab29c4a958a721661e371a39bdf9f0c2a5e4\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\n"}},"b7e78b1c8e1edf183682d8efa827b2a5741e7c4f":{"kind":"REWORK","_number":1,"created":"2026-03-29 13:58:13.000000000","uploader":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"ref":"refs/changes/48/9548/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/48/9548/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/1 \u0026\u0026 git checkout -b change-9548 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/48/9548/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/48/9548/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"28b972bb156d0ddbb2ff0770788eab0c1318ec30","subject":"target/dsp5680xx: remove err_check()"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 13:28:19.000000000","tz":60},"committer":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 13:45:25.000000000","tz":60},"subject":"target/dsp5680xx: declare vars at first use","message":"target/dsp5680xx: declare vars at first use\n\nDeclare vars at point of first use as mentioned in C Style Guide.\n\nChange-Id: I51c4ab29c4a958a721661e371a39bdf9f0c2a5e4\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}