)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"630f6274166bc2aa29140e8aa78849d3245f43c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad32a0d5_df4149f6","updated":"2026-03-30 08:05:23.000000000","message":"Updated as suggested. Thanks","commit_id":"d1b716d9cc0ab7705e219d84e4da8a03d1179dba"}],"src/target/dsp5680xx.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3250ab39ce636e363290745ed33f9833ef614bb5","unresolved":true,"context_lines":[{"line_number":1535,"context_line":""},{"line_number":1536,"context_line":"\tif (strcmp(target-\u003etap-\u003echip, \"dsp568013\") \u003d\u003d 0) {"},{"line_number":1537,"context_line":"\t\tsim_addr \u003d MC568013_SIM_BASE_ADDR + S_FILE_DATA_OFFSET;"},{"line_number":1538,"context_line":"\t\tretval \u003d"},{"line_number":1539,"context_line":"\t\t\tdsp5680xx_write(target, sim_addr, 1, 2,"},{"line_number":1540,"context_line":"\t\t\t\t\t(const uint8_t *)\u0026sim_cmd);"},{"line_number":1541,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1fe1149d_e40a217c","line":1538,"updated":"2026-03-29 22:26:35.000000000","message":"Here it could be directly:\n`return dsp5680xx_write(...);`\nand outside the condition block\n`return ERROR_OK;`","commit_id":"d1b716d9cc0ab7705e219d84e4da8a03d1179dba"},{"author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"change_message_id":"630f6274166bc2aa29140e8aa78849d3245f43c5","unresolved":false,"context_lines":[{"line_number":1535,"context_line":""},{"line_number":1536,"context_line":"\tif (strcmp(target-\u003etap-\u003echip, \"dsp568013\") \u003d\u003d 0) {"},{"line_number":1537,"context_line":"\t\tsim_addr \u003d MC568013_SIM_BASE_ADDR + S_FILE_DATA_OFFSET;"},{"line_number":1538,"context_line":"\t\tretval \u003d"},{"line_number":1539,"context_line":"\t\t\tdsp5680xx_write(target, sim_addr, 1, 2,"},{"line_number":1540,"context_line":"\t\t\t\t\t(const uint8_t *)\u0026sim_cmd);"},{"line_number":1541,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"35d475dc_77d16d7d","line":1538,"in_reply_to":"1fe1149d_e40a217c","updated":"2026-03-30 08:05:23.000000000","message":"Done","commit_id":"d1b716d9cc0ab7705e219d84e4da8a03d1179dba"}]}