)]}'
{"id":"openocd~master~I98aad2d4c09c81e41a3efb639b0470cc663f5bd8","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-04-06 16:25:16.000000000","reason":"removed on reply"},"1002476":{"account":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"last_update":"2026-04-06 16:25:20.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I98aad2d4c09c81e41a3efb639b0470cc663f5bd8","subject":"target/dsp5680xx: cleanup retval usage","status":"MERGED","created":"2026-03-29 21:23:16.000000000","updated":"2026-04-06 16:25:20.000000000","submitted":"2026-04-06 16:25:20.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9550","meta_rev_id":"d1e150399beb573e6f55a9c0a9fa9b41db52747a","_number":9550,"owner":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-04-06 16:25:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-04-06 16:25:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-29 22:03:53.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-29 22:26:35.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2026-03-29 23:27:43.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-30 08:05:23.000000000","updated_by":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"reviewer":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"state":"CC"},{"updated":"2026-04-06 16:25:16.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"4a87f930682fe627376fd6294853bd5cc027a723","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"real_author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"date":"2026-03-29 21:23:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3250ab39ce636e363290745ed33f9833ef614bb5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-29 22:26:35.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b44fd2c53e769b9a1563d3bd635e12c553371aff","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-29 23:27:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22031/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22927/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8f93c8a6234f3595d96dfa29d9378ca850cdf63a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"real_author":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"date":"2026-03-30 08:04:36.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"630f6274166bc2aa29140e8aa78849d3245f43c5","author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"real_author":{"_account_id":1002482,"name":"Mark O\u0027Donovan","username":"shiftee"},"date":"2026-03-30 08:05:23.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"fd1470297bcb296f9fed5b42092ea8620ac96f52","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-30 08:27:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22037/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22933/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"c07d6f7792e1b9b1d720c4f3c4945161e5b74db6","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:25:16.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d1e150399beb573e6f55a9c0a9fa9b41db52747a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 16:25:20.000000000","message":"Change has been successfully cherry-picked as 944fb35b70ad575b8fcd86e53039269bcdc0f366","accounts_in_message":[],"_revision_number":3}],"current_revision":"944fb35b70ad575b8fcd86e53039269bcdc0f366","revisions":{"944fb35b70ad575b8fcd86e53039269bcdc0f366":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2026-04-06 16:25:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/50/9550/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/9550/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/3 \u0026\u0026 git checkout -b change-9550 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/9550/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea07cc74ce7c712fe64ea9f7251af3f02114a149","subject":"target/dsp5680xx: add missing retval assignment"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 20:55:54.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-04-06 16:25:20.000000000","tz":0},"subject":"target/dsp5680xx: cleanup retval usage","message":"target/dsp5680xx: cleanup retval usage\n\nReduce unnecessary assignment to retval.\n\nChange-Id: I98aad2d4c09c81e41a3efb639b0470cc663f5bd8\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9550\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"dd5f181fb1593e7d2dceae10addef9e1f661c972":{"kind":"REWORK","_number":2,"created":"2026-03-30 08:04:36.000000000","uploader":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"ref":"refs/changes/50/9550/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/9550/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/2 \u0026\u0026 git checkout -b change-9550 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/9550/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"45b51b5d9dd0379c33a71c86a9ee71f93235c82c","subject":"target/dsp5680xx: add missing retval assignment"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 20:55:54.000000000","tz":60},"committer":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-30 08:01:16.000000000","tz":60},"subject":"target/dsp5680xx: cleanup retval usage","message":"target/dsp5680xx: cleanup retval usage\n\nReduce unnecessary assignment to retval.\n\nChange-Id: I98aad2d4c09c81e41a3efb639b0470cc663f5bd8\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\n"}},"d1b716d9cc0ab7705e219d84e4da8a03d1179dba":{"kind":"REWORK","_number":1,"created":"2026-03-29 21:23:16.000000000","uploader":{"_account_id":1002476,"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","username":"shiftee1"},"ref":"refs/changes/50/9550/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/9550/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/1 \u0026\u0026 git checkout -b change-9550 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/9550/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/9550/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"45b51b5d9dd0379c33a71c86a9ee71f93235c82c","subject":"target/dsp5680xx: add missing retval assignment"}],"author":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 20:55:54.000000000","tz":60},"committer":{"name":"Mark O\u0027Donovan","email":"shiftee@posteo.net","date":"2026-03-29 21:08:58.000000000","tz":60},"subject":"target/dsp5680xx: cleanup retval usage","message":"target/dsp5680xx: cleanup retval usage\n\nReduce unnecessary assignment to retval.\n\nChange-Id: I98aad2d4c09c81e41a3efb639b0470cc663f5bd8\nSigned-off-by: Mark O\u0027Donovan \u003cshiftee@posteo.net\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}