)]}'
{"id":"openocd~master~Ib28b5034f6e9881f2569dc88e7cf4810662a0845","project":"openocd","branch":"master","attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2026-04-06 17:22:23.000000000","reason":"Vote got outdated and was removed: Code-Review+1"}},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-04-06 22:06:46.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"Ib28b5034f6e9881f2569dc88e7cf4810662a0845","subject":"openocd: drop variable for constant return value","status":"NEW","created":"2026-03-29 21:55:42.000000000","updated":"2026-04-06 22:06:46.000000000","submit_type":"CHERRY_PICK","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a10957a211e86341c5124b93e2eaef4e9aa55115","_number":9551,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-04-06 21:47:32.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":1,"date":"2026-04-06 22:06:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-29 23:09:55.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-30 01:11:43.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-30 07:22:24.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"}],"messages":[{"id":"0ea7f501171c0015ab5fac1ed25256d27b75490e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-03-29 21:55:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"35302183def134daac26a169a9d28eeb2bd5d6b0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-03-30 01:11:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22035/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22931/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a045fbd4debaf1c35399f356898ba65f9fdc0b00","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-03-30 07:22:24.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"2e7c80f5c1c637ad896fd08349242e36c7770b8d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 17:22:23.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"44f0ca9c83aeada7ae6fc59721ea00593eee8da4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-04-06 21:47:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22064/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22960/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a10957a211e86341c5124b93e2eaef4e9aa55115","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-04-06 22:06:46.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2}],"current_revision":"f1b5910bc5e8c25fc391d50d8dd7c6c9fe08185e","revisions":{"9236444d42722c6da0bb66d6e4a50e07a368b75c":{"kind":"REWORK","_number":1,"created":"2026-03-29 21:55:42.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/51/9551/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/51/9551/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/51/9551/1 \u0026\u0026 git checkout -b change-9551 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/51/9551/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/51/9551/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/51/9551/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/51/9551/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/51/9551/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e4c49d86052dfc241ec60bbd3b7e190307891722","subject":"server/server: Fix build on FreeBSD"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-03-29 16:15:10.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-03-29 17:05:33.000000000","tz":120},"subject":"openocd: drop variable for constant return value","message":"openocd: drop variable for constant return value\n\nPattern detected with coccinelle script in Linux code\nscripts/coccinelle/misc/returnvar.cocci\n\nChange-Id: Ib28b5034f6e9881f2569dc88e7cf4810662a0845\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"f1b5910bc5e8c25fc391d50d8dd7c6c9fe08185e":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-04-06 17:22:23.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/51/9551/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/51/9551/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/51/9551/2 \u0026\u0026 git checkout -b change-9551 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/51/9551/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/51/9551/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/51/9551/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/51/9551/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/51/9551/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b80f554fd982b65bd3b45bb151655abe634e938b","subject":"helper/log: Fix build issue on MSYS2 and Cygwin"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-03-29 16:15:10.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-04-06 17:16:12.000000000","tz":120},"subject":"openocd: drop variable for constant return value","message":"openocd: drop variable for constant return value\n\nPattern detected with coccinelle script in Linux code\nscripts/coccinelle/misc/returnvar.cocci\n\nChange-Id: Ib28b5034f6e9881f2569dc88e7cf4810662a0845\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}