)]}'
{"id":"openocd~master~I016a8e5344c5c957e994e343c8fef010c8c05b69","project":"openocd","branch":"master","hashtags":[],"change_id":"I016a8e5344c5c957e994e343c8fef010c8c05b69","subject":"target/riscv: fix stale cache after register write via Tcl \u0027reg\u0027 command","status":"NEW","created":"2026-04-03 15:11:33.000000000","updated":"2026-04-03 15:35:36.000000000","submit_type":"CHERRY_PICK","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"298ac8d69452efd6f62907a35100cd0e1daf7449","_number":9555,"owner":{"_account_id":1002505,"name":"Ciro Cattuto","email":"ciro.cattuto@gmail.com","username":"ccattuto"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-04-03 15:35:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-03 15:11:42.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-04-03 15:35:36.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3da00ed25a59eb715239aebb81851c33ccccad44","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002505,"name":"Ciro Cattuto","email":"ciro.cattuto@gmail.com","username":"ccattuto"},"real_author":{"_account_id":1002505,"name":"Ciro Cattuto","email":"ciro.cattuto@gmail.com","username":"ccattuto"},"date":"2026-04-03 15:11:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"298ac8d69452efd6f62907a35100cd0e1daf7449","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-04-03 15:35:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22045/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/22941/ : SUCCESS","accounts_in_message":[],"_revision_number":1}],"current_revision":"91330d3dfa0753cbc293be7cad2ea2d4679ef208","revisions":{"91330d3dfa0753cbc293be7cad2ea2d4679ef208":{"kind":"REWORK","_number":1,"created":"2026-04-03 15:11:33.000000000","uploader":{"_account_id":1002505,"name":"Ciro Cattuto","email":"ciro.cattuto@gmail.com","username":"ccattuto"},"ref":"refs/changes/55/9555/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/55/9555/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/55/9555/1 \u0026\u0026 git checkout -b change-9555 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/55/9555/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/55/9555/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/55/9555/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/55/9555/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/55/9555/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e4c49d86052dfc241ec60bbd3b7e190307891722","subject":"server/server: Fix build on FreeBSD"}],"author":{"name":"Ciro Cattuto","email":"ciro.cattuto@gmail.com","date":"2026-04-03 15:06:42.000000000","tz":120},"committer":{"name":"Ciro Cattuto","email":"ciro.cattuto@gmail.com","date":"2026-04-03 15:11:24.000000000","tz":120},"subject":"target/riscv: fix stale cache after register write via Tcl \u0027reg\u0027 command","message":"target/riscv: fix stale cache after register write via Tcl \u0027reg\u0027 command\n\nriscv013_reg_set() and riscv011_reg_set() did not update the register\u0027s\nown cache entry (reg-\u003evalue) after a successful write. As a result, the\nTcl \u0027reg \u003cname\u003e \u003cvalue\u003e\u0027 command printed the stale pre-write value as\nconfirmation rather than the value just written.\n\nFor the 0.13 path, this is most visible with \u0027reg pc\u0027: writes to PC are\nredirected to DPC inside riscv_set_or_write_register(), which correctly\nupdates the DPC cache entry but leaves the PC cache entry stale. The\nfix updates the PC cache entry explicitly after the write.\n\nFor the 0.11 path, the same omission affects all registers.\n\nThe hardware state was always written correctly; only the Tcl command\noutput was misleading.\n\nChange-Id: I016a8e5344c5c957e994e343c8fef010c8c05b69\nSigned-off-by: Ciro Cattuto \u003cciro.cattuto@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}