)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3c2efadb76648356e8e12b7d7ec10efb23d010ac","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kulyatskaya Alexandra \u003ca.kulyatskaya@syntacore.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-04-20 15:26:07 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[src/server] Support x packet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement the binary memory read GDB packet \u0027x addr,length\u0027."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d1ec8993_0c993ea6","line":7,"updated":"2026-04-21 10:35:26.000000000","message":"server: gdb: add support for \u0027x\u0027 packet","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e491cfdd11c364f313748835aa9ce9ca09b2ad87","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kulyatskaya Alexandra \u003ca.kulyatskaya@syntacore.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-04-20 15:26:07 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[src/server] Support x packet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement the binary memory read GDB packet \u0027x addr,length\u0027."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d0f5aa1f_8cc0518b","line":7,"in_reply_to":"9315af6d_ecf139b7","updated":"2026-07-04 18:46:18.000000000","message":"Done","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"},"change_message_id":"079e8144ac4b613e4857403068af2c9e134edf5f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kulyatskaya Alexandra \u003ca.kulyatskaya@syntacore.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-04-20 15:26:07 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[src/server] Support x packet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement the binary memory read GDB packet \u0027x addr,length\u0027."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9315af6d_ecf139b7","line":7,"in_reply_to":"d1ec8993_0c993ea6","updated":"2026-04-28 11:49:14.000000000","message":"Done","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e491cfdd11c364f313748835aa9ce9ca09b2ad87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5db2eafe_cd4d3d4a","updated":"2026-07-04 18:46:18.000000000","message":"Sorry for late review","commit_id":"b11308eb603df032413f6957c6081a839af497bc"},{"author":{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"},"change_message_id":"fe6ab62bd3cc6d95990c8d38c7d78e3be4b80b5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"069def5b_c1a63f35","updated":"2026-07-02 08:48:55.000000000","message":"gentle ping","commit_id":"b11308eb603df032413f6957c6081a839af497bc"}],"src/helper/log.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e491cfdd11c364f313748835aa9ce9ca09b2ad87","unresolved":true,"context_lines":[{"line_number":190,"context_line":"/* ERROR_TIMEOUT is already taken by winerror.h. */"},{"line_number":191,"context_line":"#define ERROR_TIMEOUT_REACHED\t\t\t(-6)"},{"line_number":192,"context_line":"#define ERROR_NOT_IMPLEMENTED\t\t\t(-7)"},{"line_number":193,"context_line":"#define ERROR_INVALID_PACKET_LEN\t    (-8)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"#endif /* OPENOCD_HELPER_LOG_H */"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"7efa3c25_d8a6c157","line":193,"updated":"2026-07-04 18:46:18.000000000","message":"This is only used by GDB.\nPlease move it in `src/server/gdb_server.h` as `ERROR_GDB_INVALID_PACKET_LEN`","commit_id":"b11308eb603df032413f6957c6081a839af497bc"}],"src/server/gdb_server.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3c2efadb76648356e8e12b7d7ec10efb23d010ac","unresolved":true,"context_lines":[{"line_number":1532,"context_line":"\treturn ERROR_OK;"},{"line_number":1533,"context_line":"}"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"static bool parse_packet_addr_len(char const *packet, uint64_t *addr, uint32_t *len)"},{"line_number":1536,"context_line":"{"},{"line_number":1537,"context_line":"\tchar *separator;"},{"line_number":1538,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"9208f1d0_dfb7bd4d","line":1535,"updated":"2026-04-21 10:35:26.000000000","message":"We usually return ERROR_OK/ERROR_FAIL.\nI see two boolean functions in this file, `gdb_handle_vcont_packet()` and `gdb_handle_vrun_packet()`. For me those should be converted to ERROR_OK/ERROR_FAIL too.\nFor this patch, I prefer sticking to ERROR_OK/ERROR_FAIL return value.","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"},"change_message_id":"079e8144ac4b613e4857403068af2c9e134edf5f","unresolved":true,"context_lines":[{"line_number":1532,"context_line":"\treturn ERROR_OK;"},{"line_number":1533,"context_line":"}"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"static bool parse_packet_addr_len(char const *packet, uint64_t *addr, uint32_t *len)"},{"line_number":1536,"context_line":"{"},{"line_number":1537,"context_line":"\tchar *separator;"},{"line_number":1538,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d27dc6cb_792804ed","line":1535,"in_reply_to":"9208f1d0_dfb7bd4d","updated":"2026-04-28 11:49:14.000000000","message":"Done","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e491cfdd11c364f313748835aa9ce9ca09b2ad87","unresolved":false,"context_lines":[{"line_number":1532,"context_line":"\treturn ERROR_OK;"},{"line_number":1533,"context_line":"}"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"static bool parse_packet_addr_len(char const *packet, uint64_t *addr, uint32_t *len)"},{"line_number":1536,"context_line":"{"},{"line_number":1537,"context_line":"\tchar *separator;"},{"line_number":1538,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d646b7ca_651affa4","line":1535,"in_reply_to":"d27dc6cb_792804ed","updated":"2026-07-04 18:46:18.000000000","message":"Done","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3c2efadb76648356e8e12b7d7ec10efb23d010ac","unresolved":true,"context_lines":[{"line_number":1545,"context_line":"\t\treturn false;"},{"line_number":1546,"context_line":""},{"line_number":1547,"context_line":"\terrno \u003d 0;"},{"line_number":1548,"context_line":"\tlong signed_len \u003d strtol(separator + 1, NULL, 16);"},{"line_number":1549,"context_line":"\tif (errno \u003d\u003d ERANGE || signed_len \u003c 0 || (unsigned long)signed_len \u003e UINT32_MAX)"},{"line_number":1550,"context_line":"\t\treturn false;"},{"line_number":1551,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"0a92e37a_c225b13d","line":1548,"updated":"2026-04-21 10:35:26.000000000","message":"You change from `strtoul()` to `strtol()`, and then you check if we got a negative `len`.\nBy returning `false` for negative or too-big, it changes the behavior of the code because now the caller returns ERROR_SERVER_REMOTE_CLOSED.\nAll without explaining in the commit message why you change this.","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"},"change_message_id":"079e8144ac4b613e4857403068af2c9e134edf5f","unresolved":true,"context_lines":[{"line_number":1545,"context_line":"\t\treturn false;"},{"line_number":1546,"context_line":""},{"line_number":1547,"context_line":"\terrno \u003d 0;"},{"line_number":1548,"context_line":"\tlong signed_len \u003d strtol(separator + 1, NULL, 16);"},{"line_number":1549,"context_line":"\tif (errno \u003d\u003d ERANGE || signed_len \u003c 0 || (unsigned long)signed_len \u003e UINT32_MAX)"},{"line_number":1550,"context_line":"\t\treturn false;"},{"line_number":1551,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"19dc1b9a_39576972","line":1548,"in_reply_to":"0a92e37a_c225b13d","updated":"2026-04-28 11:49:14.000000000","message":"Done","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e491cfdd11c364f313748835aa9ce9ca09b2ad87","unresolved":false,"context_lines":[{"line_number":1545,"context_line":"\t\treturn false;"},{"line_number":1546,"context_line":""},{"line_number":1547,"context_line":"\terrno \u003d 0;"},{"line_number":1548,"context_line":"\tlong signed_len \u003d strtol(separator + 1, NULL, 16);"},{"line_number":1549,"context_line":"\tif (errno \u003d\u003d ERANGE || signed_len \u003c 0 || (unsigned long)signed_len \u003e UINT32_MAX)"},{"line_number":1550,"context_line":"\t\treturn false;"},{"line_number":1551,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e0a19d16_4681517c","line":1548,"in_reply_to":"19dc1b9a_39576972","updated":"2026-07-04 18:46:18.000000000","message":"Done","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3c2efadb76648356e8e12b7d7ec10efb23d010ac","unresolved":true,"context_lines":[{"line_number":1613,"context_line":"\tif (!buffer) {"},{"line_number":1614,"context_line":"\t\tLOG_ERROR(\"Unable to allocate memory\");"},{"line_number":1615,"context_line":"\t\tgdb_send_error(connection, 01);"},{"line_number":1616,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1617,"context_line":"\t}"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"\tretval \u003d gdb_read_memory(connection, buffer, addr, len);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"416851a1_4adc8fc0","line":1616,"updated":"2026-04-21 10:35:26.000000000","message":"This file doesn\u0027t enforce check on `malloc()`, bad!\nSo thanks for taking care here and below.\nBut why returning `ERROR_OK`?","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"},"change_message_id":"079e8144ac4b613e4857403068af2c9e134edf5f","unresolved":true,"context_lines":[{"line_number":1613,"context_line":"\tif (!buffer) {"},{"line_number":1614,"context_line":"\t\tLOG_ERROR(\"Unable to allocate memory\");"},{"line_number":1615,"context_line":"\t\tgdb_send_error(connection, 01);"},{"line_number":1616,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1617,"context_line":"\t}"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"\tretval \u003d gdb_read_memory(connection, buffer, addr, len);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e8268138_58178f41","line":1616,"in_reply_to":"416851a1_4adc8fc0","updated":"2026-04-28 11:49:14.000000000","message":"Return ERROR_OK consistent with similar error handling in this file (when `gdb_send_error(connection, 01)` is sent)\"","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e491cfdd11c364f313748835aa9ce9ca09b2ad87","unresolved":false,"context_lines":[{"line_number":1613,"context_line":"\tif (!buffer) {"},{"line_number":1614,"context_line":"\t\tLOG_ERROR(\"Unable to allocate memory\");"},{"line_number":1615,"context_line":"\t\tgdb_send_error(connection, 01);"},{"line_number":1616,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1617,"context_line":"\t}"},{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"\tretval \u003d gdb_read_memory(connection, buffer, addr, len);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"a1ddac7d_694a32a4","line":1616,"in_reply_to":"e8268138_58178f41","updated":"2026-07-04 18:46:18.000000000","message":"`gdb_send_error(connection, 01)` is used to report to GDB an error condition, usually due to remote protocol.\nHere instead it\u0027s an OpenOCD internal error because it\u0027s unable to allocate the memory.\nI\u0027m not sure if we should continue or return error.\nAnyway we cannot recover from an out of memory, so eventually OpenOCD will crash later. We have the error log reporting it, let\u0027s continue!","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3c2efadb76648356e8e12b7d7ec10efb23d010ac","unresolved":true,"context_lines":[{"line_number":1695,"context_line":"\t/* len * 2 : each byte may need escaping → 2 bytes max per input byte"},{"line_number":1696,"context_line":"\t* +1 : for \u0027b\u0027 prefix"},{"line_number":1697,"context_line":"\t* +1 : for null terminator */"},{"line_number":1698,"context_line":"\tout_buffer \u003d malloc(len * 2 + 1 + 1);"},{"line_number":1699,"context_line":"\tif (!out_buffer) {"},{"line_number":1700,"context_line":"\t\tLOG_ERROR(\"Unable to allocate memory for output buffer\");"},{"line_number":1701,"context_line":"\t\tgdb_send_error(connection, 01);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"05aacfaf_97ba1390","line":1698,"updated":"2026-04-21 10:35:26.000000000","message":"You can use add here\n`char *out_buffer \u003d malloc(len * 2 + 1 + 1);`\nwithout initializing it to NULL above, then below...","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e491cfdd11c364f313748835aa9ce9ca09b2ad87","unresolved":false,"context_lines":[{"line_number":1695,"context_line":"\t/* len * 2 : each byte may need escaping → 2 bytes max per input byte"},{"line_number":1696,"context_line":"\t* +1 : for \u0027b\u0027 prefix"},{"line_number":1697,"context_line":"\t* +1 : for null terminator */"},{"line_number":1698,"context_line":"\tout_buffer \u003d malloc(len * 2 + 1 + 1);"},{"line_number":1699,"context_line":"\tif (!out_buffer) {"},{"line_number":1700,"context_line":"\t\tLOG_ERROR(\"Unable to allocate memory for output buffer\");"},{"line_number":1701,"context_line":"\t\tgdb_send_error(connection, 01);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c89d691e_24c3e75c","line":1698,"in_reply_to":"02634709_aa8139d4","updated":"2026-07-04 18:46:18.000000000","message":"Done","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"},"change_message_id":"079e8144ac4b613e4857403068af2c9e134edf5f","unresolved":true,"context_lines":[{"line_number":1695,"context_line":"\t/* len * 2 : each byte may need escaping → 2 bytes max per input byte"},{"line_number":1696,"context_line":"\t* +1 : for \u0027b\u0027 prefix"},{"line_number":1697,"context_line":"\t* +1 : for null terminator */"},{"line_number":1698,"context_line":"\tout_buffer \u003d malloc(len * 2 + 1 + 1);"},{"line_number":1699,"context_line":"\tif (!out_buffer) {"},{"line_number":1700,"context_line":"\t\tLOG_ERROR(\"Unable to allocate memory for output buffer\");"},{"line_number":1701,"context_line":"\t\tgdb_send_error(connection, 01);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"02634709_aa8139d4","line":1698,"in_reply_to":"05aacfaf_97ba1390","updated":"2026-04-28 11:49:14.000000000","message":"Dond","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3c2efadb76648356e8e12b7d7ec10efb23d010ac","unresolved":true,"context_lines":[{"line_number":1710,"context_line":"\t\tretval \u003d gdb_put_packet(connection, out_buffer, pkt_len);"},{"line_number":1711,"context_line":"\t}"},{"line_number":1712,"context_line":""},{"line_number":1713,"context_line":"cleanup:"},{"line_number":1714,"context_line":"\tfree(out_buffer);"},{"line_number":1715,"context_line":"\tfree(buffer);"},{"line_number":1716,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"67f2e190_aaf0afd9","line":1713,"updated":"2026-04-21 10:35:26.000000000","message":"here the sequence should be:\n```\n    free(out_buffer);\ncleanup:\n    free(buffer);\n    \n    return retval;\n}\n```","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"},"change_message_id":"079e8144ac4b613e4857403068af2c9e134edf5f","unresolved":true,"context_lines":[{"line_number":1710,"context_line":"\t\tretval \u003d gdb_put_packet(connection, out_buffer, pkt_len);"},{"line_number":1711,"context_line":"\t}"},{"line_number":1712,"context_line":""},{"line_number":1713,"context_line":"cleanup:"},{"line_number":1714,"context_line":"\tfree(out_buffer);"},{"line_number":1715,"context_line":"\tfree(buffer);"},{"line_number":1716,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c4e32872_63af3556","line":1713,"in_reply_to":"67f2e190_aaf0afd9","updated":"2026-04-28 11:49:14.000000000","message":"Done","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e491cfdd11c364f313748835aa9ce9ca09b2ad87","unresolved":false,"context_lines":[{"line_number":1710,"context_line":"\t\tretval \u003d gdb_put_packet(connection, out_buffer, pkt_len);"},{"line_number":1711,"context_line":"\t}"},{"line_number":1712,"context_line":""},{"line_number":1713,"context_line":"cleanup:"},{"line_number":1714,"context_line":"\tfree(out_buffer);"},{"line_number":1715,"context_line":"\tfree(buffer);"},{"line_number":1716,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"035d2b2e_ba9ff731","line":1713,"in_reply_to":"c4e32872_63af3556","updated":"2026-07-04 18:46:18.000000000","message":"Done","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3c2efadb76648356e8e12b7d7ec10efb23d010ac","unresolved":true,"context_lines":[{"line_number":3052,"context_line":"\t\t\t\u0026buffer,"},{"line_number":3053,"context_line":"\t\t\t\u0026pos,"},{"line_number":3054,"context_line":"\t\t\t\u0026size,"},{"line_number":3055,"context_line":"\t\t\t\"PacketSize\u003d%x;qXfer:memory-map:read%c;qXfer:features:read%c;qXfer:threads:read+;QStartNoAckMode+;vContSupported+;binary-upload+\","},{"line_number":3056,"context_line":"\t\t\tGDB_BUFFER_SIZE,"},{"line_number":3057,"context_line":"\t\t\t(gdb_use_memory_map \u0026\u0026 (flash_get_bank_count() \u003e 0)) ? \u0027+\u0027 : \u0027-\u0027,"},{"line_number":3058,"context_line":"\t\t\tgdb_target_desc_supported ? \u0027+\u0027 : \u0027-\u0027);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"af8d36e4_21218570","line":3055,"updated":"2026-04-21 10:35:26.000000000","message":"This string is growing too much and will grow further.\nCheckpatch does not complains for strings split at `;`.\nIf you don\u0027t mind, please rewrite this string with one item per line, sorted:\n```\n    \u0026size,\n    \"PacketSize\u003d%x;\"\n    \"QStartNoAckMode+;\"\n    \"binary-upload+;\"\n    \"qXfer:features:read%c;\"\n    \"qXfer:memory-map:read%c;\"\n    \"qXfer:threads:read+;\"\n    \"vContSupported+\"\n    GDB_BUFFER_SIZE,\n```","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e491cfdd11c364f313748835aa9ce9ca09b2ad87","unresolved":false,"context_lines":[{"line_number":3052,"context_line":"\t\t\t\u0026buffer,"},{"line_number":3053,"context_line":"\t\t\t\u0026pos,"},{"line_number":3054,"context_line":"\t\t\t\u0026size,"},{"line_number":3055,"context_line":"\t\t\t\"PacketSize\u003d%x;qXfer:memory-map:read%c;qXfer:features:read%c;qXfer:threads:read+;QStartNoAckMode+;vContSupported+;binary-upload+\","},{"line_number":3056,"context_line":"\t\t\tGDB_BUFFER_SIZE,"},{"line_number":3057,"context_line":"\t\t\t(gdb_use_memory_map \u0026\u0026 (flash_get_bank_count() \u003e 0)) ? \u0027+\u0027 : \u0027-\u0027,"},{"line_number":3058,"context_line":"\t\t\tgdb_target_desc_supported ? \u0027+\u0027 : \u0027-\u0027);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"f01935a8_5cccc1ef","line":3055,"in_reply_to":"673c8fc2_7898ac17","updated":"2026-07-04 18:46:18.000000000","message":"Done","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"},"change_message_id":"079e8144ac4b613e4857403068af2c9e134edf5f","unresolved":true,"context_lines":[{"line_number":3052,"context_line":"\t\t\t\u0026buffer,"},{"line_number":3053,"context_line":"\t\t\t\u0026pos,"},{"line_number":3054,"context_line":"\t\t\t\u0026size,"},{"line_number":3055,"context_line":"\t\t\t\"PacketSize\u003d%x;qXfer:memory-map:read%c;qXfer:features:read%c;qXfer:threads:read+;QStartNoAckMode+;vContSupported+;binary-upload+\","},{"line_number":3056,"context_line":"\t\t\tGDB_BUFFER_SIZE,"},{"line_number":3057,"context_line":"\t\t\t(gdb_use_memory_map \u0026\u0026 (flash_get_bank_count() \u003e 0)) ? \u0027+\u0027 : \u0027-\u0027,"},{"line_number":3058,"context_line":"\t\t\tgdb_target_desc_supported ? \u0027+\u0027 : \u0027-\u0027);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"673c8fc2_7898ac17","line":3055,"in_reply_to":"af8d36e4_21218570","updated":"2026-04-28 11:49:14.000000000","message":"Done","commit_id":"af54e452c3118c01b8d369833f4e957ba1089a57"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e491cfdd11c364f313748835aa9ce9ca09b2ad87","unresolved":true,"context_lines":[{"line_number":1606,"context_line":"\tif (retval \u003d\u003d ERROR_INVALID_PACKET_LEN) {"},{"line_number":1607,"context_line":"\t\tgdb_put_packet(connection, \"\", 0);"},{"line_number":1608,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1609,"context_line":"\t} else if (retval !\u003d ERROR_OK) {"},{"line_number":1610,"context_line":"\t\treturn retval;"},{"line_number":1611,"context_line":"\t}"},{"line_number":1612,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":8,"id":"4612bd9c_e85d3eec","line":1609,"updated":"2026-07-04 18:46:18.000000000","message":"no need for `else` after `return`.\n```\n\tif (retval \u003d\u003d ERROR_INVALID_PACKET_LEN) {\n\t\tgdb_put_packet(connection, \"\", 0);\n\t\treturn ERROR_OK;\n\t}\n\tif (retval !\u003d ERROR_OK)\n\t\treturn retval;\n```","commit_id":"b11308eb603df032413f6957c6081a839af497bc"}]}