)]}'
{"id":"openocd~master~I5177dc59322549eafe03a78a984390300fbab0db","project":"openocd","branch":"master","attention_set":{"1002513":{"account":{"_account_id":1002513,"name":"Sergi・セルジ","display_name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","username":"xerpi"},"last_update":"2026-07-04 08:51:50.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I5177dc59322549eafe03a78a984390300fbab0db","subject":"tcl/target/xilinx_zynqmp: fix ELF loading in boot_apu and boot_pmu","status":"NEW","created":"2026-04-28 03:10:46.000000000","updated":"2026-07-12 15:25:26.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":3,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"19467d66cc4df489716cd1e78ce47443bfb8674c","_number":9603,"owner":{"_account_id":1002513,"name":"Sergi・セルジ","display_name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","username":"xerpi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-07-02 09:35:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"CC":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-28 03:48:58.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-04-28 04:12:49.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-07-04 08:51:50.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2026-07-12 15:25:26.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"}],"messages":[{"id":"13dfde632b7c6dd49ebee04673ebe55090dc49d7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002513,"name":"Sergi・セルジ","display_name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","username":"xerpi"},"real_author":{"_account_id":1002513,"name":"Sergi・セルジ","display_name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","username":"xerpi"},"date":"2026-04-28 03:10:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"90f0fef0b4df86a658e4e406163ae7ab4a636c04","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-04-28 04:12:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22183/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23082/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"badce07e12924f2fcc149d44289717e50f85c37f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002513,"name":"Sergi・セルジ","display_name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","username":"xerpi"},"real_author":{"_account_id":1002513,"name":"Sergi・セルジ","display_name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","username":"xerpi"},"date":"2026-05-01 01:37:50.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"fa2cda26a02d31481a15c72b5cf1b88896b81cc2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-05-01 02:39:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22201/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23099/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"19c510534c2ba81751939875a18d02f504161e37","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-05-08 13:52:24.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"1583fe191f8bf156bf96347aee17209551ed0ad4","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-05-09 01:05:22.000000000","message":"Patch Set 2: -Verified","accounts_in_message":[],"_revision_number":2},{"id":"286e17cd963f5aaa883dd9475ba57fd771f1b417","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-05-09 11:49:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22293/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23191/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5ea367204e87cc9f4416c2603a88ecb331e49b25","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002513,"name":"Sergi・セルジ","display_name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","username":"xerpi"},"real_author":{"_account_id":1002513,"name":"Sergi・セルジ","display_name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","username":"xerpi"},"date":"2026-07-02 08:22:53.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"6a63c1fd88a8765f72263b604f196e56318f60c7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-07-02 09:35:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22597/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23498/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"cf34448d4e8e04de8750700e11c808f9d71d5d29","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2026-07-04 08:51:50.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"19467d66cc4df489716cd1e78ce47443bfb8674c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-07-12 15:25:26.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3}],"current_revision":"ab4e0b8d5aa40a36ec672dbb05d7ecd7b75e24c2","revisions":{"ab4e0b8d5aa40a36ec672dbb05d7ecd7b75e24c2":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-07-02 08:22:53.000000000","uploader":{"_account_id":1002513,"name":"Sergi・セルジ","display_name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","username":"xerpi"},"ref":"refs/changes/03/9603/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/9603/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/3 \u0026\u0026 git checkout -b change-9603 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/9603/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e0696e82437633035f47221b40be760eea73f321","subject":"target: add image_info command"}],"author":{"name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","date":"2026-04-28 03:04:16.000000000","tz":540},"committer":{"name":"Sergi (セルジ)","email":"sergi-granell-escalfet@arkedgespace.com","date":"2026-07-02 08:08:24.000000000","tz":540},"subject":"tcl/target/xilinx_zynqmp: fix ELF loading in boot_apu and boot_pmu","message":"tcl/target/xilinx_zynqmp: fix ELF loading in boot_apu and boot_pmu\n\nboot_apu and boot_pmu passed $addr as a relocation offset to\nload_image. For raw binaries this correctly places the image at $addr,\nbut for address-aware formats (ELF, IHEX, S19) it shifts every segment\nby $addr on top of the addresses already embedded in the image.\n\nUse image_info to detect the image type and only pass the address\noffset for binary images. For address-aware formats call load_image\nwithout an offset so segments land at their correct addresses.\n\nFor boot_apu, use the entry address from image metadata when available\n(ELF e_entry, IHEX record type 05) and fall back to $addr otherwise.\n\nFor boot_pmu, emit a warning if the image carries an entry address\noutside PMU RAM [PMU_RAM_BASE, PMU_RAM_BASE + PMU_RAM_SIZE), since the\nPMU ROM always jumps to PMU_RAM_BASE regardless.\n\nChange-Id: I5177dc59322549eafe03a78a984390300fbab0db\nSigned-off-by: Sergi Granell Escalfet \u003cxerpi.g.12@gmail.com\u003e\n"}},"19fb6aca33b1d4fb29fe1749d89e8d1fcafa32ad":{"kind":"REWORK","_number":2,"created":"2026-05-01 01:37:50.000000000","uploader":{"_account_id":1002513,"name":"Sergi・セルジ","display_name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","username":"xerpi"},"ref":"refs/changes/03/9603/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/9603/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/2 \u0026\u0026 git checkout -b change-9603 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/9603/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0302a9b540c27c806cce8e4b1104f697779196b6","subject":"target: add image_info command"}],"author":{"name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","date":"2026-04-28 03:04:16.000000000","tz":540},"committer":{"name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","date":"2026-05-01 01:35:24.000000000","tz":540},"subject":"tcl/target/xilinx_zynqmp: fix ELF loading in boot_apu and boot_pmu","message":"tcl/target/xilinx_zynqmp: fix ELF loading in boot_apu and boot_pmu\n\nboot_apu and boot_pmu passed $addr as a relocation offset to\nload_image. For raw binaries this correctly places the image at $addr,\nbut for address-aware formats (ELF, IHEX, S19) it shifts every segment\nby $addr on top of the addresses already embedded in the image.\n\nUse image_info to detect the image type and only pass the address\noffset for binary images. For address-aware formats call load_image\nwithout an offset so segments land at their correct addresses.\n\nFor boot_apu, use the entry address from image metadata when available\n(ELF e_entry, IHEX record type 05) and fall back to $addr otherwise.\n\nFor boot_pmu, emit a warning if the image carries an entry address\noutside PMU RAM [PMU_RAM_BASE, PMU_RAM_BASE + PMU_RAM_SIZE), since the\nPMU ROM always jumps to PMU_RAM_BASE regardless.\n\nChange-Id: I5177dc59322549eafe03a78a984390300fbab0db\nSigned-off-by: Sergi Granell Escalfet \u003cxerpi.g.12@gmail.com\u003e\n"}},"cf5d6435fdfeb71dfb54bcf47b14913b549a7ac5":{"kind":"REWORK","_number":1,"created":"2026-04-28 03:10:46.000000000","uploader":{"_account_id":1002513,"name":"Sergi・セルジ","display_name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","username":"xerpi"},"ref":"refs/changes/03/9603/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/9603/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/1 \u0026\u0026 git checkout -b change-9603 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/9603/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/9603/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ebefb72d7675ff7585dbb7d5194819edd8a64be6","subject":"target: add load_image_info command"}],"author":{"name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","date":"2026-04-28 03:04:16.000000000","tz":540},"committer":{"name":"Sergi Granell Escalfet","email":"xerpi.g.12@gmail.com","date":"2026-04-28 03:09:57.000000000","tz":540},"subject":"tcl/target/xilinx_zynqmp: fix ELF loading in boot_apu and boot_pmu","message":"tcl/target/xilinx_zynqmp: fix ELF loading in boot_apu and boot_pmu\n\nboot_apu and boot_pmu passed $addr as a relocation offset to\nload_image. For raw binaries this correctly places the image at $addr,\nbut for address-aware formats (ELF, IHEX, S19) it shifts every segment\nby $addr on top of the addresses already embedded in the image.\n\nUse load_image_info to detect the image type and only pass the address\noffset for binary images. For address-aware formats call load_image\nwithout an offset so segments land at their correct addresses.\n\nFor boot_apu, use the entry address from image metadata when available\n(ELF e_entry, IHEX record type 05) and fall back to $addr otherwise.\n\nFor boot_pmu, emit a warning if the image carries an entry address\noutside PMU RAM [PMU_RAM_BASE, PMU_RAM_BASE + PMU_RAM_SIZE), since the\nPMU ROM always jumps to PMU_RAM_BASE regardless.\n\nChange-Id: I5177dc59322549eafe03a78a984390300fbab0db\nSigned-off-by: Sergi Granell Escalfet \u003cxerpi.g.12@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}