)]}'
{"src/jtag/adapter.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"960d0142a9cd81fcba2cd8580ed5eb1b2c7ab909","unresolved":true,"context_lines":[{"line_number":1158,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"\tfree(adapter_config.product_name);"},{"line_number":1161,"context_line":"\tadapter_config.product_name \u003d strdup(CMD_ARGV[0]);"},{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"\treturn ERROR_OK;"},{"line_number":1164,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"626dc3d0_9717c435","line":1161,"updated":"2026-05-09 09:31:07.000000000","message":"In all the modified drivers, either they use libftdi, libusb or mpsse, they check for `product_name !\u003d NULL`. If not `NULL` then they consider it points to a valid string.\nThere is no way to overwrite, on OpenOCD command line, the default string set by the cfg file.\nPassing an empty string\n`adapter usb product_name \"\"`\nwill not work!\nWhat about detecting and using the empty string to overwrite the default?\n```\nfree(adapter_config.product_name);\nadapter_config.product_name \u003d NULL;\nif (*CMD_ARGV[0])\n    adapter_config.product_name \u003d strdup(CMD_ARGV[0]);\n```","commit_id":"edb68557e0172c9a823e153d15ae42da36c6188d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"42014e26f6c9a1b4bf6262f08e18d40264b4ee1c","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"\tfree(adapter_config.product_name);"},{"line_number":1161,"context_line":"\tadapter_config.product_name \u003d strdup(CMD_ARGV[0]);"},{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"\treturn ERROR_OK;"},{"line_number":1164,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"15cf4688_ef4af1cb","line":1161,"in_reply_to":"626dc3d0_9717c435","updated":"2026-05-09 10:02:55.000000000","message":"Good idea, implemented and tested.","commit_id":"edb68557e0172c9a823e153d15ae42da36c6188d"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7eab2f77e129907b51b82b7a8c0abee07335bc03","unresolved":true,"context_lines":[{"line_number":1176,"context_line":"\t\t.handler \u003d \u0026handle_usb_product_name_command,"},{"line_number":1177,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":1178,"context_line":"\t\t.help \u003d \"set the USB product name of the USB device\","},{"line_number":1179,"context_line":"\t\t.usage \u003d \"(vid pid)*\","},{"line_number":1180,"context_line":"\t},"},{"line_number":1181,"context_line":"#ifdef HAVE_LIBUSB_GET_PORT_NUMBERS"},{"line_number":1182,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"23c82445_a7a44d91","line":1179,"updated":"2026-05-09 09:13:29.000000000","message":"Something weird here. Copy paste issue, I presume!\nThe drivers that are modified in this series use \u0027description_string\u0027 here, but I think \u0027name\u0027 could be better fit here, aligned with what you have put in the doc","commit_id":"edb68557e0172c9a823e153d15ae42da36c6188d"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"42014e26f6c9a1b4bf6262f08e18d40264b4ee1c","unresolved":false,"context_lines":[{"line_number":1176,"context_line":"\t\t.handler \u003d \u0026handle_usb_product_name_command,"},{"line_number":1177,"context_line":"\t\t.mode \u003d COMMAND_CONFIG,"},{"line_number":1178,"context_line":"\t\t.help \u003d \"set the USB product name of the USB device\","},{"line_number":1179,"context_line":"\t\t.usage \u003d \"(vid pid)*\","},{"line_number":1180,"context_line":"\t},"},{"line_number":1181,"context_line":"#ifdef HAVE_LIBUSB_GET_PORT_NUMBERS"},{"line_number":1182,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0e94066a_7bfd2213","line":1179,"in_reply_to":"23c82445_a7a44d91","updated":"2026-05-09 10:02:55.000000000","message":"Ups, fixed. Thanks!","commit_id":"edb68557e0172c9a823e153d15ae42da36c6188d"}]}