)]}'
{"id":"openocd~master~Iccc029c9ea1787eb361e4fba8119398abf5dafe1","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2026-05-30 18:13:46.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-05-12 08:28:27.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}},"hashtags":[],"change_id":"Iccc029c9ea1787eb361e4fba8119398abf5dafe1","subject":"rtt: Fix reading inactive channels","status":"MERGED","created":"2026-05-10 12:39:51.000000000","updated":"2026-05-30 18:13:46.000000000","submitted":"2026-05-30 18:13:46.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9652","meta_rev_id":"57aefd964a42e7dc7968d4e9a20425e09c981631","_number":9652,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-05-30 18:13:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000716,"name":"Chris Head","email":"chead@zaber.com","username":"Hawk777"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000716,"name":"Chris Head","email":"chead@zaber.com","username":"Hawk777"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-05-30 18:13:46.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-05-30 18:13:46.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-05-30 18:13:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000716,"name":"Chris Head","email":"chead@zaber.com","username":"Hawk777"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000716,"name":"Chris Head","email":"chead@zaber.com","username":"Hawk777"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-10 12:40:02.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-05-10 12:40:28.000000000","updated_by":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2026-05-10 12:58:17.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-05-27 18:39:47.000000000","updated_by":{"_account_id":1000716,"name":"Chris Head","email":"chead@zaber.com","username":"Hawk777"},"reviewer":{"_account_id":1000716,"name":"Chris Head","email":"chead@zaber.com","username":"Hawk777"},"state":"REVIEWER"}],"messages":[{"id":"d2842a349f1894516a6176b32d51713edc76b8e9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-05-10 12:39:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bfd60bf1ac28b7f55a0cb41d3efb875f566d06d5","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-05-10 12:40:28.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e271f7b5b745c5c9594b9b00cda89cfec271ed3d","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-05-10 12:58:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22319/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23219/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e6a97b4e8c21207542d0404390ec94ba90f827ea","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-05-12 08:28:27.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5d2c5661cecd0c6669f2384b63a6c0cf23e48d21","author":{"_account_id":1000716,"name":"Chris Head","email":"chead@zaber.com","username":"Hawk777"},"real_author":{"_account_id":1000716,"name":"Chris Head","email":"chead@zaber.com","username":"Hawk777"},"date":"2026-05-27 18:39:47.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"57aefd964a42e7dc7968d4e9a20425e09c981631","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-05-30 18:13:46.000000000","message":"Change has been successfully cherry-picked as fcfbbe98b2280ddd78da5cca207a8674adf11e85","accounts_in_message":[],"_revision_number":2}],"current_revision":"fcfbbe98b2280ddd78da5cca207a8674adf11e85","revisions":{"fcfbbe98b2280ddd78da5cca207a8674adf11e85":{"kind":"REWORK","_number":2,"created":"2026-05-30 18:13:46.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/52/9652/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/9652/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/9652/2 \u0026\u0026 git checkout -b change-9652 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/9652/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/9652/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/9652/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/9652/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/9652/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"56d91e42e30585358a03e9f31c0a9f4253fb3f3c","subject":"target/rtt: support 64-bit targets by using dynamic offsets"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-05-10 12:20:14.000000000","tz":0},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-05-30 18:13:46.000000000","tz":0},"subject":"rtt: Fix reading inactive channels","message":"rtt: Fix reading inactive channels\n\nThe current implementation reads the names of inactive channels, which\ncan result in invalid data reads, memory access violations, and broken\noutput, for example:\n\n\u003e rtt channellist\n[riscv.cpu] Failed to read memory (addr\u003d0x0)\n{\n    {\n        name  Terminal\n        size  0x400\n        flags 0x0\n    }\n\nSkip reading the names of inactive channels to avoid invalid memory\nreads and broken output.\n\nChange-Id: Iccc029c9ea1787eb361e4fba8119398abf5dafe1\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9652\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Chris Head \u003cchead@zaber.com\u003e\nTested-by: jenkins\n"}},"8e0137700f2f7928d05b957ebf3bb58be9d921b2":{"kind":"REWORK","_number":1,"created":"2026-05-10 12:39:51.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/52/9652/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/9652/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/9652/1 \u0026\u0026 git checkout -b change-9652 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/9652/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/9652/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/9652/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/9652/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/9652/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"52c5e2e853ad2b816a378f3744e7118f49c561d8","subject":"target/rtt: support 64-bit targets by using dynamic offsets"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-05-10 12:20:14.000000000","tz":0},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-05-10 12:37:38.000000000","tz":120},"subject":"rtt: Fix reading inactive channels","message":"rtt: Fix reading inactive channels\n\nThe current implementation reads the names of inactive channels, which\ncan result in invalid data reads, memory access violations, and broken\noutput, for example:\n\n\u003e rtt channellist\n[riscv.cpu] Failed to read memory (addr\u003d0x0)\n{\n    {\n        name  Terminal\n        size  0x400\n        flags 0x0\n    }\n\nSkip reading the names of inactive channels to avoid invalid memory\nreads and broken output.\n\nChange-Id: Iccc029c9ea1787eb361e4fba8119398abf5dafe1\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000716,"name":"Chris Head","email":"chead@zaber.com","username":"Hawk777"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}