)]}'
{"id":"openocd~master~I3971d4fe624c0b4eb6164a0eb6d435407b2371ad","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2026-06-21 17:40:39.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3971d4fe624c0b4eb6164a0eb6d435407b2371ad","subject":"adapter/cmsis-dap: Remove redundant NULL check in LOG_ERROR()","status":"MERGED","created":"2026-05-18 12:25:26.000000000","updated":"2026-06-21 17:40:39.000000000","submitted":"2026-06-21 17:40:39.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9661","meta_rev_id":"e19ee6564bd332693dd8eb1c44a69c0e4e311572","_number":9661,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-06-21 17:40:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-06-21 17:40:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-18 12:25:39.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-05-18 12:43:32.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-06-08 15:32:15.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"8c22eb102c38a139f804e64f193b9c0054092a95","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-05-18 12:25:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f0c1df6e795e55af388deb22d43f3a7c374601c0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-05-18 12:43:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22353/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23253/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"1d2ca8af399b8f854b0bdb7108093910c6b7138c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-05-24 09:15:23.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"591909846bc30cad2a88740cc86f144cfbb40cd9","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-05-24 11:10:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22387/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23288/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"b910b7b320e2d35ea98061f6186c850aee70e018","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-06-08 15:32:15.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"6a8c789860694ffe68b0341668284ab0b7e13391","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-06-21 17:40:35.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e19ee6564bd332693dd8eb1c44a69c0e4e311572","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-06-21 17:40:39.000000000","message":"Change has been successfully cherry-picked as e849a792dbf22316c1a4b5c0e2241d17b81faafa","accounts_in_message":[],"_revision_number":3}],"current_revision":"e849a792dbf22316c1a4b5c0e2241d17b81faafa","revisions":{"b4ecae8d724057daf116042c2ea0d47df4b85ea4":{"kind":"REWORK","_number":1,"created":"2026-05-18 12:25:26.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/61/9661/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/9661/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/1 \u0026\u0026 git checkout -b change-9661 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/9661/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5753fe54addcad354c0b42c0b256b418dc3cc32b","subject":"adapter/cmsis-dap: Improve TCP backend error reporting"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-05-15 11:15:14.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-05-18 12:25:01.000000000","tz":120},"subject":"adapter/cmsis-dap: Remove redundant NULL check in LOG_ERROR()","message":"adapter/cmsis-dap: Remove redundant NULL check in LOG_ERROR()\n\nDrop the conditional around cmsis_dap_tcp_host in LOG_ERROR(), since the\nvariable is already checked earlier and cannot be NULL at this point.\n\nChange-Id: I3971d4fe624c0b4eb6164a0eb6d435407b2371ad\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"72cf1c1f3688e7329ffc89e1fec77f7bdca0e2ba":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-05-24 09:15:23.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/61/9661/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/9661/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/2 \u0026\u0026 git checkout -b change-9661 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/9661/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"be32bf76cf1f13ff60534583fef1e3815445eb77","subject":"adapter/cmsis-dap: Improve TCP backend error reporting"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-05-15 11:15:14.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-05-24 09:10:00.000000000","tz":120},"subject":"adapter/cmsis-dap: Remove redundant NULL check in LOG_ERROR()","message":"adapter/cmsis-dap: Remove redundant NULL check in LOG_ERROR()\n\nDrop the conditional around cmsis_dap_tcp_host in LOG_ERROR(), since the\nvariable is already checked earlier and cannot be NULL at this point.\n\nChange-Id: I3971d4fe624c0b4eb6164a0eb6d435407b2371ad\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"e849a792dbf22316c1a4b5c0e2241d17b81faafa":{"kind":"REWORK","_number":3,"created":"2026-06-21 17:40:39.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/61/9661/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/9661/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/3 \u0026\u0026 git checkout -b change-9661 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/9661/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/9661/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"65ab10881db577d7266ddf3cd5d4ffd98a4efd2f","subject":"adapter/cmsis-dap: Improve TCP backend error reporting"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-05-15 11:15:14.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-06-21 17:40:39.000000000","tz":0},"subject":"adapter/cmsis-dap: Remove redundant NULL check in LOG_ERROR()","message":"adapter/cmsis-dap: Remove redundant NULL check in LOG_ERROR()\n\nDrop the conditional around cmsis_dap_tcp_host in LOG_ERROR(), since the\nvariable is already checked earlier and cannot be NULL at this point.\n\nChange-Id: I3971d4fe624c0b4eb6164a0eb6d435407b2371ad\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9661\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}