)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5fc95cb0a3ed1729783f33a5669431625a611afd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d643167d_d04ae881","updated":"2026-05-19 08:43:04.000000000","message":"Thanks for this patch.\nI think you could also add a file for the board, if you have one.\nAnd please create the needed folders `tcl/*/holtek/` to put the manufacturer\u0027s specific files.","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"},{"author":{"_account_id":1002518,"name":"Felipe Moura Oliveira","email":"moura.fmo@gmail.com","username":"fmoura"},"change_message_id":"fbefae95a68a1d5b9406dd187ca5e6771ebec024","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9766c0bb_43c46eab","in_reply_to":"d643167d_d04ae881","updated":"2026-05-19 16:20:29.000000000","message":"Hello Antonio, thanks for you review.\nThis is my first time here. I am glad to contribute.","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"},{"author":{"_account_id":1002518,"name":"Felipe Moura Oliveira","email":"moura.fmo@gmail.com","username":"fmoura"},"change_message_id":"fbefae95a68a1d5b9406dd187ca5e6771ebec024","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86a322c2_9efe5a74","updated":"2026-05-19 16:20:29.000000000","message":"Hello, please see my comments.","commit_id":"d8e800ece5847d07dd17b39c1dc73dae5ea54882"},{"author":{"_account_id":1002518,"name":"Felipe Moura Oliveira","email":"moura.fmo@gmail.com","username":"fmoura"},"change_message_id":"c7c759730ba348d30a8f9059e6e2563a99d58276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7dba9887_682ea35a","updated":"2026-05-21 19:13:55.000000000","message":"You re right Marc, HT32F4 support both. My fault was use HT32F0 as reference, there they are using only the SWD.\n\nPlease review again.","commit_id":"5ad41f8ab062902160dfc72e12973a005eb8276a"}],"doc/openocd.texi":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d7b1b929093f6ebb5f5ff686272571849d08f95a","unresolved":true,"context_lines":[{"line_number":6767,"context_line":"@item AT32WB415"},{"line_number":6768,"context_line":"@end itemize"},{"line_number":6769,"context_line":""},{"line_number":6770,"context_line":"Some Holtek HT32F4 devices (e.g.@: the HT32F49153 and HT32F49163) use a"},{"line_number":6771,"context_line":"flash memory controller that is register-compatible with the Artery AT32F423"},{"line_number":6772,"context_line":"and are therefore programmed by this driver.  The"},{"line_number":6773,"context_line":"@file{target/holtek/ht32f4x.cfg} target configuration selects it, together"}],"source_content_type":"text/x-texinfo","patch_set":5,"id":"9e8ad5d2_b18fdc7d","line":6770,"updated":"2026-05-21 20:50:14.000000000","message":"Stray `@`?","commit_id":"feea5cbb38f7ba939c9c470c98c299cb6671e94a"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d7b1b929093f6ebb5f5ff686272571849d08f95a","unresolved":true,"context_lines":[{"line_number":6769,"context_line":""},{"line_number":6770,"context_line":"Some Holtek HT32F4 devices (e.g.@: the HT32F49153 and HT32F49163) use a"},{"line_number":6771,"context_line":"flash memory controller that is register-compatible with the Artery AT32F423"},{"line_number":6772,"context_line":"and are therefore programmed by this driver.  The"},{"line_number":6773,"context_line":"@file{target/holtek/ht32f4x.cfg} target configuration selects it, together"},{"line_number":6774,"context_line":"with @file{interface/holtek/e-link32.cfg} for the Holtek e-Link32 adapter;"},{"line_number":6775,"context_line":"@file{board/holtek/esk32-31401.cfg} ties them together for the Holtek"},{"line_number":6776,"context_line":"ESK32-31401 starter kit."},{"line_number":6777,"context_line":""},{"line_number":6778,"context_line":"Devices with dual-bank flash memory are currently not supported."},{"line_number":6779,"context_line":"Also, access to user data in the user system data (USD) area is not supported."}],"source_content_type":"text/x-texinfo","patch_set":5,"id":"78b81360_28021fc3","line":6776,"range":{"start_line":6772,"start_character":44,"end_line":6776,"end_character":24},"updated":"2026-05-21 20:50:14.000000000","message":"I think this is not necessary and unrelated here.","commit_id":"feea5cbb38f7ba939c9c470c98c299cb6671e94a"}],"tcl/board/holtek/esk32-31401.cfg":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d7b1b929093f6ebb5f5ff686272571849d08f95a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# HT32F49163 (100LQFP) with an on-board Holtek e-Link32 debugger."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"source [find interface/holtek/e-link32.cfg]"},{"line_number":8,"context_line":"source [find target/holtek/ht32f4x.cfg]"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Connection-related settings (depend on the board wiring between the"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"7c828387_aa47dc65","line":7,"updated":"2026-05-21 20:50:14.000000000","message":"Add here `transport select swd` or `transport select jtag`, depending on that is connected on the board.","commit_id":"feea5cbb38f7ba939c9c470c98c299cb6671e94a"}],"tcl/interface/htlink.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5fc95cb0a3ed1729783f33a5669431625a611afd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Holtek e-Link32 Pro/Lite in-circuit debugger/programmer"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# The e-Link32 is a CMSIS-DAP class adapter. Two USB PID pairs are known:"},{"line_number":6,"context_line":"#   0x04d9:0x802f  e-Link32 Pro"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"92bb71e2_66a58547","line":3,"updated":"2026-05-19 08:43:04.000000000","message":"I think this file should be named `tcl/interface/holtek/e-link32.cfg` or similar","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"},{"author":{"_account_id":1002518,"name":"Felipe Moura Oliveira","email":"moura.fmo@gmail.com","username":"fmoura"},"change_message_id":"fbefae95a68a1d5b9406dd187ca5e6771ebec024","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Holtek e-Link32 Pro/Lite in-circuit debugger/programmer"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# The e-Link32 is a CMSIS-DAP class adapter. Two USB PID pairs are known:"},{"line_number":6,"context_line":"#   0x04d9:0x802f  e-Link32 Pro"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"9abaac32_b2355e96","line":3,"in_reply_to":"92bb71e2_66a58547","updated":"2026-05-19 16:20:29.000000000","message":"Hello Antonio, for learning purposes only, why it should be inside a vendor folder?","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"ae5ceb47ff51f4392f5e49f40332ac8039af197d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# SPDX-License-Identifier: GPL-2.0-or-later"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Holtek e-Link32 Pro/Lite in-circuit debugger/programmer"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# The e-Link32 is a CMSIS-DAP class adapter. Two USB PID pairs are known:"},{"line_number":6,"context_line":"#   0x04d9:0x802f  e-Link32 Pro"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"e724d828_d90e1ed3","line":3,"in_reply_to":"9abaac32_b2355e96","updated":"2026-05-20 20:20:16.000000000","message":"Hi Felipe,\n\nThis is simply to provide a bit of structure and order. See https://openocd.org/doc/doxygen/html/config_files.html","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5fc95cb0a3ed1729783f33a5669431625a611afd","unresolved":true,"context_lines":[{"line_number":6,"context_line":"#   0x04d9:0x802f  e-Link32 Pro"},{"line_number":7,"context_line":"#   0x04d9:0x8052  e-Link32 Lite"},{"line_number":8,"context_line":"source [find interface/cmsis-dap.cfg]"},{"line_number":9,"context_line":"adapter usb vid_pid 0x04d9 0x802f 0x04d9 0x8052"},{"line_number":10,"context_line":"transport select swd"},{"line_number":11,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"46179176_f368464b","line":9,"updated":"2026-05-19 08:43:04.000000000","message":"Please add these VID/PID in the file `contrib/60-openocd.rules`, keeping it ordered by VID number","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"},{"author":{"_account_id":1002518,"name":"Felipe Moura Oliveira","email":"moura.fmo@gmail.com","username":"fmoura"},"change_message_id":"fbefae95a68a1d5b9406dd187ca5e6771ebec024","unresolved":true,"context_lines":[{"line_number":6,"context_line":"#   0x04d9:0x802f  e-Link32 Pro"},{"line_number":7,"context_line":"#   0x04d9:0x8052  e-Link32 Lite"},{"line_number":8,"context_line":"source [find interface/cmsis-dap.cfg]"},{"line_number":9,"context_line":"adapter usb vid_pid 0x04d9 0x802f 0x04d9 0x8052"},{"line_number":10,"context_line":"transport select swd"},{"line_number":11,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"46236fcc_edbdac75","line":9,"in_reply_to":"46179176_f368464b","updated":"2026-05-19 16:20:29.000000000","message":"Done","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5fc95cb0a3ed1729783f33a5669431625a611afd","unresolved":true,"context_lines":[{"line_number":7,"context_line":"#   0x04d9:0x8052  e-Link32 Lite"},{"line_number":8,"context_line":"source [find interface/cmsis-dap.cfg]"},{"line_number":9,"context_line":"adapter usb vid_pid 0x04d9 0x802f 0x04d9 0x8052"},{"line_number":10,"context_line":"transport select swd"},{"line_number":11,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"2847a38a_d3b0022b","line":10,"updated":"2026-05-19 08:43:04.000000000","message":"Is the e-link32 that is SWD only? In such case, it\u0027s OK to ave this line here but please add a comment specifying the limitation.\nIf instead is the board that only connects SWD, then this command should go in the board file.","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"},{"author":{"_account_id":1002518,"name":"Felipe Moura Oliveira","email":"moura.fmo@gmail.com","username":"fmoura"},"change_message_id":"fbefae95a68a1d5b9406dd187ca5e6771ebec024","unresolved":true,"context_lines":[{"line_number":7,"context_line":"#   0x04d9:0x8052  e-Link32 Lite"},{"line_number":8,"context_line":"source [find interface/cmsis-dap.cfg]"},{"line_number":9,"context_line":"adapter usb vid_pid 0x04d9 0x802f 0x04d9 0x8052"},{"line_number":10,"context_line":"transport select swd"},{"line_number":11,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"77047719_b443640e","line":10,"in_reply_to":"2847a38a_d3b0022b","updated":"2026-05-19 16:20:29.000000000","message":"The SWD-only restriction here is the chip (neither the adapter nor the board).\nThe Holtek HT32 family are SWD-only.\nThe e-Link32 itself is a CMSIS-DAP class adapter and supports SWD and JTAG.\nThinking better I believe that the right way is move \"transport select swd\" to the target file.","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"},{"author":{"_account_id":1002518,"name":"Felipe Moura Oliveira","email":"moura.fmo@gmail.com","username":"fmoura"},"change_message_id":"c7c759730ba348d30a8f9059e6e2563a99d58276","unresolved":true,"context_lines":[{"line_number":7,"context_line":"#   0x04d9:0x8052  e-Link32 Lite"},{"line_number":8,"context_line":"source [find interface/cmsis-dap.cfg]"},{"line_number":9,"context_line":"adapter usb vid_pid 0x04d9 0x802f 0x04d9 0x8052"},{"line_number":10,"context_line":"transport select swd"},{"line_number":11,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"2e6fdb9c_698e993a","line":10,"in_reply_to":"4a9f4259_bbef13fc","updated":"2026-05-21 19:13:55.000000000","message":"You re right Marc, HT32F4 support both. My fault was use HT32F0 as reference, there they are using only the SWD.","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"ae5ceb47ff51f4392f5e49f40332ac8039af197d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"#   0x04d9:0x8052  e-Link32 Lite"},{"line_number":8,"context_line":"source [find interface/cmsis-dap.cfg]"},{"line_number":9,"context_line":"adapter usb vid_pid 0x04d9 0x802f 0x04d9 0x8052"},{"line_number":10,"context_line":"transport select swd"},{"line_number":11,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"4a9f4259_bbef13fc","line":10,"in_reply_to":"77047719_b443640e","updated":"2026-05-20 20:20:16.000000000","message":"According to the datasheet, the chip you tested supports JTAG and SWD. See https://www.holtek.com/webapi/187541/HT32F49153_63_UserManual_v110.pdf","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5fc95cb0a3ed1729783f33a5669431625a611afd","unresolved":true,"context_lines":[{"line_number":8,"context_line":"source [find interface/cmsis-dap.cfg]"},{"line_number":9,"context_line":"adapter usb vid_pid 0x04d9 0x802f 0x04d9 0x8052"},{"line_number":10,"context_line":"transport select swd"},{"line_number":11,"context_line":"adapter speed 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"5af09ff1_409a80d4","line":11,"updated":"2026-05-19 08:43:04.000000000","message":"`adapter speed` should go in the board file, where the connections could limit the max speed","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"}],"tcl/target/holtek/ht32f4x.cfg":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"d7b1b929093f6ebb5f5ff686272571849d08f95a","unresolved":true,"context_lines":[{"line_number":8,"context_line":"# Artery AT32F423 / AT32F425 series."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Some HT32F4x parts implement SWJ-DP and also support JTAG. Select SWD as the default."},{"line_number":11,"context_line":"transport select swd"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"source [find target/swj-dp.tcl]"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"1a72292c_ac667439","line":11,"updated":"2026-05-21 20:50:14.000000000","message":"Don\u0027t use a default here, the user needs to specfiy either in the (board) config or via command-line.","commit_id":"feea5cbb38f7ba939c9c470c98c299cb6671e94a"}],"tcl/target/ht32f4x.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5fc95cb0a3ed1729783f33a5669431625a611afd","unresolved":true,"context_lines":[{"line_number":39,"context_line":"# Flash size is auto-detected from the device ID by the artery driver."},{"line_number":40,"context_line":"flash bank $_CHIPNAME.flash artery 0x08000000 0 0 0 $_TARGETNAME"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"reset_config srst_only srst_nogate"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"e2770452_bc40e2d7","line":42,"updated":"2026-05-19 08:43:04.000000000","message":"I think the `reset_config srst_nogate` should stay here, because it\u0027s chip related. But since it\u0027s the default, it could even be omitted.\nInstead `reset_config srst_only` should stay in the board file as it\u0027s related to the connections between the adapter and the chip.","commit_id":"009aefcd4e1d33f09129d0bff4d39104a6ac2d11"}]}