)]}'
{"id":"openocd~master~I21a1877e1eb3cfa59a43129216117ac397d09b95","project":"openocd","branch":"master","attention_set":{"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2026-05-19 09:39:05.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I21a1877e1eb3cfa59a43129216117ac397d09b95","subject":"jtag: fix behavior of Tcl commands before init","status":"NEW","created":"2026-05-19 08:55:47.000000000","updated":"2026-05-21 12:02:42.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3435474e0e23645547e261359a169dc6f44cbe3e","_number":9665,"owner":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-05-21 12:02:42.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-19 09:10:57.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-05-19 09:39:05.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5037df99dbf2ca8ad9785a2d95714b4fe8165c4a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2026-05-19 08:55:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9c93f00b4f767fb7322513bf611d91a6c4f15654","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-05-19 09:39:05.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22357/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/23257/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"9c3bacc8037faea7e5e6b6e6a2e4986f05a372fe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2026-05-20 15:39:04.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"18b328ae65a0b6ec6ffb7f7ba5b40cbfc577efab","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-05-20 17:37:51.000000000","message":"Patch Set 2: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22368/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/23268/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"df578842ea8836b43cc9b0eefe9be905d66110a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2026-05-21 11:07:03.000000000","message":"Uploaded patch set 3: Commit message was updated.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"3435474e0e23645547e261359a169dc6f44cbe3e","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-05-21 12:02:42.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22372/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23272/ : SUCCESS","accounts_in_message":[],"_revision_number":3}],"current_revision":"a5bdd632e1dcf446b62474156bc9b70a66e33e2e","revisions":{"a5bdd632e1dcf446b62474156bc9b70a66e33e2e":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2026-05-21 11:07:03.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/65/9665/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/9665/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/3 \u0026\u0026 git checkout -b change-9665 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/9665/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d84c45465bf3ba1dab330c0b9c29a531c7cd6588","subject":"src: jtag: cleanup `pathmove` command"}],"author":{"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","date":"2026-03-23 12:06:22.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","date":"2026-05-21 11:05:39.000000000","tz":180},"subject":"jtag: fix behavior of Tcl commands before init","message":"jtag: fix behavior of Tcl commands before init\n\nRunning\n```\nopenocd -c \u0027adapter driver dummy\u0027 -c \u0027jtag arp_init\u0027\n```\nused to result in an assertion failure in `jtag_checks()`.\n\nThis is due to the fact that `jtag init` was not called and therefore\n`jtaf_init()` has not called `jtag_add_reset()`, so that `jtag_trst \u003d\u003d\n-1`.\n\nSimilar issues can be observed for other JTAG commands.\n\nThis patch splits all commands in two groups -- pre-init and post-init.\nPre-init commands are registered once the JTAG transport is selected.\nPost-ini commands become registered after the JTAG state is reset in\n`jtag_init()`.\n\nChange-Id: I21a1877e1eb3cfa59a43129216117ac397d09b95\nSigned-off-by: Evgeniy Naydanov \u003ceugnay@gmail.com\u003e\n"}},"b0fa531fb4e874c564acd287c7f3d05d10b76b73":{"kind":"REWORK","_number":2,"created":"2026-05-20 15:39:04.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/65/9665/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/9665/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/2 \u0026\u0026 git checkout -b change-9665 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/9665/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d84c45465bf3ba1dab330c0b9c29a531c7cd6588","subject":"src: jtag: cleanup `pathmove` command"}],"author":{"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","date":"2026-03-23 12:06:22.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","date":"2026-05-20 15:38:30.000000000","tz":180},"subject":"jtag: fix behavior of Tcl commands before init","message":"jtag: fix behavior of Tcl commands before init\n\nRunning\n```\nopenocd -c \u0027adapter driver dummy\u0027 -c \u0027jtag arp_init\u0027\n```\nused to result in an assertion failure:\n```\n...\nopenocd: ../../src/jtag/core.c:350: jtag_checks: Assertion `jtag_trst \u003d\u003d 0\u0027 failed.\n```\nThis is due to the fact that `jtag init` was not called and therefore\n`jtaf_init()` has not called `jtag_add_reset()`, so that `jtag_trst \u003d\u003d\n-1`.\n\nSimilar issues can be observed for other JTAG commands.\n\nThis patch splits all commands in two groups -- pre-init and post-init.\nPre-init commands are registered once the JTAG transport is selected.\nPost-ini commands become registered after the JTAG state is reset in\n`jtag_init()`.\n\nChange-Id: I21a1877e1eb3cfa59a43129216117ac397d09b95\nSigned-off-by: Evgeniy Naydanov \u003ceugnay@gmail.com\u003e\n"}},"0a6ae573c5a9dee840934a5326f836a543ca09f7":{"kind":"REWORK","_number":1,"created":"2026-05-19 08:55:47.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/65/9665/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/9665/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/1 \u0026\u0026 git checkout -b change-9665 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/9665/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/9665/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"76c5afb0393379b0536b06d17e2cf2d56166aaba","subject":"src: jtag: cleanup `pathmove` command"}],"author":{"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","date":"2026-03-23 12:06:22.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","date":"2026-05-19 08:55:05.000000000","tz":180},"subject":"jtag: fix behavior of Tcl commands before init","message":"jtag: fix behavior of Tcl commands before init\n\nRunning\n```\nopenocd -c \u0027adapter driver dummy\u0027 -c \u0027jtag arp_init\u0027\n```\nused to result in an assertion failure:\n```\n...\nopenocd: ../../src/jtag/core.c:350: jtag_checks: Assertion `jtag_trst \u003d\u003d 0\u0027 failed.\n```\nThis is due to the fact that `jtag init` was not called and therefore\n`jtaf_init()` has not called `jtag_add_reset()`, so that `jtag_trst \u003d\u003d\n-1`.\n\nSimilar issues can be observed for other JTAG commands.\n\nThis patch splits all commands in two groups -- pre-init and post-init.\nPre-init commands are registered once the JTAG transport is selected.\nPost-ini commands become registered after the JTAG state is reset in\n`jtag_init()`.\n\nChange-Id: I21a1877e1eb3cfa59a43129216117ac397d09b95\nSigned-off-by: Evgeniy Naydanov \u003ceugnay@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}
