)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b219460be9cd071574e4cffb27cce38d3a61ffe0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fb20cd4b_4e9a89c4","updated":"2026-06-25 16:41:44.000000000","message":"Thanks for this patch.\nI just run a light review as I\u0027m not expert on these devices.\nAdded Tarek and Ahmed for further review.","commit_id":"dce262945c0ff028e1f107d1cdabf98d3d1debe6"},{"author":{"_account_id":1002451,"name":"Tobias Schifferer","display_name":"Tobias Schifferer","email":"ts@auvidea.eu","username":"tobias_schifferer"},"change_message_id":"351a299d80d76913f2908d6489840227c48dd94f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f1b35a2a_b0618290","updated":"2026-06-26 07:30:18.000000000","message":"Thanks for taking the time to take a look at it. \n\nI used the following documentations as reference for this patch.\n\nAs reference for `BFB2` bit: [stm32f10xxx-xldensity](https://www.st.com/resource/en/programming_manual/pm0068-stm32f10xxx-xldensity-flash-programming-stmicroelectronics.pdf)\n\nFor `BOOT_SEL` related bits: [stm32f030x4x6x8xc and stm32f070x6xb](https://www.st.com/resource/en/reference_manual/rm0360-stm32f030x4x6x8xc-and-stm32f070x6xb-advanced-armbased-32bit-mcus-stmicroelectronics.pdf)\n\n\n| nBOOT1 bit | nBOOT0 bit | BOOT0 pin | BOOT_SEL bit | Mode              |\n| :--------: | :--------: | :-------: | :----------: | ----------------- |\n|     x      |     x      |     0     |      1       | Main flash memory |\n|     1      |     x      |     1     |      1       | System memory     |\n|     0      |     x      |     1     |      1       | Embedded SRAM     |\n|     x      |     1      |     x     |      0       | Main flash memory |\n|     1      |     0      |     x     |      0       | System memory     |\n|     0      |     0      |     x     |      0       | Embedded SRAM     |","commit_id":"b4b8ba37983f18e949892f6f28ad2dbc1ea8df4f"}],"src/flash/nor/stm32f1x.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b219460be9cd071574e4cffb27cce38d3a61ffe0","unresolved":true,"context_lines":[{"line_number":95,"context_line":"#define OB_RDP_NRST_STOP\t\t1"},{"line_number":96,"context_line":"#define OB_RDP_NRST_STDBY\t\t2"},{"line_number":97,"context_line":"#define OB_RDP_NBOOT1\t\t\t4"},{"line_number":98,"context_line":"#define OB_RDP_NBOOT0\t\t\t3 /* Only STM32F04x and STM32F09x */"},{"line_number":99,"context_line":"#define OB_RDP_VDDA_MONITOR\t\t5"},{"line_number":100,"context_line":"#define OB_RDP_RAM_PARITY_CHECK\t6"},{"line_number":101,"context_line":"#define OB_RDP_BOOT_SEL\t\t\t7 /* Only STM32F04x and STM32F09x */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"13eca26c_110b7d72","line":98,"updated":"2026-06-25 16:41:44.000000000","message":"Please keep the numeric order, that is `OB_RDP_NBOOT0` before `OB_RDP_NBOOT1`","commit_id":"dce262945c0ff028e1f107d1cdabf98d3d1debe6"},{"author":{"_account_id":1002451,"name":"Tobias Schifferer","display_name":"Tobias Schifferer","email":"ts@auvidea.eu","username":"tobias_schifferer"},"change_message_id":"351a299d80d76913f2908d6489840227c48dd94f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"#define OB_RDP_NRST_STOP\t\t1"},{"line_number":96,"context_line":"#define OB_RDP_NRST_STDBY\t\t2"},{"line_number":97,"context_line":"#define OB_RDP_NBOOT1\t\t\t4"},{"line_number":98,"context_line":"#define OB_RDP_NBOOT0\t\t\t3 /* Only STM32F04x and STM32F09x */"},{"line_number":99,"context_line":"#define OB_RDP_VDDA_MONITOR\t\t5"},{"line_number":100,"context_line":"#define OB_RDP_RAM_PARITY_CHECK\t6"},{"line_number":101,"context_line":"#define OB_RDP_BOOT_SEL\t\t\t7 /* Only STM32F04x and STM32F09x */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"09862c9f_c06dc464","line":98,"in_reply_to":"13eca26c_110b7d72","updated":"2026-06-26 07:30:18.000000000","message":"Done","commit_id":"dce262945c0ff028e1f107d1cdabf98d3d1debe6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b219460be9cd071574e4cffb27cce38d3a61ffe0","unresolved":true,"context_lines":[{"line_number":1583,"context_line":"\t\t\t\tCMD_ARGV++;"},{"line_number":1584,"context_line":"\t\t\t}"},{"line_number":1585,"context_line":"\t\t} else if (stm32x_info-\u003ehas_dual_banks) {"},{"line_number":1586,"context_line":"\t\t\tif (strcmp(\"BOOT0\", CMD_ARGV[0]) \u003d\u003d 0)"},{"line_number":1587,"context_line":"\t\t\t\toptionbyte |\u003d (1 \u003c\u003c OB_RDP_NBOOT0);"},{"line_number":1588,"context_line":"\t\t\telse if (strcmp(\"BOOT1\", CMD_ARGV[0]) \u003d\u003d 0)"},{"line_number":1589,"context_line":"\t\t\t\toptionbyte \u0026\u003d ~(1 \u003c\u003c OB_RDP_NBOOT0);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"00650db5_ef745d67","line":1586,"updated":"2026-06-25 16:41:44.000000000","message":"This argument `BOOT0` and the next one `BOOT1` are missing in the documentation and in the `.usage` below.\nWould you mind adding them either in this same patch or in a separate one, as you prefer?","commit_id":"dce262945c0ff028e1f107d1cdabf98d3d1debe6"},{"author":{"_account_id":1002451,"name":"Tobias Schifferer","display_name":"Tobias Schifferer","email":"ts@auvidea.eu","username":"tobias_schifferer"},"change_message_id":"351a299d80d76913f2908d6489840227c48dd94f","unresolved":true,"context_lines":[{"line_number":1583,"context_line":"\t\t\t\tCMD_ARGV++;"},{"line_number":1584,"context_line":"\t\t\t}"},{"line_number":1585,"context_line":"\t\t} else if (stm32x_info-\u003ehas_dual_banks) {"},{"line_number":1586,"context_line":"\t\t\tif (strcmp(\"BOOT0\", CMD_ARGV[0]) \u003d\u003d 0)"},{"line_number":1587,"context_line":"\t\t\t\toptionbyte |\u003d (1 \u003c\u003c OB_RDP_NBOOT0);"},{"line_number":1588,"context_line":"\t\t\telse if (strcmp(\"BOOT1\", CMD_ARGV[0]) \u003d\u003d 0)"},{"line_number":1589,"context_line":"\t\t\t\toptionbyte \u0026\u003d ~(1 \u003c\u003c OB_RDP_NBOOT0);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"3b21b359_99769b5c","line":1586,"in_reply_to":"00650db5_ef745d67","updated":"2026-06-26 07:30:18.000000000","message":"Should I add some more information about `BOOT_SEL` and `BOOT0`/`BOOT1` to the documentation, since this is very device specific and only applies to a few MCUs?","commit_id":"dce262945c0ff028e1f107d1cdabf98d3d1debe6"}]}