)]}'
{"id":"openocd~master~Ic98eaf7e1099ce4156cc8cabf0c26dcce392d605","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002519":{"account":{"_account_id":1002519,"name":"Jia Han Liu","display_name":"Jonah Liu","email":"liujiahan@gmail.com","username":"liujiahan"},"last_update":"2026-06-09 14:45:11.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic98eaf7e1099ce4156cc8cabf0c26dcce392d605","subject":"drivers/ch347: add explicit set_configuration before claim_interface","status":"MERGED","created":"2026-05-25 06:17:57.000000000","updated":"2026-06-09 14:45:11.000000000","submitted":"2026-06-09 14:45:11.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9718","meta_rev_id":"4714a2a5dd516852ffa8fe77d62ecd304d085ac0","_number":9718,"owner":{"_account_id":1002519,"name":"Jia Han Liu","display_name":"Jonah Liu","email":"liujiahan@gmail.com","username":"liujiahan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-06-09 14:45:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-06-09 14:45:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-06-09 14:45:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-25 06:18:12.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-05-25 06:39:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-05-29 19:37:29.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2026-06-09 14:45:07.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"71b9f597e683ab9ceb3a0174a5bd64f6f6ce97dc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002519,"name":"Jia Han Liu","display_name":"Jonah Liu","email":"liujiahan@gmail.com","username":"liujiahan"},"real_author":{"_account_id":1002519,"name":"Jia Han Liu","display_name":"Jonah Liu","email":"liujiahan@gmail.com","username":"liujiahan"},"date":"2026-05-25 06:17:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"408c94dc6be3e528e87cd642abe1611ae92a28b0","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-05-25 06:39:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22396/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23296/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"68958116b42d68f24ec93ed44a4fdab8c65176f3","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2026-05-29 19:37:29.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e737902a6ee1b3acaa84dfc3e23ec9b1529570d1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-06-09 14:45:07.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4714a2a5dd516852ffa8fe77d62ecd304d085ac0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-06-09 14:45:11.000000000","message":"Change has been successfully cherry-picked as b8ba9c724122626023bb864e33eedb5414b8765b","accounts_in_message":[],"_revision_number":2}],"current_revision":"b8ba9c724122626023bb864e33eedb5414b8765b","revisions":{"b8ba9c724122626023bb864e33eedb5414b8765b":{"kind":"REWORK","_number":2,"created":"2026-06-09 14:45:11.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/18/9718/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/9718/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/9718/2 \u0026\u0026 git checkout -b change-9718 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/9718/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/9718/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/9718/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/9718/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/9718/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1cce4ab89b80a96c227cd7b50aeeaf7215b8dbb7","subject":"tcl/target: Add max32650.cfg"}],"author":{"name":"Jonah Liu","email":"liujiahan@gmail.com","date":"2026-05-14 06:12:50.000000000","tz":0},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-06-09 14:45:11.000000000","tz":0},"subject":"drivers/ch347: add explicit set_configuration before claim_interface","message":"drivers/ch347: add explicit set_configuration before claim_interface\n\nOn some ARM64 platforms (e.g., NVIDIA Jetson with xhci_hcd), libusb\nreturns LIBUSB_ERROR_NOT_FOUND when attempting to claim the JTAG\ninterface immediately after libusb_open(). This happens because the\ndevice remains in the \"Addressed\" state and the host controller\nrequires an explicit SET_CONFIGURATION before interface resources\nare allocated.\n\nThe CH347F is a single-configuration composite device with\nbConfigurationValue \u003d\u003d 1. Adding libusb_set_configuration(1) before\nthe claim loop makes the driver behave consistently across x86_64\nand ARM64 without affecting existing functionality.\n\nTested on:\n- x86_64 (Ubuntu 24.04.4, kernel 6.17.0-23-generic) - regression verified\n- aarch64 (Jetson, Ubuntu 22.04.4, kernel 5.15.136-tegra) - previously\n  failed, now passes JTAG scan_chain successfully\n\nChange-Id: Ic98eaf7e1099ce4156cc8cabf0c26dcce392d605\nSigned-off-by: Jonah Liu \u003cliujiahan@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9718\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"5985da2552426138041f2c4fb62ac34f7561b4bd":{"kind":"REWORK","_number":1,"created":"2026-05-25 06:17:57.000000000","uploader":{"_account_id":1002519,"name":"Jia Han Liu","display_name":"Jonah Liu","email":"liujiahan@gmail.com","username":"liujiahan"},"ref":"refs/changes/18/9718/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/9718/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/9718/1 \u0026\u0026 git checkout -b change-9718 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/9718/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/9718/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/9718/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/9718/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/9718/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dc803e74be21678b8e867cb01609ed59a446ec09","subject":"tcl/target: Fix max32625 support"}],"author":{"name":"Jonah Liu","email":"liujiahan@gmail.com","date":"2026-05-14 06:12:50.000000000","tz":0},"committer":{"name":"Jonah Liu","email":"liujiahan@gmail.com","date":"2026-05-25 06:11:26.000000000","tz":480},"subject":"drivers/ch347: add explicit set_configuration before claim_interface","message":"drivers/ch347: add explicit set_configuration before claim_interface\n\nOn some ARM64 platforms (e.g., NVIDIA Jetson with xhci_hcd), libusb\nreturns LIBUSB_ERROR_NOT_FOUND when attempting to claim the JTAG\ninterface immediately after libusb_open(). This happens because the\ndevice remains in the \"Addressed\" state and the host controller\nrequires an explicit SET_CONFIGURATION before interface resources\nare allocated.\n\nThe CH347F is a single-configuration composite device with\nbConfigurationValue \u003d\u003d 1. Adding libusb_set_configuration(1) before\nthe claim loop makes the driver behave consistently across x86_64\nand ARM64 without affecting existing functionality.\n\nTested on:\n- x86_64 (Ubuntu 24.04.4, kernel 6.17.0-23-generic) - regression verified\n- aarch64 (Jetson, Ubuntu 22.04.4, kernel 5.15.136-tegra) - previously\n  failed, now passes JTAG scan_chain successfully\n\nChange-Id: Ic98eaf7e1099ce4156cc8cabf0c26dcce392d605\nSigned-off-by: Jonah Liu \u003cliujiahan@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}