)]}'
{"id":"openocd~master~I6080adac87132f642a7c15d93f1492b21c3eef73","project":"openocd","branch":"master","hashtags":[],"change_id":"I6080adac87132f642a7c15d93f1492b21c3eef73","subject":"building: Fixed strchr uses with const char*","status":"ABANDONED","created":"2026-05-28 10:10:12.000000000","updated":"2026-05-28 10:17:21.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bc010e3df99ae8d6a1bf548e3b39644c13388ad8","_number":9719,"owner":{"_account_id":1002524,"name":"Aurore Poirier","email":"aurore.poirier@scisemi.com","username":"aurore-poirier"},"actions":{},"labels":{"Verified":{"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-28 10:17:21.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"8931dce3aeac7a5a7fce6889b27ee4c1b2caa575","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002524,"name":"Aurore Poirier","email":"aurore.poirier@scisemi.com","username":"aurore-poirier"},"real_author":{"_account_id":1002524,"name":"Aurore Poirier","email":"aurore.poirier@scisemi.com","username":"aurore-poirier"},"date":"2026-05-28 10:10:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"de071dc3d4b5d0bbd7388a4f5bc3b3921e05cc1a","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1002524,"name":"Aurore Poirier","email":"aurore.poirier@scisemi.com","username":"aurore-poirier"},"real_author":{"_account_id":1002524,"name":"Aurore Poirier","email":"aurore.poirier@scisemi.com","username":"aurore-poirier"},"date":"2026-05-28 10:12:32.000000000","message":"Abandoned\n\nJust saw this is a duplicate of 9529","accounts_in_message":[],"_revision_number":1}],"current_revision":"dd17354a250626967fe422d056cf23d5a3c9c314","revisions":{"dd17354a250626967fe422d056cf23d5a3c9c314":{"kind":"REWORK","_number":1,"created":"2026-05-28 10:10:12.000000000","uploader":{"_account_id":1002524,"name":"Aurore Poirier","email":"aurore.poirier@scisemi.com","username":"aurore-poirier"},"ref":"refs/changes/19/9719/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/9719/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/9719/1 \u0026\u0026 git checkout -b change-9719 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/9719/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/9719/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/9719/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/9719/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/9719/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f92f577cc0dcc14c63ff31fd7bd5144b3120443b","subject":"jtag/core: fix blocked polling in unknown state of jtag_xrst"}],"author":{"name":"Aurore Poirier","email":"aurore.poirier@scisemi.com","date":"2026-05-20 08:25:18.000000000","tz":120},"committer":{"name":"Aurore Poirier","email":"aurore.poirier@scisemi.com","date":"2026-05-28 10:04:48.000000000","tz":120},"subject":"building: Fixed strchr uses with const char*","message":"building: Fixed strchr uses with const char*\n\nBoth gcc 16.1.1 and clang 22.1.5 were raising an error when compiling\n(respectively `-Wdiscarded-qualifiers` and\n`-Wincompatible-pointer-types-discards-qualifiers`) because of the way\nstrchr used to work, even with `-std\u003dgun99`. This commit fixes this\ncompilation error and should allow compiling OpenOCD with more recent\ncompilers, and possibly in C23.\n\nChange-Id: I6080adac87132f642a7c15d93f1492b21c3eef73\nSigned-off-by: Aurore Poirier \u003caurore.poirier@scisemi.com\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}