)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"91a3572e4e24a0c0e34814cc7b31947b4af70942","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a83a2a35_fbac2884","updated":"2026-05-28 13:30:02.000000000","message":"It was suggested to return an error in this case. See [1].\nI don\u0027t think this is right -- we report error when OpenOCD fails.. If something fails in hardware this is not an error in OpenOCD, but rather a major usecase of OpenOCD.\n\n1: https://github.com/riscv-collab/riscv-openocd/pull/1268","commit_id":"5939cf4c84a3776f38f106b14ee6c7f8a9e7c794"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"5ed0adf9cb6ec33b361c17275ce206364bdf33e5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c72951c9_872c2508","in_reply_to":"a83a2a35_fbac2884","updated":"2026-05-28 13:55:40.000000000","message":"Hi Evgeniy,\n\nthanks for re-submitting the patch here.\n\nAs for the error reporting: I would still prefer to emit an error since the user\u0027s high-level request to read a value of a register could not be successfully performed, and whatever value we got cannot be relied on. My point is that this issue should not go unnoticed.\n\nIf anyone wants to use OpenOCD for lower-level testing and troubleshooting of the hardware itself, then sequences of lower-level commands should be used (`riscv dm_read|dm_write`) that don\u0027t try to be clever, don\u0027t perform higher-level error checking and give the user full control.\n\nDoes that sound reasonable?","commit_id":"5939cf4c84a3776f38f106b14ee6c7f8a9e7c794"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"f594c03d60d7af8871fa70cf9eb930956558df35","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ebd202e2_15468176","in_reply_to":"c72951c9_872c2508","updated":"2026-05-29 11:13:20.000000000","message":"Ok. I don\u0027t think this is that important -- let\u0027s error-out instead.\nChanged the error message according to comments from [1] and added \"Discarding the value\" to make the behavior more verbose.","commit_id":"5939cf4c84a3776f38f106b14ee6c7f8a9e7c794"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"ce24085604c7751973a552be495889e888e9f456","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84c58d9c_8e4ccbf3","in_reply_to":"ebd202e2_15468176","updated":"2026-05-29 11:21:38.000000000","message":"Ack","commit_id":"5939cf4c84a3776f38f106b14ee6c7f8a9e7c794"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"57e1515533428cef1f826a45dca8b5b50d57e612","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"89ff5c63_5c8075b5","updated":"2026-05-29 11:21:06.000000000","message":"Checked visually and LGTM. Thank you.","commit_id":"31b07b9a9415c419e96baf4e9a6dbe2eb5992f3a"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"74cde4b8e7668ca4adb0882981c80057229785d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc39c747_4842e023","in_reply_to":"89ff5c63_5c8075b5","updated":"2026-05-29 11:21:19.000000000","message":"Done","commit_id":"31b07b9a9415c419e96baf4e9a6dbe2eb5992f3a"}]}
