)]}'
{"id":"openocd~master~I46c659f00039b2161cf3fc2e9473f998ab63ed92","project":"openocd","branch":"master","hashtags":[],"change_id":"I46c659f00039b2161cf3fc2e9473f998ab63ed92","subject":"tree-wide: fix compilation with modern glibc","status":"ABANDONED","created":"2026-05-28 16:25:27.000000000","updated":"2026-05-28 16:27:24.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a2fcfb0e33f6dabfec78d5f3990cb1eda87207eb","_number":9721,"owner":{"_account_id":1002022,"name":"Marian Buschsieweke","display_name":"maribu","email":"marian.buschsieweke@ovgu.de","username":"maribu"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":1002022,"name":"Marian Buschsieweke","display_name":"maribu","email":"marian.buschsieweke@ovgu.de","username":"maribu"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"disliked":{"_account_id":1002022,"name":"Marian Buschsieweke","display_name":"maribu","email":"marian.buschsieweke@ovgu.de","username":"maribu"},"all":[{"value":-1,"date":"2026-05-28 16:27:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1002022,"name":"Marian Buschsieweke","display_name":"maribu","email":"marian.buschsieweke@ovgu.de","username":"maribu"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1002022,"name":"Marian Buschsieweke","display_name":"maribu","email":"marian.buschsieweke@ovgu.de","username":"maribu"}],"CC":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-05-28 16:25:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"9f60bbf8a2ca3898da93b3005ea5231cfd8ab7fc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002022,"name":"Marian Buschsieweke","display_name":"maribu","email":"marian.buschsieweke@ovgu.de","username":"maribu"},"real_author":{"_account_id":1002022,"name":"Marian Buschsieweke","display_name":"maribu","email":"marian.buschsieweke@ovgu.de","username":"maribu"},"date":"2026-05-28 16:25:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"62b3ee266fa5c87150d22f27fb3272a2045771da","author":{"_account_id":1002022,"name":"Marian Buschsieweke","display_name":"maribu","email":"marian.buschsieweke@ovgu.de","username":"maribu"},"real_author":{"_account_id":1002022,"name":"Marian Buschsieweke","display_name":"maribu","email":"marian.buschsieweke@ovgu.de","username":"maribu"},"date":"2026-05-28 16:27:07.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a2fcfb0e33f6dabfec78d5f3990cb1eda87207eb","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1002022,"name":"Marian Buschsieweke","display_name":"maribu","email":"marian.buschsieweke@ovgu.de","username":"maribu"},"real_author":{"_account_id":1002022,"name":"Marian Buschsieweke","display_name":"maribu","email":"marian.buschsieweke@ovgu.de","username":"maribu"},"date":"2026-05-28 16:27:24.000000000","message":"Abandoned\n\nClosing in favor of https://review.openocd.org/c/openocd/+/9529","accounts_in_message":[],"_revision_number":1}],"current_revision":"dc4bd94ea8b2a6569e6a4d0689543ff48b03414b","revisions":{"dc4bd94ea8b2a6569e6a4d0689543ff48b03414b":{"kind":"REWORK","_number":1,"created":"2026-05-28 16:25:27.000000000","uploader":{"_account_id":1002022,"name":"Marian Buschsieweke","display_name":"maribu","email":"marian.buschsieweke@ovgu.de","username":"maribu"},"ref":"refs/changes/21/9721/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/21/9721/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/21/9721/1 \u0026\u0026 git checkout -b change-9721 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/21/9721/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/21/9721/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/21/9721/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/21/9721/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/21/9721/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f92f577cc0dcc14c63ff31fd7bd5144b3120443b","subject":"jtag/core: fix blocked polling in unknown state of jtag_xrst"}],"author":{"name":"Marian Buschsieweke","email":"marian.buschsieweke@posteo.net","date":"2026-05-28 16:08:57.000000000","tz":120},"committer":{"name":"Marian Buschsieweke","email":"marian.buschsieweke@posteo.net","date":"2026-05-28 16:21:07.000000000","tz":120},"subject":"tree-wide: fix compilation with modern glibc","message":"tree-wide: fix compilation with modern glibc\n\nRecently glibc added some clever macro trickery with the effect that\n\n\tchar *strchr(const char *s, int c);\n\nbehaves now, depending on the `const`ness of the first argument, as\neither:\n\n\tconst char *strchr(const char *s, int c);\n\nor:\n\n\tchar *strchr(char *s, int c);\n\nThe intend is that one does not accidentally turn a `const char *` into\na `char *`. This change results in compilations errors such as:\n\n\tsrc/helper/options.c: In function ‘find_relative_path’:\n\tsrc/helper/options.c:154:30: error: initialization discards ‘const’ qualifier from pointer target type [-Werror\u003ddiscarded-qualifiers]\n\t  154 |                 char *next \u003d strchr(from, \u0027/\u0027);\n\t      |                              ^~~~~~\n\nThis commit fixes these compilation errors. In most cases just adding\na `const` the variable storing the return value was sufficient. In once\ncase, modifying the `CMD_ARGV[0]` in-place to split host and port\n(separated by `:`) was changed by instead just copying up to the `:`\ninstead.\n\nChange-Id: I46c659f00039b2161cf3fc2e9473f998ab63ed92\nSigned-off-by: Marian Buschsieweke \u003cmarian.buschsieweke@posteo.net\u003e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}