)]}'
{"id":"openocd~master~Id033101f9caf51f87622e872234b8520bf31d9f0","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2026-06-09 14:40:27.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id033101f9caf51f87622e872234b8520bf31d9f0","subject":"flash/nor/tcl: Remove unused variable","status":"MERGED","created":"2026-06-03 14:09:36.000000000","updated":"2026-06-09 14:40:27.000000000","submitted":"2026-06-09 14:40:27.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9728","meta_rev_id":"9876247077955b0d181aaa4d8889f5168d3d877d","_number":9728,"owner":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-06-09 14:40:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-06-09 14:40:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-03 14:17:31.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-06-03 14:44:40.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-06-03 14:56:41.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"37576d51e28441fccc5d1c7cdc438a88af0dd4e8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-06-03 14:09:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"125992ff15466c6e7dee9554e70cf963b623e484","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-06-03 14:44:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22437/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23337/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5c4a80da3243612b5557acf6b752908b4fbdfd10","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-06-03 14:56:41.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9876247077955b0d181aaa4d8889f5168d3d877d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-06-09 14:40:27.000000000","message":"Change has been successfully cherry-picked as f2fba27a8807f6684cd8dd7e47f27009ee00fa1b","accounts_in_message":[],"_revision_number":2}],"current_revision":"f2fba27a8807f6684cd8dd7e47f27009ee00fa1b","revisions":{"01b0428db8f2dfd6ec05339cd2a1139db57f1c6f":{"kind":"REWORK","_number":1,"created":"2026-06-03 14:09:36.000000000","uploader":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"ref":"refs/changes/28/9728/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/9728/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/9728/1 \u0026\u0026 git checkout -b change-9728 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/9728/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/9728/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/9728/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/9728/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/9728/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e6752ecbcf72efe4e213e8418e381ff2e0ffdf54","subject":"jep106: update to revision JEP106BO May 2026"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-06-03 14:04:43.000000000","tz":120},"committer":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-06-03 14:08:13.000000000","tz":120},"subject":"flash/nor/tcl: Remove unused variable","message":"flash/nor/tcl: Remove unused variable\n\nRemove the unused variable. This additionally fixes the following build\nissue:\n\n../src/flash/nor/tcl.c: In function \u0027handle_flash_banks_command\u0027:\n../src/flash/nor/tcl.c:1445:22: error: variable \u0027n\u0027 set but not used [-Werror\u003dunused-but-set-variable\u003d]\n 1445 |         unsigned int n \u003d 0;\n      |\n\nTested with GCC 16.1.1\n\nChange-Id: Id033101f9caf51f87622e872234b8520bf31d9f0\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\n"}},"f2fba27a8807f6684cd8dd7e47f27009ee00fa1b":{"kind":"REWORK","_number":2,"created":"2026-06-09 14:40:27.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/28/9728/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/28/9728/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/28/9728/2 \u0026\u0026 git checkout -b change-9728 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/28/9728/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/28/9728/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/28/9728/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/28/9728/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/28/9728/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d99e54eb09b69d882d729d558b52cb3551d25f7","subject":"target: add poll_interval command support"}],"author":{"name":"Marc Schink","email":"dev@zapb.de","date":"2026-06-03 14:04:43.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-06-09 14:40:27.000000000","tz":0},"subject":"flash/nor/tcl: Remove unused variable","message":"flash/nor/tcl: Remove unused variable\n\nRemove the unused variable. This additionally fixes the following build\nissue:\n\n../src/flash/nor/tcl.c: In function \u0027handle_flash_banks_command\u0027:\n../src/flash/nor/tcl.c:1445:22: error: variable \u0027n\u0027 set but not used [-Werror\u003dunused-but-set-variable\u003d]\n 1445 |         unsigned int n \u003d 0;\n      |\n\nTested with GCC 16.1.1\n\nChange-Id: Id033101f9caf51f87622e872234b8520bf31d9f0\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9728\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
