)]}'
{"id":"openocd~master~I886e8bb4cc0433ec045bfd57f78ceef843d8f774","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2026-06-21 18:40:44.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I886e8bb4cc0433ec045bfd57f78ceef843d8f774","subject":"target: improve SMP target list management in `target smp`","status":"MERGED","created":"2026-06-04 11:51:23.000000000","updated":"2026-06-21 18:40:44.000000000","submitted":"2026-06-21 18:40:44.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9729","meta_rev_id":"b3d30af9bcc7ab357f7e9a0d2939ea04de300bc8","_number":9729,"owner":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-06-21 18:40:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-06-21 18:40:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-04 11:51:36.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-06-08 11:49:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2026-06-21 18:24:53.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d8c4ebab39fd8609bf59a3aa5fb9327bea9b90e2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2026-06-04 11:51:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a32d33ec6d0bfea80c5b8f520970c1c37cbebd2e","author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"real_author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"date":"2026-06-04 11:58:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0d361de1da4c6a111bc29854a180a6a889e674d4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-06-08 11:49:54.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4131ccd47eaf9f163d716f4540210b5641c9d6fb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-06-21 17:52:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4f0d80cd067b84acd2e412dddb392a55bfa273b7","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-06-21 18:24:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22529/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23429/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b3d30af9bcc7ab357f7e9a0d2939ea04de300bc8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-06-21 18:40:44.000000000","message":"Change has been successfully cherry-picked as 2c1fd8a13545e0b1e5dd225730dc10579106751d","accounts_in_message":[],"_revision_number":2}],"current_revision":"2c1fd8a13545e0b1e5dd225730dc10579106751d","revisions":{"2c1fd8a13545e0b1e5dd225730dc10579106751d":{"kind":"REWORK","_number":2,"created":"2026-06-21 18:40:44.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/29/9729/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/9729/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/9729/2 \u0026\u0026 git checkout -b change-9729 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/9729/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/9729/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/9729/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/9729/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/9729/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"25c6ac85cdeec5104e66dcd7bca2f62177fdaf01","subject":"target: riscv: error-out instead of truncating register values"}],"author":{"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","date":"2025-09-23 10:06:09.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-06-21 18:40:44.000000000","tz":0},"subject":"target: improve SMP target list management in `target smp`","message":"target: improve SMP target list management in `target smp`\n\nBefore the patch updating the SMP target list could result in a\nuse-after-free:\n```\n\u003e valgrind openocd \\\n\t-c \u0027adapter driver dummy\u0027 \\\n\t-c \u0027proc jtag_init {} {}\u0027 \\\n\t-c \u0027jtag newtap tap0 cpu -irlen 2\u0027 \\\n\t-c \u0027target create t0 testee -chain-position tap0.cpu\u0027 \\\n\t-c \u0027target create t1 testee -chain-position tap0.cpu\u0027 \\\n\t-c \u0027target smp t0 t1\u0027 \\\n\t-c \u0027target smp t0\u0027 \\\n\t-c shutdown\n...\n\u003d\u003d Invalid read of size 8\n\u003d\u003d    at 0x4274D16: breakpoint_remove_all_internal (breakpoints.c:330)\n...\n\u003d\u003d    by 0x410EA21: target_quit (target.c:2261)\n...\n\u003d\u003d  Address 0x5380248 is 136 bytes inside a block of size 312 free\u0027d\n...\n\u003d\u003d    by 0x410EA21: target_quit (target.c:2261)\n...\n\u003d\u003d Invalid read of size 8\n\u003d\u003d    at 0x42750B3: watchpoint_remove_all_internal (breakpoints.c:415)\n...\n\u003d\u003d    by 0x410EA21: target_quit (target.c:2261)\n...\n\u003d\u003d  Address 0x5380250 is 144 bytes inside a block of size 312 free\u0027d\n...\n\u003d\u003d    by 0x410EA21: target_quit (target.c:2261)\n...\n\u003d\u003d Invalid write of size 4\n\u003d\u003d    at 0x410E880: target_destroy (target.c:2221)\n...\n\u003d\u003d  Address 0x53802bc is 252 bytes inside a block of size 312 free\u0027d\n...\n\u003d\u003d    by 0x410EA21: target_quit (target.c:2261)\n...\n\u003d\u003d ERROR SUMMARY: 3 errors from 3 contexts (suppressed: 0 from 0)\n```\n\nChange-Id: I886e8bb4cc0433ec045bfd57f78ceef843d8f774\nSigned-off-by: Evgeniy Naydanov \u003ceugnay@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9729\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"c5849714fdfbcb8503ed52c1aa925fbd9b43c267":{"kind":"REWORK","_number":1,"created":"2026-06-04 11:51:23.000000000","uploader":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"ref":"refs/changes/29/9729/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/29/9729/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/29/9729/1 \u0026\u0026 git checkout -b change-9729 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/29/9729/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/29/9729/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/29/9729/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/29/9729/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/29/9729/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e6752ecbcf72efe4e213e8418e381ff2e0ffdf54","subject":"jep106: update to revision JEP106BO May 2026"}],"author":{"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","date":"2025-09-23 10:06:09.000000000","tz":180},"committer":{"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","date":"2026-06-01 14:06:14.000000000","tz":180},"subject":"target: improve SMP target list management in `target smp`","message":"target: improve SMP target list management in `target smp`\n\nBefore the patch updating the SMP target list could result in a\nuse-after-free:\n```\n\u003e valgrind openocd \\\n\t-c \u0027adapter driver dummy\u0027 \\\n\t-c \u0027proc jtag_init {} {}\u0027 \\\n\t-c \u0027jtag newtap tap0 cpu -irlen 2\u0027 \\\n\t-c \u0027target create t0 testee -chain-position tap0.cpu\u0027 \\\n\t-c \u0027target create t1 testee -chain-position tap0.cpu\u0027 \\\n\t-c \u0027target smp t0 t1\u0027 \\\n\t-c \u0027target smp t0\u0027 \\\n\t-c shutdown\n...\n\u003d\u003d Invalid read of size 8\n\u003d\u003d    at 0x4274D16: breakpoint_remove_all_internal (breakpoints.c:330)\n...\n\u003d\u003d    by 0x410EA21: target_quit (target.c:2261)\n...\n\u003d\u003d  Address 0x5380248 is 136 bytes inside a block of size 312 free\u0027d\n...\n\u003d\u003d    by 0x410EA21: target_quit (target.c:2261)\n...\n\u003d\u003d Invalid read of size 8\n\u003d\u003d    at 0x42750B3: watchpoint_remove_all_internal (breakpoints.c:415)\n...\n\u003d\u003d    by 0x410EA21: target_quit (target.c:2261)\n...\n\u003d\u003d  Address 0x5380250 is 144 bytes inside a block of size 312 free\u0027d\n...\n\u003d\u003d    by 0x410EA21: target_quit (target.c:2261)\n...\n\u003d\u003d Invalid write of size 4\n\u003d\u003d    at 0x410E880: target_destroy (target.c:2221)\n...\n\u003d\u003d  Address 0x53802bc is 252 bytes inside a block of size 312 free\u0027d\n...\n\u003d\u003d    by 0x410EA21: target_quit (target.c:2261)\n...\n\u003d\u003d ERROR SUMMARY: 3 errors from 3 contexts (suppressed: 0 from 0)\n```\n\nChange-Id: I886e8bb4cc0433ec045bfd57f78ceef843d8f774\nSigned-off-by: Evgeniy Naydanov \u003ceugnay@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}