)]}'
{"src/jtag/drivers/angie.c":[{"author":{"_account_id":1002528,"name":"Adrien Charruel","email":"adrien.charruel@gmail.com"},"change_message_id":"9d2cae6334bb1a016b3774bd40c033ff31d72637","unresolved":true,"context_lines":[{"line_number":870,"context_line":"\t\tangie_read_queue_add(\u0026device-\u003eread_queue, entry);"},{"line_number":871,"context_line":"\t}"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"\tfree(buffer);"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"\treturn ERROR_OK;"},{"line_number":876,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e02eb243_783de380","line":873,"updated":"2026-06-10 09:39:14.000000000","message":"Hi,\n\nWhile there was indeed some missing free() in the error path, this logic must be preserve.\n\nIn case the scan type is not SCAN_OUT, the buffer is stored in a list that is used later on. The entries and their related buffer are released later in angie_read_queue_execute().","commit_id":"2a2d66647b1d42ea9649bd7edd5e3e2d1e449276"},{"author":{"_account_id":1002528,"name":"Adrien Charruel","email":"adrien.charruel@gmail.com"},"change_message_id":"5e6548f360a12f781bfea15e7d6b09684c61fa2e","unresolved":false,"context_lines":[{"line_number":870,"context_line":"\t\tangie_read_queue_add(\u0026device-\u003eread_queue, entry);"},{"line_number":871,"context_line":"\t}"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"\tfree(buffer);"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"\treturn ERROR_OK;"},{"line_number":876,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c35444d9_8fd2f475","line":873,"in_reply_to":"21e4bba2_0ab958ee","updated":"2026-06-11 07:19:44.000000000","message":"Hi Marc,\n\nNo you are right, I signed in with my personal mail but I\u0027m indeed the NanoXplore guy that (re)wrote this driver. And I\u0027m still within the company.\n\nI\u0027ll talk to people here to see if we can arrange this but I can\u0027t promise anything.","commit_id":"2a2d66647b1d42ea9649bd7edd5e3e2d1e449276"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"9412de8f7cbb0947c30f64f5854de65ce4aa4627","unresolved":false,"context_lines":[{"line_number":870,"context_line":"\t\tangie_read_queue_add(\u0026device-\u003eread_queue, entry);"},{"line_number":871,"context_line":"\t}"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"\tfree(buffer);"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"\treturn ERROR_OK;"},{"line_number":876,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"21e4bba2_0ab958ee","line":873,"in_reply_to":"2cf13a25_f5cd1d3e","updated":"2026-06-10 19:33:03.000000000","message":"Ah, just noticed that I confused you with one of the NanoExplore guys :)","commit_id":"2a2d66647b1d42ea9649bd7edd5e3e2d1e449276"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2369affedaaa2871cd5d673e7a1e8233df9c4864","unresolved":false,"context_lines":[{"line_number":870,"context_line":"\t\tangie_read_queue_add(\u0026device-\u003eread_queue, entry);"},{"line_number":871,"context_line":"\t}"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"\tfree(buffer);"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"\treturn ERROR_OK;"},{"line_number":876,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c5af1458_43d19185","line":873,"in_reply_to":"c35444d9_8fd2f475","updated":"2026-06-11 08:03:08.000000000","message":"Hi Adrien,\nclearly, having access to Angie devices could help maintaining this driver.\n\nDo you agree on this new version of Marc\u0027s patch? It looks ok for me.","commit_id":"2a2d66647b1d42ea9649bd7edd5e3e2d1e449276"},{"author":{"_account_id":1002528,"name":"Adrien Charruel","email":"adrien.charruel@gmail.com"},"change_message_id":"8833bb5671f3138a9e3efcd898960f99b4850fb7","unresolved":false,"context_lines":[{"line_number":870,"context_line":"\t\tangie_read_queue_add(\u0026device-\u003eread_queue, entry);"},{"line_number":871,"context_line":"\t}"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"\tfree(buffer);"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"\treturn ERROR_OK;"},{"line_number":876,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"02f77bb4_ab60e616","line":873,"in_reply_to":"c5af1458_43d19185","updated":"2026-06-11 08:06:24.000000000","message":"Hi Antonio,\n\nI agree on both point, I\u0027ll raise this topic with my company, and the latest patch set looks good to me.\n\nThank you Marc.","commit_id":"2a2d66647b1d42ea9649bd7edd5e3e2d1e449276"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"9eba8004c26de4c939d3b8a3a7baf85e181229a2","unresolved":false,"context_lines":[{"line_number":870,"context_line":"\t\tangie_read_queue_add(\u0026device-\u003eread_queue, entry);"},{"line_number":871,"context_line":"\t}"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"\tfree(buffer);"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"\treturn ERROR_OK;"},{"line_number":876,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2cf13a25_f5cd1d3e","line":873,"in_reply_to":"e02eb243_783de380","updated":"2026-06-10 18:47:06.000000000","message":"Thanks Adrien! Btw, is there any chance to get one of these probes somehow? Would be nice for regression testing in the future.","commit_id":"2a2d66647b1d42ea9649bd7edd5e3e2d1e449276"}]}