)]}'
{"id":"openocd~master~Ic40923ef7d9ac5ca0ffb313c9d4fc6d1457d6bbb","project":"openocd","branch":"master","attention_set":{"1002371":{"account":{"_account_id":1002371,"name":"Farid Khaidari","email":"f.khaydari@syntacore.com","username":"fk-sc"},"last_update":"2026-06-12 13:36:07.000000000","reason":"Reviewer was added"},"1002047":{"account":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"last_update":"2026-06-12 13:38:20.000000000","reason":"\u003cGERRIT_ACCOUNT_1001667\u003e replied on the change","reason_account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ic40923ef7d9ac5ca0ffb313c9d4fc6d1457d6bbb","subject":"target/riscv: refactor scratch_reserve() - use standardized macros","status":"NEW","created":"2026-06-12 13:36:07.000000000","updated":"2026-06-14 13:53:51.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dbb03d5123589f4b8832268e8b089387fe800047","_number":9742,"owner":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"_account_id":1002371,"name":"Farid Khaidari","email":"f.khaydari@syntacore.com","username":"fk-sc"},{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-06-12 14:14:30.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"all":[{"value":1,"date":"2026-06-12 13:37:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1002371,"name":"Farid Khaidari","email":"f.khaydari@syntacore.com","username":"fk-sc"},{"value":1,"date":"2026-06-14 13:53:51.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},{"_account_id":1002371,"name":"Farid Khaidari","email":"f.khaydari@syntacore.com","username":"fk-sc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-12 13:36:07.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1002371,"name":"Farid Khaidari","email":"f.khaydari@syntacore.com","username":"fk-sc"},"state":"REVIEWER"},{"updated":"2026-06-12 13:38:20.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"state":"REVIEWER"},{"updated":"2026-06-12 13:51:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-06-12 14:14:30.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-06-14 13:53:51.000000000","updated_by":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"reviewer":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"state":"REVIEWER"}],"messages":[{"id":"11833cea1007e1a5288c3bfbd9f5a2b6ccb1a24c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2026-06-12 13:36:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e812aa1b29eeeb9c2cbb4020b6d574802de371ec","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2026-06-12 13:37:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6c421c54bc75b3bccc793413177da5862085a6db","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2026-06-12 13:37:49.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4432c7f21857d02e85c03f832e90b6f5b83385e5","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-06-12 14:14:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22480/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23380/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"dbb03d5123589f4b8832268e8b089387fe800047","author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"real_author":{"_account_id":1002135,"name":"Mark Zhuang","email":"mark.zhuang@spacemit.com","username":"zqb-all"},"date":"2026-06-14 13:53:51.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1}],"current_revision":"b8af092f20521e51872b9066813284a1d8d15c47","revisions":{"b8af092f20521e51872b9066813284a1d8d15c47":{"kind":"REWORK","_number":1,"created":"2026-06-12 13:36:07.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/42/9742/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/42/9742/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/42/9742/1 \u0026\u0026 git checkout -b change-9742 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/42/9742/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/42/9742/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/42/9742/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/42/9742/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/42/9742/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8630c34137d32eaabc4110224c180c754168a430","subject":"target/riscv: fix bug in scratch_reserve"}],"author":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2026-06-12 13:34:01.000000000","tz":120},"committer":{"name":"Jan Matyas","email":"jan.matyas@codasip.com","date":"2026-06-12 13:34:01.000000000","tz":120},"subject":"target/riscv: refactor scratch_reserve() - use standardized macros","message":"target/riscv: refactor scratch_reserve() - use standardized macros\n\nThe original author of this commit is Farid Khaidari, see [1].\n\nThis commit refactors the scratch_reserve()\n- Replacing hardcoded bit manipulation with BIT() macro\n- Using GENMASK_ULL() instead of hardcoded masks for sign extension\n- Applying ALIGN_UP() macro for address alignment calculations\n- Using DIV_ROUND_UP() instead of manual division with addition\n\n[1] https://github.com/riscv-collab/riscv-openocd/\n    commit/9d4c94e51fdaba3290a16825e48f393b9650a321\n\nChange-Id: Ic40923ef7d9ac5ca0ffb313c9d4fc6d1457d6bbb\nSigned-off-by: Farid Khaydari \u003cf.khaydari@syntacore.com\u003e\nSigned-off-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}