)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c6c07f118966f863aed8f05094c66da5d719f940","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"93fe05b8_5ed8ce7c","updated":"2026-06-22 16:10:52.000000000","message":"Thanks for this patch.\nWe really want to anticipate the changes in capstone v6; OpenOCD releases are not so frequent and we risk to get out of sync with external libraries.\nBut I prefer having in the `struct all_archs` a separate section per version of capstone.\nThis would simplify the support of future versions. And, hey, capstone v6 adds support for xtensa and arc architectures! Having a separate section makes trivial adding them, if someone is interested.\nMy preference is to not overwrite the macro definition as in this patch, but to have independent sections per capstone version","commit_id":"fa8e5941d0c5cfdf4ec0641ace142ccaa11671f1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4d4e9d1bc993b11f5685a7b728ef060a8d3360df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a27712f0_66e3f241","updated":"2026-06-23 10:41:59.000000000","message":"Thanks. It\u0027s now much easier to maintain it and to support new version of Capstone.","commit_id":"03f0234c6545181f48a020e6a8a6586e32c00c26"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"25f144519c4796c7bb9de07e91b0291debdaba4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"da7aa3b4_4d981c4f","updated":"2026-06-25 16:48:17.000000000","message":"Thanks!","commit_id":"3a85ca8545699d7475b2e311b5e8289619bbea18"}],"src/target/oocd_capstone.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c6c07f118966f863aed8f05094c66da5d719f940","unresolved":true,"context_lines":[{"line_number":37,"context_line":"\t{ \"cortexm\", CS_ARCH_ARM, CS_MODE_ARM | CS_MODE_THUMB | CS_MODE_MCLASS },"},{"line_number":38,"context_line":"\t{ \"thumb\", CS_ARCH_ARM, CS_MODE_ARM | CS_MODE_THUMB },"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#if CS_API_MAJOR \u003e\u003d 5"},{"line_number":41,"context_line":"\t{ \"riscv32\", CS_ARCH_RISCV, CS_MODE_RISCV32 | CS_MODE_RISCVC },"},{"line_number":42,"context_line":"\t{ \"riscv64\", CS_ARCH_RISCV, CS_MODE_RISCV64 | CS_MODE_RISCVC },"},{"line_number":43,"context_line":"#endif /* CS_API_MAJOR \u003e\u003d 5 */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6709b836_ed0f9fb5","line":40,"updated":"2026-06-22 16:10:52.000000000","message":"Change this as\n`#if CS_API_MAJOR \u003d 5`\nand also in the comment 3 lines below.\nAfter the `#endif` add\n`#if CS_API_MAJOR \u003d 6`\nwith the new lines for riscv","commit_id":"fa8e5941d0c5cfdf4ec0641ace142ccaa11671f1"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4d4e9d1bc993b11f5685a7b728ef060a8d3360df","unresolved":false,"context_lines":[{"line_number":37,"context_line":"\t{ \"cortexm\", CS_ARCH_ARM, CS_MODE_ARM | CS_MODE_THUMB | CS_MODE_MCLASS },"},{"line_number":38,"context_line":"\t{ \"thumb\", CS_ARCH_ARM, CS_MODE_ARM | CS_MODE_THUMB },"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#if CS_API_MAJOR \u003e\u003d 5"},{"line_number":41,"context_line":"\t{ \"riscv32\", CS_ARCH_RISCV, CS_MODE_RISCV32 | CS_MODE_RISCVC },"},{"line_number":42,"context_line":"\t{ \"riscv64\", CS_ARCH_RISCV, CS_MODE_RISCV64 | CS_MODE_RISCVC },"},{"line_number":43,"context_line":"#endif /* CS_API_MAJOR \u003e\u003d 5 */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3431fa7d_43fcb501","line":40,"in_reply_to":"6709b836_ed0f9fb5","updated":"2026-06-23 10:41:59.000000000","message":"Done","commit_id":"fa8e5941d0c5cfdf4ec0641ace142ccaa11671f1"},{"author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"change_message_id":"350797aab93a5af4097cb821e076710c9ae9aafe","unresolved":true,"context_lines":[{"line_number":42,"context_line":"#endif /* CS_API_MAJOR \u003c 6 */"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#if CS_API_MAJOR \u003e\u003d 6"},{"line_number":45,"context_line":"#ifndef CS_MODE_RISCV_C"},{"line_number":46,"context_line":"#define CS_MODE_RISCV_C CS_MODE_RISCVC"},{"line_number":47,"context_line":"#endif"},{"line_number":48,"context_line":"\t{ \"arm64\", CS_ARCH_AARCH64, CS_MODE_LITTLE_ENDIAN },"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"193382c1_f353b337","line":45,"updated":"2026-06-23 21:12:21.000000000","message":"Hi, the `CS_MODE_RISCV_C` appears to be an enum value instead of a define for the version I was trying (https://github.com/capstone-engine/capstone/blob/next/include/capstone/capstone.h#L261), so even though its available the build then fails with `error: \u0027CS_MODE_RISCVC\u0027 undeclared`\n\ncould you please check, maybe the `ifndef` is not needed now?","commit_id":"03f0234c6545181f48a020e6a8a6586e32c00c26"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a0010a9c4fab8cf8c0a8ad4bf47a7853e4653423","unresolved":true,"context_lines":[{"line_number":42,"context_line":"#endif /* CS_API_MAJOR \u003c 6 */"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#if CS_API_MAJOR \u003e\u003d 6"},{"line_number":45,"context_line":"#ifndef CS_MODE_RISCV_C"},{"line_number":46,"context_line":"#define CS_MODE_RISCV_C CS_MODE_RISCVC"},{"line_number":47,"context_line":"#endif"},{"line_number":48,"context_line":"\t{ \"arm64\", CS_ARCH_AARCH64, CS_MODE_LITTLE_ENDIAN },"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"57b5884b_46c35d95","line":45,"in_reply_to":"193382c1_f353b337","updated":"2026-06-24 09:07:20.000000000","message":"Yes, it\u0027s not a macro, the patch is wrong.\nThe only way to handle it is by checking CS_API_MAJOR.\nWe are not going to support Capstone during its dev process to 6.0, we are only anticipating the changes by looking at the head of `next` branch.\nSo for 6.0 the current status is `CS_MODE_RISCVC` replaced by `CS_MODE_RISCV_C` and we should only use the latter.","commit_id":"03f0234c6545181f48a020e6a8a6586e32c00c26"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"25f144519c4796c7bb9de07e91b0291debdaba4e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"#endif /* CS_API_MAJOR \u003c 6 */"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#if CS_API_MAJOR \u003e\u003d 6"},{"line_number":45,"context_line":"#ifndef CS_MODE_RISCV_C"},{"line_number":46,"context_line":"#define CS_MODE_RISCV_C CS_MODE_RISCVC"},{"line_number":47,"context_line":"#endif"},{"line_number":48,"context_line":"\t{ \"arm64\", CS_ARCH_AARCH64, CS_MODE_LITTLE_ENDIAN },"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a5974759_89c144f6","line":45,"in_reply_to":"57b5884b_46c35d95","updated":"2026-06-25 16:48:17.000000000","message":"Done","commit_id":"03f0234c6545181f48a020e6a8a6586e32c00c26"}]}