)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"1fbcbcd28c10c0d1bb7b4552ae66b8108eded486","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4ac014e7_187b363c","updated":"2026-07-13 08:03:48.000000000","message":"Thanks","commit_id":"51eaf41778dd68fb8cb950d90bc9e5af57b62fee"}],"tcl/target/spacemit-k1.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56170f540baf3619e2632b156fe3a41fc2f618a4","unresolved":true,"context_lines":[{"line_number":97,"context_line":"            }"},{"line_number":98,"context_line":"            set hartid [expr {$cluster * 4 + $coreid}]"},{"line_number":99,"context_line":"            target create $_TARGETNAME.$hartid riscv -chain-position $_CHIPNAME.cpu \\"},{"line_number":100,"context_line":"                -coreid $coreid -dbgbase $dbgbase -check-dbgbase off"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            if { $hartid \u003d\u003d 0 } {"},{"line_number":103,"context_line":"                $_TARGETNAME.$hartid configure -rtos hwthread"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"6a77cfb5_377d0eb3","line":100,"updated":"2026-07-12 17:03:00.000000000","message":"`-check-dbgbase` is proposed in https://review.openocd.org/c/openocd/+/9694/2 and dropped in last version of that patch.\nHaving isolated gerrit commits that depends from other commits it\u0027s hard to track.\nFor the future, please try to push series in gerrit witht he correct dependencies, or post a comment in gerrit to explain that the commit depends on another","commit_id":"f79008d08be96d673ffd52d6246a022fb1c18cf0"},{"author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"change_message_id":"3aa1016275a1d42cf1b275929f6d78979a900438","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            }"},{"line_number":98,"context_line":"            set hartid [expr {$cluster * 4 + $coreid}]"},{"line_number":99,"context_line":"            target create $_TARGETNAME.$hartid riscv -chain-position $_CHIPNAME.cpu \\"},{"line_number":100,"context_line":"                -coreid $coreid -dbgbase $dbgbase -check-dbgbase off"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            if { $hartid \u003d\u003d 0 } {"},{"line_number":103,"context_line":"                $_TARGETNAME.$hartid configure -rtos hwthread"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"5499e996_e1a5b750","line":100,"in_reply_to":"6a77cfb5_377d0eb3","updated":"2026-07-13 01:55:16.000000000","message":"Done","commit_id":"f79008d08be96d673ffd52d6246a022fb1c18cf0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"56170f540baf3619e2632b156fe3a41fc2f618a4","unresolved":true,"context_lines":[{"line_number":109,"context_line":"    eval $_smp_command"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"[target current] configure -event examine-end {"},{"line_number":113,"context_line":"    adapter speed $_SPEED"},{"line_number":114,"context_line":"    puts [ adapter speed ]"},{"line_number":115,"context_line":"    puts [ targets ]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ec46b1e8_5aa7c956","line":112,"updated":"2026-07-12 17:03:00.000000000","message":"Using here `[target current]` is quite unusual.\nIt will match the target of last `target create` command.\nSince the event doesn\u0027t do anything special to any target, I think it would be better keeping it to a fixed target, e.g. `$_TARGETNAME.0` as before","commit_id":"f79008d08be96d673ffd52d6246a022fb1c18cf0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"782d9e1adedc6bfdbd31fa4447623cf360ed4acd","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    eval $_smp_command"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"[target current] configure -event examine-end {"},{"line_number":113,"context_line":"    adapter speed $_SPEED"},{"line_number":114,"context_line":"    puts [ adapter speed ]"},{"line_number":115,"context_line":"    puts [ targets ]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"6df04e5f_688cc001","line":112,"in_reply_to":"932df4ea_76b1204d","updated":"2026-07-25 10:43:47.000000000","message":"Ack","commit_id":"f79008d08be96d673ffd52d6246a022fb1c18cf0"},{"author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"change_message_id":"3aa1016275a1d42cf1b275929f6d78979a900438","unresolved":true,"context_lines":[{"line_number":109,"context_line":"    eval $_smp_command"},{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"[target current] configure -event examine-end {"},{"line_number":113,"context_line":"    adapter speed $_SPEED"},{"line_number":114,"context_line":"    puts [ adapter speed ]"},{"line_number":115,"context_line":"    puts [ targets ]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"932df4ea_76b1204d","line":112,"in_reply_to":"ec46b1e8_5aa7c956","updated":"2026-07-13 01:55:16.000000000","message":"Thanks for the review. The target name is dynamically computed as $_TARGETNAME.$hartid, so it cannot be hardcoded to a fixed $_TARGETNAME.0 as before.","commit_id":"f79008d08be96d673ffd52d6246a022fb1c18cf0"}]}