)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"a8dd9613593a8063fa1d749da78d6e1c00766e15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c7b9a52_12859380","updated":"2026-06-25 09:58:45.000000000","message":"I only noticed a typo in the error message.\n\nOtherwise LGTM, thank you.","commit_id":"bb099deede6a1b2a932b2d188cb0515bf2625001"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"d45586a69f69f3750fdb2f8fe939579dfd7d3eec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"10886bad_4501089e","updated":"2026-06-25 15:23:08.000000000","message":"Thanks for the patch!\nOne minor note on the message, though I feel like it needs to be addressed.","commit_id":"bb099deede6a1b2a932b2d188cb0515bf2625001"}],"src/target/riscv/riscv-013.c":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"a8dd9613593a8063fa1d749da78d6e1c00766e15","unresolved":true,"context_lines":[{"line_number":1959,"context_line":"\t\tget_field(dmcontrol, DM_DMCONTROL_HARTSELLO);"},{"line_number":1960,"context_line":""},{"line_number":1961,"context_line":"\tif ((uint32_t)target-\u003ecoreid \u003e hartsel) {"},{"line_number":1962,"context_line":"\t\tLOG_TARGET_ERROR(target, \"No hart with index %u does not exist. There\""},{"line_number":1963,"context_line":"\t\t\t\" are only %u harts found on the DM (with indexes 0 .. %u)\","},{"line_number":1964,"context_line":"\t\t\ttarget-\u003ecoreid, hartsel + 1, hartsel);"},{"line_number":1965,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6e576778_e1412ec5","line":1962,"updated":"2026-06-25 09:58:45.000000000","message":"Nitpick - extra \"No\": `Hart with index %u does not exist.`","commit_id":"bb099deede6a1b2a932b2d188cb0515bf2625001"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"d45586a69f69f3750fdb2f8fe939579dfd7d3eec","unresolved":true,"context_lines":[{"line_number":1959,"context_line":"\t\tget_field(dmcontrol, DM_DMCONTROL_HARTSELLO);"},{"line_number":1960,"context_line":""},{"line_number":1961,"context_line":"\tif ((uint32_t)target-\u003ecoreid \u003e hartsel) {"},{"line_number":1962,"context_line":"\t\tLOG_TARGET_ERROR(target, \"No hart with index %u does not exist. There\""},{"line_number":1963,"context_line":"\t\t\t\" are only %u harts found on the DM (with indexes 0 .. %u)\","},{"line_number":1964,"context_line":"\t\t\ttarget-\u003ecoreid, hartsel + 1, hartsel);"},{"line_number":1965,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2d18f9c0_290a6854","line":1962,"in_reply_to":"6e576778_e1412ec5","updated":"2026-06-25 15:23:08.000000000","message":"One more note regarding this message -- I would suggest dropping the part about \"There are only %u harts found on the DM\". The issue is, that the reported number of harts is not correct (e.g. for 3 harts and 2-bit `hartsel`).\nI\u0027d suggest something like:\n```\n\"Hart index %u is too large. The maximum index for this Debug Module is %u\".\n```\n\nAlso a minor nitpick: `hartsel` is `uint32_t`, so it would be better to use `PRIu32` for it.","commit_id":"bb099deede6a1b2a932b2d188cb0515bf2625001"}]}