)]}'
{"id":"openocd~master~Ib719c0d275eca447bc1882d92dddc96657c8661f","project":"openocd","branch":"master","attention_set":{"1002532":{"account":{"_account_id":1002532,"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","username":"OpinionatedDeer"},"last_update":"2026-06-27 01:00:11.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ib719c0d275eca447bc1882d92dddc96657c8661f","subject":"target/smp: preserve SMP group ID across smp off; smp on","status":"NEW","created":"2026-06-27 00:12:25.000000000","updated":"2026-06-27 18:19:16.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"37ecd18e645b7f56edf4d9fc623f7e54d9bcde60","_number":9759,"owner":{"_account_id":1002532,"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","username":"OpinionatedDeer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-06-27 18:19:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-06-27 00:12:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-06-27 01:00:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"30f059b77ef38e4620b73dae733783f190a1a15f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002532,"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","username":"OpinionatedDeer"},"real_author":{"_account_id":1002532,"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","username":"OpinionatedDeer"},"date":"2026-06-27 00:12:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b2b65999ae8551a062a697556c51414d410a1efe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002532,"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","username":"OpinionatedDeer"},"real_author":{"_account_id":1002532,"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","username":"OpinionatedDeer"},"date":"2026-06-27 01:00:03.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"31c6ab123b99d02259c19cd95a0820f777d4a11a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-06-27 01:00:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22560/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/23461/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ecc9a8ad79ebe877814ace8a8f46d050387d34d2","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-06-27 01:00:19.000000000","message":"Patch Set 2: -Verified","accounts_in_message":[],"_revision_number":2},{"id":"f648eb2e891d69d3f5231554c1a48b5b8fb4d179","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-06-27 01:30:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22562/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23463/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"c3210fe40a7f185063a5f4c1103ca8509fab3546","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002532,"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","username":"OpinionatedDeer"},"real_author":{"_account_id":1002532,"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","username":"OpinionatedDeer"},"date":"2026-06-27 17:58:43.000000000","message":"Patch Set 3: Commit message was updated.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"37ecd18e645b7f56edf4d9fc623f7e54d9bcde60","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-06-27 18:19:16.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22563/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23464/ : SUCCESS","accounts_in_message":[],"_revision_number":3}],"current_revision":"8c5bbe99a2f343fc41fe2d201f90cd7eb0bb3cb2","revisions":{"8c5bbe99a2f343fc41fe2d201f90cd7eb0bb3cb2":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2026-06-27 17:58:43.000000000","uploader":{"_account_id":1002532,"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","username":"OpinionatedDeer"},"ref":"refs/changes/59/9759/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/9759/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/3 \u0026\u0026 git checkout -b change-9759 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/9759/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2734f8e1f869f26194b4553d811d703358af3ca6","subject":"testing: tcl_commands: test `target smp` command"}],"author":{"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","date":"2026-06-27 00:08:57.000000000","tz":330},"committer":{"name":"mriganshchaudhary","email":"mriganshchaudhary@tutamail.com","date":"2026-06-27 17:58:43.000000000","tz":0},"subject":"target/smp: preserve SMP group ID across smp off; smp on","message":"target/smp: preserve SMP group ID across smp off; smp on\n\nRunning smp off; smp on changes the SMP group identifier of all targets\nin the group to 1, disregarding the original group number assigned by\nthe target smp command. RISC-V targets use this identifier as the DM\nhalt group ID, so the halt group becomes misconfigured without the DM\nbeing updated.\nFix by introducing target-\u003esmp_id to store the persistent group\nidentifier, separate from target-\u003esmp which is now purely an SMP\nenable/disable flag. The smp on command restores smp from smp_id\n\nLink: https://github.com/riscv-collab/riscv-openocd/issues/1294\nChange-Id: Ib719c0d275eca447bc1882d92dddc96657c8661f\nSigned-off-by: OpinionatedDeer \u003cmriganshchaudhary@tutamail.com\u003e\n"},"description":"Edit commit message"},"f7804b347e3a6aecdc8fb8f04dda756c2cadbb41":{"kind":"NO_CHANGE","_number":2,"created":"2026-06-27 01:00:03.000000000","uploader":{"_account_id":1002532,"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","username":"OpinionatedDeer"},"ref":"refs/changes/59/9759/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/9759/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/2 \u0026\u0026 git checkout -b change-9759 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/9759/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2734f8e1f869f26194b4553d811d703358af3ca6","subject":"testing: tcl_commands: test `target smp` command"}],"author":{"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","date":"2026-06-27 00:08:57.000000000","tz":330},"committer":{"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","date":"2026-06-27 00:58:29.000000000","tz":330},"subject":"target/smp: preserve SMP group ID across smp off; smp on Running smp off; smp on changes the SMP group identifier of all targets in the group to 1, disregarding the original group number assigned by the target smp command. RISC-V targets use this identifier as the DM halt group ID, so the halt group becomes misconfigured without the DM being updated. Fix by introducing target-\u003esmp_id to store the persistent group identifier, separate from target-\u003esmp which is now purely an SMP enable/disable flag. The smp on command restores smp from smp_id","message":"target/smp: preserve SMP group ID across smp off; smp on\nRunning smp off; smp on changes the SMP group identifier of all targets\nin the group to 1, disregarding the original group number assigned by\nthe target smp command. RISC-V targets use this identifier as the DM\nhalt group ID, so the halt group becomes misconfigured without the DM\nbeing updated.\nFix by introducing target-\u003esmp_id to store the persistent group\nidentifier, separate from target-\u003esmp which is now purely an SMP\nenable/disable flag. The smp on command restores smp from smp_id\n\nLink: https://github.com/riscv-collab/riscv-openocd/issues/1294\nChange-Id: Ib719c0d275eca447bc1882d92dddc96657c8661f\nSigned-off-by: OpinionatedDeer \u003cmriganshchaudhary@tutamail.com\u003e\n"}},"a74c56b713a8a191a07816415d91efd29a21f487":{"kind":"REWORK","_number":1,"created":"2026-06-27 00:12:25.000000000","uploader":{"_account_id":1002532,"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","username":"OpinionatedDeer"},"ref":"refs/changes/59/9759/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/9759/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/1 \u0026\u0026 git checkout -b change-9759 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/9759/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/9759/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2734f8e1f869f26194b4553d811d703358af3ca6","subject":"testing: tcl_commands: test `target smp` command"}],"author":{"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","date":"2026-06-27 00:08:57.000000000","tz":330},"committer":{"name":"OpinionatedDeer","email":"mriganshchaudhary@tutamail.com","date":"2026-06-27 00:12:25.000000000","tz":330},"subject":"target/smp: preserve SMP group ID across smp off; smp on Running smp off; smp on changes the SMP group identifier of all targets in the group to 1, disregarding the original group number assigned by the target smp command. RISC-V targets use this identifier as the DM halt group ID, so the halt group becomes misconfigured without the DM being updated. Fix by introducing target-\u003esmp_id to store the persistent group identifier, separate from target-\u003esmp which is now purely an SMP enable/disable flag. The smp on command restores smp from smp_id","message":"target/smp: preserve SMP group ID across smp off; smp on\nRunning smp off; smp on changes the SMP group identifier of all targets\nin the group to 1, disregarding the original group number assigned by\nthe target smp command. RISC-V targets use this identifier as the DM\nhalt group ID, so the halt group becomes misconfigured without the DM\nbeing updated.\nFix by introducing target-\u003esmp_id to store the persistent group\nidentifier, separate from target-\u003esmp which is now purely an SMP\nenable/disable flag. The smp on command restores smp from smp_id\n\nLink: https://github.com/riscv-collab/riscv-openocd/issues/1294\nChange-Id: Ib719c0d275eca447bc1882d92dddc96657c8661f\nSigned-off-by: OpinionatedDeer \u003cmriganshchaudhary@tutamail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}