)]}'
{"id":"openocd~master~Idd89adb57e5a782f141f02d9ccdd1911f3aa9bee","project":"openocd","branch":"master","attention_set":{"1002502":{"account":{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"},"last_update":"2026-07-12 10:57:20.000000000","reason":"Reviewer was added"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-07-12 20:01:33.000000000","reason":"Vote got outdated and was removed: Code-Review+1"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Idd89adb57e5a782f141f02d9ccdd1911f3aa9bee","subject":"helper: add tcl-common","status":"NEW","created":"2026-07-12 10:57:20.000000000","updated":"2026-07-12 20:43:41.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e8ce6537a16b325274daf2da97a68277a7f42e16","_number":9781,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-07-12 20:43:41.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"},{"tag":"autogenerated:gerrit:newPatchSet","value":1,"date":"2026-07-12 20:01:33.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-12 10:57:20.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"},"state":"REVIEWER"},{"updated":"2026-07-12 11:04:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-07-12 11:39:07.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1efe985d6937753bbee7de35eaf3f5a68bcabdaa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-07-12 10:57:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"20d77b16781198ea50f6f1270d335f6035870fb9","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-07-12 11:39:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22626/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23528/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"aa8c53d93c5e94622cdde7698147b698863965a0","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-07-12 12:14:01.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8e7c409e3c886a21b25c72569ef5b1977d78f002","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-07-12 20:01:33.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"e8ce6537a16b325274daf2da97a68277a7f42e16","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-07-12 20:43:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22628/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23530/ : SUCCESS","accounts_in_message":[],"_revision_number":2}],"current_revision":"d8d251ac9dbce45609c62cfaede9d00388227ba5","revisions":{"964280bab3e4190d8f26b1a72f478f5525f5151e":{"kind":"REWORK","_number":1,"created":"2026-07-12 10:57:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/81/9781/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/9781/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/9781/1 \u0026\u0026 git checkout -b change-9781 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/9781/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/9781/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/9781/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/9781/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/9781/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb52502e88832386610add9781030f5380344063","subject":"contrib/firmware/angie: Add PREFIX to makebin command"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-09 15:54:23.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-07-12 10:47:00.000000000","tz":120},"subject":"helper: add tcl-common","message":"helper: add tcl-common\n\nAdd a new helper file to start moving there the code specific to\nJim Tcl.\nCoding with Jim Tcl require knowledge and dedicated review effort\nto properly handle its garbage collection.\n\nHaving such specific helper will let us focus in a single place:\n- the knowledge of Jim Tcl garbage collection;\n- the use of Jim Tcl error codes JIM_OK and JIM_ERR;\n- the use of CamelCase symbols of Jim Tcl.\n\nConfining Jim Tcl code in a single file could also make easier the\nswitch to a different Tcl library, in the remote case we need to\naddress it.\n\nChange-Id: Idd89adb57e5a782f141f02d9ccdd1911f3aa9bee\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"d8d251ac9dbce45609c62cfaede9d00388227ba5":{"kind":"REWORK","_number":2,"created":"2026-07-12 20:01:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/81/9781/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/81/9781/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/81/9781/2 \u0026\u0026 git checkout -b change-9781 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/81/9781/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/81/9781/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/81/9781/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/81/9781/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/81/9781/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb52502e88832386610add9781030f5380344063","subject":"contrib/firmware/angie: Add PREFIX to makebin command"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2025-05-09 15:54:23.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-07-12 20:00:25.000000000","tz":120},"subject":"helper: add tcl-common","message":"helper: add tcl-common\n\nAdd a new helper file to start moving there the code specific to\nJim Tcl.\nCoding with Jim Tcl require knowledge and dedicated review effort\nto properly handle its garbage collection.\n\nHaving such specific helper will let us focus in a single place:\n- the knowledge of Jim Tcl garbage collection;\n- the use of Jim Tcl error codes JIM_OK and JIM_ERR;\n- the use of CamelCase symbols of Jim Tcl.\n\nConfining Jim Tcl code in a single file could also make easier the\nswitch to a different Tcl library, in the remote case we need to\naddress it.\n\nChange-Id: Idd89adb57e5a782f141f02d9ccdd1911f3aa9bee\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}