)]}'
{"id":"openocd~master~I898c314a02d455946e35223a43f7a65ed4c92833","project":"openocd","branch":"master","attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-07-13 09:11:09.000000000","reason":"\u003cGERRIT_ACCOUNT_1002502\u003e replied on the change","reason_account":{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"}}},"removed_from_attention_set":{"1002502":{"account":{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"},"last_update":"2026-07-13 09:11:09.000000000","reason":"\u003cGERRIT_ACCOUNT_1002502\u003e replied on the change","reason_account":{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"}}},"hashtags":[],"change_id":"I898c314a02d455946e35223a43f7a65ed4c92833","subject":"helper: tcl-common: add tcl_escape_alloc()","status":"NEW","created":"2026-07-12 10:57:20.000000000","updated":"2026-07-13 09:11:09.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"31846c67734392f6ada9123fff45484af07b8c68","_number":9782,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-07-12 20:26:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":1,"date":"2026-07-13 09:11:09.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"},{"tag":"autogenerated:gerrit:newPatchSet","value":1,"date":"2026-07-12 20:01:33.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-12 10:57:20.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"},"state":"REVIEWER"},{"updated":"2026-07-12 10:57:33.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-07-12 11:20:55.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5f6a93fea71f242a5496300c815789197c287dcb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-07-12 10:57:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8099e355f6be7665ea05b9d2a24356a0e8bf2d04","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-07-12 11:20:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22625/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23527/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8d52e4c04c0ceee985e8505934ab9e6372df9b5c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-07-12 12:13:54.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"1003b44c578f9e9fb151c69208812b91960aa1f5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-07-12 12:17:09.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"23f7594069f1d9b73cee168642b7698b297ad567","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-07-12 20:01:33.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"4f66e142817ace271ec2ec62d10364a134aa97a1","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-07-12 20:26:58.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22627/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23529/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"cf48b6bb7f30d44bef40a2f4ce8c63d61b1102ea","author":{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"},"real_author":{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"},"date":"2026-07-13 08:08:13.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"63e0a3856e45b2e4b6d57f0e499becae7185126a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-07-13 08:52:01.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"31846c67734392f6ada9123fff45484af07b8c68","author":{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"},"real_author":{"_account_id":1002502,"name":"Tim Hutt","email":"tdhutt@gmail.com","username":"Timmmm"},"date":"2026-07-13 09:11:09.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2}],"current_revision":"bb02024970baba5045383839d46bf339a959df2b","revisions":{"bb02024970baba5045383839d46bf339a959df2b":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-07-12 20:01:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/82/9782/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/9782/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/9782/2 \u0026\u0026 git checkout -b change-9782 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/9782/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/9782/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/9782/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/9782/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/9782/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d8d251ac9dbce45609c62cfaede9d00388227ba5","subject":"helper: add tcl-common"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-07-12 09:31:47.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-07-12 20:00:25.000000000","tz":120},"subject":"helper: tcl-common: add tcl_escape_alloc()","message":"helper: tcl-common: add tcl_escape_alloc()\n\nOpenOCD commands can produce a Tcl output ready to be parsed in\nTcl scripts.\nWhen a string has to be converted in a single Tcl element, the\nOpenOCD command has to guarantee that he string does not contains\ncharacter that can confuse the Tcl parsing. A typical example is\nthe presence of whitespace that can split the element in two,\nsquare brackets that can be expanded executing the content.\n\nRely on Jim Tcl API Jim_NewListObj() to handle all such corner\ncases.\n\nThe string returned by tcl_escape_alloc() has to be free() by the\ncaller.\n\nChange-Id: I898c314a02d455946e35223a43f7a65ed4c92833\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5be560e694d326ef60894d5aea02e854c13a7584":{"kind":"REWORK","_number":1,"created":"2026-07-12 10:57:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/82/9782/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/82/9782/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/82/9782/1 \u0026\u0026 git checkout -b change-9782 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/82/9782/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/82/9782/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/82/9782/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/82/9782/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/82/9782/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"964280bab3e4190d8f26b1a72f478f5525f5151e","subject":"helper: add tcl-common"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-07-12 09:31:47.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-07-12 10:47:25.000000000","tz":120},"subject":"helper: tcl-common: add tcl_escape_alloc()","message":"helper: tcl-common: add tcl_escape_alloc()\n\nOpenOCD commands can produce a Tcl output ready to be parsed in\nTcl scripts.\nWhen a string has to be converted in a single Tcl element, the\nOpenOCD command has to guarantee that he string does not contains\ncharacter that can confuse the Tcl parsing. A typical example is\nthe presence of whitespace that can split the element in two,\nsquare brackets that can be expanded executing the content.\n\nRely on Jim Tcl API Jim_NewListObj() to handle all such corner\ncases.\n\nThe string returned by tcl_escape_alloc() has to be free() by the\ncaller.\n\nChange-Id: I898c314a02d455946e35223a43f7a65ed4c92833\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}
