)]}'
{"id":"openocd~master~I00a2649d686e1faa05901de87c082e79586c1aa7","project":"openocd","branch":"master","attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-07-23 02:59:36.000000000","reason":"\u003cGERRIT_ACCOUNT_1002315\u003e replied on the change","reason_account":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"}}},"removed_from_attention_set":{"1002315":{"account":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"last_update":"2026-07-23 02:59:36.000000000","reason":"\u003cGERRIT_ACCOUNT_1002315\u003e replied on the change","reason_account":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"}}},"hashtags":[],"change_id":"I00a2649d686e1faa05901de87c082e79586c1aa7","subject":"target/riscv: add reset method command support","status":"NEW","created":"2026-07-22 09:17:17.000000000","updated":"2026-07-23 02:59:36.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":6,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"2caa1876897cb0d6dd01567bb3dac6832a8ea2cb","_number":9789,"owner":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-07-22 11:54:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"CC":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-22 09:17:30.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-07-22 09:23:34.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-07-22 09:56:41.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"}],"messages":[{"id":"650c356bbfd3e09ba51f7b7776252b818cf439d8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"real_author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"date":"2026-07-22 09:17:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"93d3f0beb6572556c3ebb4f2142ac8a58a188bf7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"real_author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"date":"2026-07-22 09:23:29.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"6085ae74a288dd87f8fbf3d7e12ccac50c7a0b39","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-07-22 09:23:34.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22667/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/23569/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"fe8a60830566493120e55e3f29b6b3997cebe906","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-07-22 09:51:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22668/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23570/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ea42ab34cc37752499623811e30323cf478875f4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-07-22 09:56:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"478bd295a3efb282afa100419a7d19564784228a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-07-22 09:57:39.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"58ff910deef91095ef2c199e984699a2ab1cca84","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"real_author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"date":"2026-07-22 11:15:48.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"f7245bcec3d8a2276e1ab2245cdea509d859e2bf","author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"real_author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"date":"2026-07-22 11:25:04.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"b29db504b94cd27f08c310dfa7589ee6221cd323","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-07-22 11:54:59.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22669/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23571/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"aec5d0c165ced3f5cc8d9bbe2a7ee5fc994927e2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-07-22 15:09:33.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"2caa1876897cb0d6dd01567bb3dac6832a8ea2cb","author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"real_author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"date":"2026-07-23 02:59:36.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision":"bbe3a3cecf714027a005c259916c411ff2e26f16","revisions":{"bbe3a3cecf714027a005c259916c411ff2e26f16":{"kind":"REWORK","_number":3,"created":"2026-07-22 11:15:48.000000000","uploader":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"ref":"refs/changes/89/9789/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/9789/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/3 \u0026\u0026 git checkout -b change-9789 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/9789/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1bf1ac444a96d9151ae53a1ccf5adf16f8e25e75","subject":"Fix const correctness for strchr and strrchr"}],"author":{"name":"Zane Leung","email":"zhen.liang@spacemit.com","date":"2026-07-22 08:45:56.000000000","tz":480},"committer":{"name":"Zane Leung","email":"zhen.liang@spacemit.com","date":"2026-07-22 10:39:39.000000000","tz":480},"subject":"target/riscv: add reset method command support","message":"target/riscv: add reset method command support\n\nAdd a new \u0027riscv reset_method\u0027 command that allows users to select\na method for resetting harts:\n\n- ndmreset (default): resets the entire hardware platform except for\n  the debugging system, via \u0027dmcontrol.ndmreset\u0027.\n- hartreset: resets only the currently selected harts via\n  \u0027dmcontrol.hartreset\u0027.\n\nNote: the reset command applies to reset all currently created targets.\nUsing ndmreset for this purpose is technically incorrect, as ndmreset\nresets the entire platform rather than currently created targets.\nIn addition, it is incorrect to execute ndmreset once for each hart\nin assert_reset().\n\nChange-Id: I00a2649d686e1faa05901de87c082e79586c1aa7\nSigned-off-by: Zane Leung \u003czhen.liang@spacemit.com\u003e\n"}},"e94073c330ef102a6dc54a86c82c82e7d3a794d4":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-07-22 09:23:29.000000000","uploader":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"ref":"refs/changes/89/9789/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/9789/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/2 \u0026\u0026 git checkout -b change-9789 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/9789/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1bf1ac444a96d9151ae53a1ccf5adf16f8e25e75","subject":"Fix const correctness for strchr and strrchr"}],"author":{"name":"Zane Leung","email":"zhen.liang@spacemit.com","date":"2026-07-22 08:45:56.000000000","tz":480},"committer":{"name":"Zane Leung","email":"zhen.liang@spacemit.com","date":"2026-07-22 09:23:06.000000000","tz":480},"subject":"target/riscv: add reset method command support","message":"target/riscv: add reset method command support\n\nAdd a new \u0027riscv reset_method\u0027 command that allows users to select\na method for resetting harts:\n\n- ndmreset (default): resets the entire hardware platform except for\n  the debugging system, via \u0027dmcontrol.ndmreset\u0027.\n- hartreset: resets only the currently selected harts via\n  \u0027dmcontrol.hartreset\u0027.\n\nNote: the reset command applies to reset all currently created targets.\nUsing ndmreset for this purpose is technically incorrect, as ndmreset\nresets the entire platform rather than currently created targets.\nIn addition, it is incorrect to execute ndmreset once for each hart\nin assert_reset().\n\nChange-Id: I00a2649d686e1faa05901de87c082e79586c1aa7\nSigned-off-by: Zane Leung \u003czhen.liang@spacemit.com\u003e\n"}},"a2556066c0994bf13d253bc70e67c960f33e3d39":{"kind":"REWORK","_number":1,"created":"2026-07-22 09:17:17.000000000","uploader":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"ref":"refs/changes/89/9789/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/89/9789/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/1 \u0026\u0026 git checkout -b change-9789 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/89/9789/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/89/9789/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1bf1ac444a96d9151ae53a1ccf5adf16f8e25e75","subject":"Fix const correctness for strchr and strrchr"}],"author":{"name":"Zane Leung","email":"zhen.liang@spacemit.com","date":"2026-07-22 08:45:56.000000000","tz":480},"committer":{"name":"Zane Leung","email":"zhen.liang@spacemit.com","date":"2026-07-22 09:08:42.000000000","tz":480},"subject":"target/riscv: add reset method command support","message":"target/riscv: add reset method command support\n\nAdd a new \u0027riscv reset_method\u0027 command that allows users to select\na method for resetting harts:\n\n- ndmreset (default): resets the entire hardware platform except for\n  the debugging system, via \u0027dmcontrol.ndmreset\u0027.\n- hartreset: resets only the currently selected harts via\n  \u0027dmcontrol.hartreset\u0027.\n\nNote: the reset command applies to all currently created targets.\nUsing ndmreset for this purpose is technically incorrect, as ndmreset\nresets the entire platform rather than currently created targets.\nIn addition, it is incorrect to execute ndmreset once for each hart\nin assert_reset().\n\nChange-Id: I00a2649d686e1faa05901de87c082e79586c1aa7\nSigned-off-by: Zane Leung \u003czhen.liang@spacemit.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}