)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"4e0c78c3bc8c36b12540c91f470a9a44566a3fe8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9cc6ec0e_481dc516","updated":"2026-07-24 11:38:31.000000000","message":"Can you please describe the motivation for the change in the commit message.\n\nAs it stands, I don\u0027t understand why the reasoning behind the behavior you are changing (see the deleted comments) is incorrect.\n\nMoreover, the commit title mentions a redundant DM examine. Please describe:\n1. How the condition occurs?\n2. Why the examine is redundant?","commit_id":"726d77269b216cda05d818033a625900243f755f"},{"author":{"_account_id":1002315,"name":"liangzhen","email":"zhen.liang@spacemit.com","username":"liangzhen"},"change_message_id":"19d408e29bcccddd4d62e5a7268dfbba760c5cfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80e99ae9_2c1302dd","in_reply_to":"9cc6ec0e_481dc516","updated":"2026-07-24 12:45:46.000000000","message":"\u003e Can you please describe the motivation for the change in the commit message.\n\nI will update the commit message in next patchset.\n\n\u003e Moreover, the commit title mentions a redundant DM examine. Please describe:\n\u003e\n\u003e How the condition occurs?\n\u003e Why the examine is redundant?\n\nplease see the following code：\n\n```\nstatic int examine_dm(struct target *target)\n{\n        dm013_info_t *dm \u003d get_dm(target);\n        if (!dm)\n                return ERROR_FAIL;\n        if (dm-\u003ewas_examined)\n                return ERROR_OK;\n\n        int result;\n\n        if (dm-\u003ewas_reset) {\n                /* The DM was already reset when examining a different hart.\n              ...\n        } else {\n                result \u003d reset_dm(target);\n\n```\n\n`!dm-\u003ewas_examined \u0026\u0026 dm-\u003ewas_reset` indicates that examine_dm() was already executed and return `ERROR_FAIL` when examining a different hart.\n\nIn addition, wait_for_idle_if_needed() is also redundant in `examine_dm()`. If we ensure that DM is only examined once, the following code logic and `examine_dm()` will not execute abstract commands.\n\n```\nstatic int wait_for_idle_if_needed(struct target *target)\n{\n        dm013_info_t *dm \u003d get_dm(target);\n        if (!dm)\n                return ERROR_FAIL;\n        if (!dm-\u003eabstract_cmd_maybe_busy)\n                /* The previous abstract command ended correctly\n                 * and busy was cleared. No need to do anything. */\n                return ERROR_OK;\n\n```","commit_id":"726d77269b216cda05d818033a625900243f755f"}]}
