)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"82120b05156a8afea749f653a3747f198bb80351","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e40ae2e_3bbe4173","updated":"2026-08-29 19:43:25.000000000","message":"Hi Matt, thank you for the patch indeed.\n\nEvgeniy, can you please take a look at this patch?","commit_id":"23bc7a8dd303106f777b5ad1a1ec308ef5b01926"},{"author":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"change_message_id":"be589cb4cc56b6e53ebb58660f53369562b09754","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99503fe1_5148c1ab","in_reply_to":"5e40ae2e_3bbe4173","updated":"2026-09-13 05:46:32.000000000","message":"Hi Paul, I haven\u0027t had any traction on this. Any way to get a review? It\u0027s kind of wild how long this takes, it isn\u0027t ideal - is there any way I can help out?","commit_id":"23bc7a8dd303106f777b5ad1a1ec308ef5b01926"},{"author":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"change_message_id":"6b7d0c7b426366cf44782ab40488b2e1a51e8df3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6e815047_124878cf","updated":"2026-09-25 00:35:04.000000000","message":"@PaulFertser and others - what else do I need to do in order to get this patch merged? Thanks!","commit_id":"ae3ade315a6ab5050d9bac2b61a18605e2fdcaf0"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"abe529dd1e98ce07607240f5a32f58f66e403156","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f1a28e40_61b73c01","updated":"2026-09-17 10:07:25.000000000","message":"I\u0027m sorry for taking so long to response.\n\nThank you for the fix! LGTM\n\nI think we should move away from a compile-time cap and dynamically allocate the storage, but this is a follow-up.","commit_id":"ae3ade315a6ab5050d9bac2b61a18605e2fdcaf0"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"3ebea8c791da2d36e9728f5d48e91da0ff9fe624","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dcf4b677_3de87f5a","updated":"2026-09-17 10:08:13.000000000","message":"I\u0027m sorry, I\u0027ve misclicked(","commit_id":"ae3ade315a6ab5050d9bac2b61a18605e2fdcaf0"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4940a5a04877179d4fc4ba2934fcb6bb993266b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"59da4ca2_0e2c78b3","updated":"2026-09-14 09:24:27.000000000","message":"Matt, sorry for let you wait for so long to get a first review.\nReviewing this I felt that the overall code that handles riscv triggers is really fragmented and hard to follow.\nAnyway the patch looks correct to me, it fixes the out-of-bound access. I\u0027m ok to merge it if nobody complains.","commit_id":"ae3ade315a6ab5050d9bac2b61a18605e2fdcaf0"},{"author":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"change_message_id":"8185daa39dbb1b199c06fe12853c9329bf78e600","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"57471a3f_0dd67ae9","updated":"2026-09-17 16:52:23.000000000","message":"Thanks all! I\u0027m not sure how to get the +2 for the merge though 😊","commit_id":"ae3ade315a6ab5050d9bac2b61a18605e2fdcaf0"},{"author":{"_account_id":1002047,"name":"Evgeniy Naydanov","email":"eugnay@gmail.com","username":"en-sc"},"change_message_id":"abe529dd1e98ce07607240f5a32f58f66e403156","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"427ba12f_eb90af39","in_reply_to":"59da4ca2_0e2c78b3","updated":"2026-09-17 10:07:25.000000000","message":"I\u0027ve been thinking of separating the trigger handling into something like riscv_trigger.c/h, similar to registers. IMHO this will aid readability.","commit_id":"ae3ade315a6ab5050d9bac2b61a18605e2fdcaf0"}],"src/target/riscv/riscv.c":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"ce47da24631fb49aaf18c898059d975d9c1f7569","unresolved":true,"context_lines":[{"line_number":6369,"context_line":"\t\tif (result \u003d\u003d ERROR_FAIL)"},{"line_number":6370,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":6371,"context_line":"\t\tif (result \u003d\u003d ERROR_OK)"},{"line_number":6372,"context_line":"\t\t\tLOG_TARGET_WARNING(target, \"Target has more than %zu triggers; ignoring remaining triggers.\","},{"line_number":6373,"context_line":"\t\t\t\t\tARRAY_SIZE(r-\u003etrigger_tinfo));"},{"line_number":6374,"context_line":"\t}"},{"line_number":6375,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"1166358d_274e9e27","line":6372,"updated":"2026-09-01 06:33:14.000000000","message":"Remove the period please, see https://openocd.org/doc/doxygen/html/stylec.html","commit_id":"23bc7a8dd303106f777b5ad1a1ec308ef5b01926"},{"author":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"change_message_id":"d8596c8f730078de8fdeda1288722b9f8922c1f0","unresolved":false,"context_lines":[{"line_number":6369,"context_line":"\t\tif (result \u003d\u003d ERROR_FAIL)"},{"line_number":6370,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":6371,"context_line":"\t\tif (result \u003d\u003d ERROR_OK)"},{"line_number":6372,"context_line":"\t\t\tLOG_TARGET_WARNING(target, \"Target has more than %zu triggers; ignoring remaining triggers.\","},{"line_number":6373,"context_line":"\t\t\t\t\tARRAY_SIZE(r-\u003etrigger_tinfo));"},{"line_number":6374,"context_line":"\t}"},{"line_number":6375,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7614b493_0876e8e7","line":6372,"in_reply_to":"1166358d_274e9e27","updated":"2026-09-02 04:38:27.000000000","message":"Sorry - the riscv.c file uses periods at the end of messages throughout so I tried to keep it consistent (seems like debug/error messages used them). I will remove this one though 😊","commit_id":"23bc7a8dd303106f777b5ad1a1ec308ef5b01926"}]}
