)]}'
{"id":"openocd~master~Icbcd6cec0e1e9a8a44420f87288e52fd0f3542c3","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002550":{"account":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"last_update":"2026-07-25 15:57:50.000000000","reason":"\u003cGERRIT_ACCOUNT_1002550\u003e replied on the change","reason_account":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"}}},"hashtags":[],"change_id":"Icbcd6cec0e1e9a8a44420f87288e52fd0f3542c3","subject":"target/riscv: fix usage of triggers","status":"NEW","created":"2026-07-25 15:24:47.000000000","updated":"2026-07-25 16:29:19.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"43a9c68a2b133f7014e91787c5ea883335443396","_number":9802,"owner":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":1,"date":"2026-07-25 16:29:19.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"all":[{"value":1,"date":"2026-07-25 15:57:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-25 15:45:46.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-07-25 15:47:19.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c8ea047bce2defebf39ed88642f1bede29a618a7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"real_author":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"date":"2026-07-25 15:24:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a934290470e829493777b50ed2906857edda159c","author":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"real_author":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"date":"2026-07-25 15:36:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b3e472b2abd6cba2fb419016b7370584977fc722","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-07-25 15:47:19.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22696/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/23598/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"1f78bf963803fee92692af1f34a161cbc44545f5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"real_author":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"date":"2026-07-25 15:53:46.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"b75fe8b2831d004498267f2dbfa1427d4b16db51","author":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"real_author":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"date":"2026-07-25 15:57:50.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"43a9c68a2b133f7014e91787c5ea883335443396","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-07-25 16:29:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/22697/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/23599/ : SUCCESS","accounts_in_message":[],"_revision_number":2}],"current_revision":"dda16ba93def25d63e161437804af388a8d2eeac","revisions":{"96102658c3289e170d2807e3e9cc5449098f2375":{"kind":"REWORK","_number":1,"created":"2026-07-25 15:24:47.000000000","uploader":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"ref":"refs/changes/02/9802/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/02/9802/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/02/9802/1 \u0026\u0026 git checkout -b change-9802 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/02/9802/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/02/9802/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/02/9802/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/02/9802/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/02/9802/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"43441cd83b229c106ab505cda047da116d454023","subject":"server: add \u0027services\u0027 command to list service information"}],"author":{"name":"Matthew Waltz","email":"matthewwaltzis@gmail.com","date":"2026-07-25 15:21:13.000000000","tz":-360},"committer":{"name":"Matthew Waltz","email":"matthewwaltzis@gmail.com","date":"2026-07-25 15:21:13.000000000","tz":-360},"subject":"target/riscv: fix usage of triggers","message":"target/riscv: fix usage of triggers\n\nThis fixes a bug where if the device reports more than 16 hardware breakpoints, OpenOCD uses what the device reports when accessing arrays such as trigger_unique_id.\nThis can lead to out of bounds access and crash OpenOCD.\n\nInstead, we make sure that the max breakpoints supported is constrained by the size of the array, and then OpenOCD only uses the maximum it supports.\nChanged the maximum number of hardware breakpoints to 32 to support new RISC-V hardware.\n\nChange-Id: Icbcd6cec0e1e9a8a44420f87288e52fd0f3542c3\nSigned-off-by: Matthew Waltz \u003cmatthewwaltzis@gmail.com\u003e\n"}},"dda16ba93def25d63e161437804af388a8d2eeac":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-07-25 15:53:46.000000000","uploader":{"_account_id":1002550,"name":"Matt Waltz","email":"matthewwaltzis@gmail.com","username":"mateoconlechuga"},"ref":"refs/changes/02/9802/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/02/9802/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/02/9802/2 \u0026\u0026 git checkout -b change-9802 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/02/9802/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/02/9802/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/02/9802/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/02/9802/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/02/9802/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"43441cd83b229c106ab505cda047da116d454023","subject":"server: add \u0027services\u0027 command to list service information"}],"author":{"name":"Matthew Waltz","email":"matthewwaltzis@gmail.com","date":"2026-07-25 15:21:13.000000000","tz":-360},"committer":{"name":"Matthew Waltz","email":"matthewwaltzis@gmail.com","date":"2026-07-25 15:53:30.000000000","tz":-360},"subject":"target/riscv: fix usage of triggers","message":"target/riscv: fix usage of triggers\n\nThis fixes a bug where if the device reports\nmore than 16 hardware breakpoints, OpenOCD uses\nwhat the device reports when accessing arrays such\nas trigger_unique_id. This can lead to out of bounds\naccess and crash OpenOCD.\n\nInstead, we make sure that the max breakpoints\nsupported is constrained by the size of the array,\nand then OpenOCD only uses the maximum it supports.\nChanged the maximum number of hardware breakpoints\nto 32 to support new RISC-V hardware.\n\nChange-Id: Icbcd6cec0e1e9a8a44420f87288e52fd0f3542c3\nSigned-off-by: Matthew Waltz \u003cmatthewwaltzis@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}